SIMPLIFY: Remove iDeviceChemistry from HID descriptor.

Author: forderud

examples/UPS/UPS.ino

@@ -8,12 +8,6 @@
 
 int iIntTimer=0;
 
-
-// String constants 
-const char STRING_DEVICECHEMISTRY[] PROGMEM = "LiP";
-
-const byte bDeviceChemistry = IDEVICECHEMISTRY;
-
 PresentStatus iPresentStatus = {}, iPreviousStatus = {};
 
 byte bCapacityMode = 1;  // unit: 0=mAh, 1=mWh, 2=%
@@ -48,8 +42,6 @@ void setup() {
   PowerDevice.setFeature(HID_PD_CAPACITYMODE, &bCapacityMode, sizeof(bCapacityMode));
   PowerDevice.setFeature(HID_PD_VOLTAGE, &iVoltage, sizeof(iVoltage));
 
-  PowerDevice.setStringFeature(HID_PD_IDEVICECHEMISTRY, &bDeviceChemistry, STRING_DEVICECHEMISTRY);
-
   PowerDevice.setFeature(HID_PD_DESIGNCAPACITY, &iDesignCapacity, sizeof(iDesignCapacity));
   PowerDevice.setFeature(HID_PD_FULLCHRGECAPACITY, &iFullChargeCapacity, sizeof(iFullChargeCapacity));
   PowerDevice.setFeature(HID_PD_REMAININGCAPACITY, &iRemaining, sizeof(iRemaining));

src/HIDPowerDevice.cpp

@@ -47,10 +47,6 @@ static const uint8_t _hidReportDescriptor[] PROGMEM = {
     0x79, IMANUFACTURER, //     STRING INDEX (1)
     0xB1, 0x23, //     FEATURE (Constant, Variable, Absolute, No Wrap, Linear, No Preferred, No Null Position, Nonvolatile, Bitfield)
     0x05, 0x85, //     USAGE_PAGE (Battery System) ====================
-    0x85, HID_PD_IDEVICECHEMISTRY, //     REPORT_ID (31)
-    0x09, 0x89, //     USAGE (iDeviceChemistry)
-    0x79, IDEVICECHEMISTRY, //     STRING INDEX (4)
-    0xB1, 0x23, //     FEATURE (Constant, Variable, Absolute, No Wrap, Linear, No Preferred, No Null Position, Nonvolatile, Bitfield)
     0x85, HID_PD_CAPACITYMODE, //     REPORT_ID (22)
     0x09, 0x2C, //     USAGE (CapacityMode)
     0xB1, 0x23, //     FEATURE (Constant, Variable, Absolute, No Wrap, Linear, No Preferred, No Null Position, Nonvolatile, Bitfield)

src/HIDPowerDevice.h

@@ -41,7 +41,6 @@
 
 #define HID_PD_IPRODUCT              0x01 // FEATURE ONLY
 #define HID_PD_MANUFACTURER          0x03 // FEATURE ONLY
-#define IDEVICECHEMISTRY             0x04
 
 #define HID_PD_PRESENTSTATUS         0x07 // INPUT OR FEATURE(required by Windows)
 #define HID_PD_VOLTAGE               0x0B // 11 INPUT (NA) OR FEATURE(implemented)
@@ -50,9 +49,6 @@
 #define HID_PD_CAPACITYMODE          0x16
 #define HID_PD_DESIGNCAPACITY        0x17
 
-#define HID_PD_IDEVICECHEMISTRY      0x1F // Feature
-
-
 // PresentStatus dynamic flags
 struct PresentStatus {
   uint8_t Charging : 1;                   // bit 0x00