SIMPLIFY: Remove iSerialNumber from HID descriptor.

Author: forderud

examples/UPS/UPS.ino

@@ -11,7 +11,6 @@ int iIntTimer=0;
 
 // String constants 
 const char STRING_DEVICECHEMISTRY[] PROGMEM = "LiP";
-const char STRING_SERIAL[] PROGMEM = "UPS10"; 
 
 const byte bDeviceChemistry = IDEVICECHEMISTRY;
 
@@ -37,9 +36,6 @@ void setup() {
 
   Serial.begin(57600);
 
-  // Serial No is set in a special way as it forms Arduino port name
-  PowerDevice.setSerial(STRING_SERIAL); 
-  
   // Used for debugging purposes. 
   PowerDevice.setOutput(Serial);
 

src/HIDPowerDevice.cpp

@@ -42,10 +42,6 @@ static const uint8_t _hidReportDescriptor[] PROGMEM = {
     0x09, 0xFE, //     USAGE (iProduct)
     0x79, IPRODUCT, //     STRING INDEX (2)
     0xB1, 0x23, //     FEATURE (Constant, Variable, Absolute, No Wrap, Linear, No Preferred, No Null Position, Nonvolatile, Bitfield)
-    0x85, HID_PD_SERIAL, //     REPORT_ID (2)
-    0x09, 0xFF, //     USAGE (iSerialNumber)
-    0x79, ISERIAL, //  STRING INDEX (3)
-    0xB1, 0x23, //     FEATURE (Constant, Variable, Absolute, No Wrap, Linear, No Preferred, No Null Position, Nonvolatile, Bitfield)
     0x85, HID_PD_MANUFACTURER, //     REPORT_ID (3)
     0x09, 0xFD, //     USAGE (iManufacturer)
     0x79, IMANUFACTURER, //     STRING INDEX (1)
@@ -121,7 +117,6 @@ HIDPowerDevice_::HIDPowerDevice_(void) {
 
     // set string ID here
     HID().SetFeature(HID_PD_IPRODUCT, &bProduct, sizeof(bProduct));
-    HID().SetFeature(HID_PD_SERIAL, &bSerial, sizeof(bSerial));
     HID().SetFeature(HID_PD_MANUFACTURER, &bManufacturer, sizeof(bManufacturer));
 }
 

src/HIDPowerDevice.h

@@ -40,7 +40,6 @@
 //================================================================================
 
 #define HID_PD_IPRODUCT              0x01 // FEATURE ONLY
-#define HID_PD_SERIAL                0x02 // FEATURE ONLY
 #define HID_PD_MANUFACTURER          0x03 // FEATURE ONLY
 #define IDEVICECHEMISTRY             0x04
 
@@ -77,7 +76,6 @@ class HIDPowerDevice_  {
 
     const byte bProduct = IPRODUCT;
     const byte bManufacturer = IMANUFACTURER;
-    const byte bSerial = ISERIAL;  
 
 public:
   HIDPowerDevice_(void);