Skip to content

Commit a004e4d

Browse files
committed
fix #955
1 parent 7823585 commit a004e4d

File tree

5 files changed

+11
-5
lines changed

5 files changed

+11
-5
lines changed

app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import mozilla.components.feature.tab.collections.TabCollection
3030
import mozilla.components.feature.tabs.WindowFeature
3131
import mozilla.components.support.base.feature.UserInteractionHandler
3232
import mozilla.components.support.base.feature.ViewBoundFeatureWrapper
33+
import mozilla.components.support.ktx.android.util.dpToPx
3334
import mozilla.components.support.ktx.kotlin.isContentUrl
3435
import mozilla.telemetry.glean.private.NoExtras
3536
import org.mozilla.fenix.GleanMetrics.AddressToolbar
@@ -352,7 +353,11 @@ class BrowserFragment : BaseBrowserFragment(), UserInteractionHandler {
352353
context: Context,
353354
isTablet: Boolean,
354355
) {
355-
addHomeAction(context = context)
356+
if (context.settings().shouldShowHomeButton) {
357+
addHomeAction(context = context)
358+
} else {
359+
(_browserToolbarView as? BrowserToolbarView)?.toolbar?.setPadding(8.dpToPx(resources.displayMetrics), 0, 0, 0)
360+
}
356361
updateTabletToolbarActions(isTablet = isTablet)
357362
(browserToolbarView as? BrowserToolbarView)?.toolbar?.invalidateActions()
358363
}

app/src/main/java/org/mozilla/fenix/home/topsites/TopSites.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ import org.mozilla.fenix.theme.FirefoxTheme
6262
import org.mozilla.fenix.wallpapers.WallpaperState
6363
import kotlin.math.ceil
6464

65-
private const val TOP_SITES_PER_PAGE = 8
65+
private const val TOP_SITES_PER_PAGE = 20
6666
private const val TOP_SITES_PER_ROW = 4
6767
private const val TOP_SITES_ITEM_SIZE = 84
6868
private const val TOP_SITES_ROW_WIDTH = TOP_SITES_PER_ROW * TOP_SITES_ITEM_SIZE

app/src/main/java/org/mozilla/fenix/home/topsites/TopSitesConfigCreator.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ internal fun getTopSitesConfig(
5555
}
5656
},
5757
),
58+
showTopRecentSites = settings.showTopRecentSites
5859
)
5960
}
6061
}

automation/iceraven/install-sdk.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ popd
2121
export ANDROID_SDK_ROOT=$HOME/android-sdk/android-sdk-linux
2222

2323
# Install the weirdly missing NDK
24-
${ANDROID_SDK_ROOT}/cmdline-tools/tools/bin/sdkmanager "ndk;27.2.12479018"
24+
${ANDROID_SDK_ROOT}/cmdline-tools/tools/bin/sdkmanager "ndk;28.2.13676358"
2525

2626
# Point the build at the tools
2727
echo "sdk.dir=${ANDROID_SDK_ROOT}" >> local.properties

gradle/mozconfig.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ gradle.ext.mozconfig.substs.MOZ_APP_VERSION = file("${projectRootDir}/version.tx
1111
gradle.ext.mozconfig.substs.MOZ_ANDROID_FAT_AAR_ARCHITECTURES = true
1212
gradle.ext.mozconfig.substs.MOZ_UPDATE_CHANNEL = 'release'
1313
gradle.ext.mozconfig.substs.ALLOW_INSECURE_GRADLE_REPOSITORIES = true
14-
gradle.ext.mozconfig.substs.ANDROID_BUILD_TOOLS_VERSION = "35.0.0" // build/moz.configure/android-sdk.configure#L61
14+
gradle.ext.mozconfig.substs.ANDROID_BUILD_TOOLS_VERSION = "36.0.0" // build/moz.configure/android-sdk.configure#L140
1515
gradle.ext.mozconfig.topsrcdir = System.getProperty("user.dir")
1616
gradle.ext.mozconfig.topobjdir = System.getProperty("user.dir")
1717

1818
gradle.ext.vcsHashFileContent = false
1919

20-
gradle.startParameter.offline = false
20+
gradle.startParameter.offline = false

0 commit comments

Comments
 (0)