feat(script-sorting): sort alphabetically when higher rules dont apply

Author: travi

src/package/scripts/script-comparator.js

@@ -43,13 +43,13 @@ export default function compareScriptNames(a, b) {
     return 1;
   }
 
-  if (aBase.startsWith('lint:')) {
+  if (aBase.startsWith('lint:') && !bBase.startsWith('lint:')) {
     return -1;
   }
 
-  if (bBase.startsWith('lint:')) {
+  if (bBase.startsWith('lint:') && !aBase.startsWith('lint:')) {
     return 1;
   }
 
-  return 0;
+  return a.localeCompare(b);
 }

src/package/scripts/script-comparator.test.js

@@ -8,8 +8,12 @@ describe('script name comparator', () => {
   const A_BEFORE_B = -1;
   const baseScriptName = any.word();
 
-  it('should consider undefined sort orders as equivalent', async () => {
-    expect(compareScriptNames(any.word(), any.word())).toEqual(0);
+  it('should sort alphabetically if no other rules apply', async () => {
+    const a = `a${any.word()}`;
+    const b = `b${any.word()}`;
+
+    expect(compareScriptNames(a, b)).toEqual(A_BEFORE_B);
+    expect(compareScriptNames(b, a)).toEqual(A_AFTER_B);
   });
 
   it('should sort `pre` scripts ahead of their related scripts', async () => {
@@ -47,6 +51,17 @@ describe('script name comparator', () => {
     expect(compareScriptNames(`pretest:${any.word()}`, `prelint:${any.word()}`)).toEqual(A_AFTER_B);
   });
 
+  it('should sort subscripts alphabetically', async () => {
+    const a = `a${any.word()}`;
+    const b = `b${any.word()}`;
+
+    expect(compareScriptNames(`lint:${a}`, `lint:${b}`)).toEqual(A_BEFORE_B);
+    expect(compareScriptNames(`lint:${b}`, `lint:${a}`)).toEqual(A_AFTER_B);
+
+    expect(compareScriptNames(`test:${a}`, `test:${b}`)).toEqual(A_BEFORE_B);
+    expect(compareScriptNames(`test:${b}`, `test:${a}`)).toEqual(A_AFTER_B);
+  });
+
   it('should sort undefined scripts below `lint:` scripts', async () => {
     expect(compareScriptNames(any.word(), `lint:${any.word()}`)).toEqual(A_AFTER_B);
     expect(compareScriptNames(`lint:${any.word()}`, any.word())).toEqual(A_BEFORE_B);