fixes

Author: saligrama

README.md

@@ -13,6 +13,8 @@ This repository contains Helm Charts to deploy Formal on your Kubernetes cluster
 | Charts                        | Description                                                                                                                     |
 |-------------------------------|---------------------------------------------------------------------------------------------------------------------------------|
 | [connector](charts/connector) | Formal Connector base Helm chart.                                                                                               |
+| [data-discovery-satellite](charts/data-discovery-satellite) | Data Discovery Satellite Helm chart.                                                     |
+| [ai-satellite](charts/ai-satellite) | AI Satellite Helm chart (requires NVIDIA GPU). |
 | [ecr-cred](charts/ecr-cred)   | ECR credentials job. Required for non-AWS environments. Requires `pullWithCredentials=true` in the Connector Helm chart values. |
 
 ## Using the Helm Repository
@@ -41,6 +43,13 @@ Finally, install the Connector chart using:
 $ helm install formal-connector formal/connector -f values.yaml
 ```
 
+The satellites can be installed similarly:
+
+```
+$ helm install formal-data-discovery-satellite formal/data-discovery-satellite -f values.yaml
+$ helm install formal-ai-satellite formal/ai-satellite -f values.yaml
+```
+
 ## Questions
 
 Our team always welcomes any and all questions -- don't hesitate to reach out to a team member directly.

charts/ai-satellite/templates/deployment.yaml

@@ -23,7 +23,6 @@ spec:
     spec:
       securityContext:
         {{- toYaml .Values.podSecurityContext | nindent 8 }}
-      serviceAccountName: {{ include "ai-satellite.serviceAccountName" . }}
       containers:
         - name: {{ .Chart.Name }}
           securityContext:
@@ -35,10 +34,8 @@ spec:
           {{- end }}
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           ports:
-            {{- range .Values.ports }}
-            - name: {{ .name }}
-              containerPort: {{ .port }}
-            {{- end }}
+            - name: grpc
+              containerPort: 50055
             - name: health
               containerPort: 8080
           env:
@@ -52,18 +49,17 @@ spec:
               value: {{ $value | quote }}
             {{- end }}
           resources:
-            {{- toYaml .Values.resources | nindent 12 }}
-          {{- with .Values.volumeMounts }}
-          volumeMounts:
-            {{- toYaml . | nindent 12 }}
-          {{- end }}
+            limits:
+              cpu: {{ .Values.resources.limits.cpu }}
+              memory: {{ .Values.resources.limits.memory }}
+              nvidia.com/gpu: 1
+            requests:
+              cpu: {{ .Values.resources.requests.cpu }}
+              memory: {{ .Values.resources.requests.memory }}
+              nvidia.com/gpu: 1
         {{- with .Values.sidecars }}
         {{- toYaml . | nindent 8 }}
         {{- end }}
-      {{- with .Values.volumes }}
-      volumes:
-        {{- toYaml . | nindent 8 }}
-      {{- end }}
       {{- if .Values.pullWithCredentials }}
       imagePullSecrets:
         - name: formal-ecr-secret

charts/ai-satellite/templates/rbac.yaml

@@ -7,12 +7,10 @@ metadata:
 spec:
   type: ClusterIP
   ports:
-    {{- range .Values.ports }}
-    - port: {{ .port }}
-      targetPort: {{ .name }}
+    - port: 50055
+      targetPort: grpc
       protocol: TCP
-      name: {{ .name }}
-    {{- end }}
+      name: grpc
     - port: 8080
       targetPort: health
       protocol: TCP

charts/ai-satellite/templates/service.yaml

@@ -13,43 +13,22 @@ image:
   pullPolicy: Always
   tag: "latest"
 
-# gRPC listener for the AI satellite
-# NOTE: Port names are limited to 15 characters by Kubernetes (DNS_LABEL spec)
-ports:
-  - name: grpc
-    port: 50055
-
-replicaCount: 2
+replicaCount: 1
 resources:
   requests:
     cpu: 4
     memory: 8Gi
   limits:
     cpu: 8
     memory: 16Gi
-    # Requires a NVIDIA GPU with at least 48GB VRAM.
-    nvidia.com/gpu: 1
 
 securityContext: {}
 podSecurityContext: {}
 env: {}
 podAnnotations:
   cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
-volumes: []
-volumeMounts: []
 tolerations: []
 
-# RBAC resources give pod and lease permissions to the service account for
-# cluster formation (pod discovery + lease-based bootstrap coordination)
-rbac:
-  create: true
-
-# Set to `create` to false and provide your own service account name if you
-# don't want this chart to create one
-serviceAccount:
-  create: true
-  name: ""
-
 # Extra manifests to deploy as an array of objects
 extraManifests: []
   # - apiVersion: v1

charts/ai-satellite/templates/serviceaccount.yaml

@@ -35,10 +35,6 @@ spec:
           {{- end }}
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           ports:
-            {{- range .Values.ports }}
-            - name: {{ .name }}
-              containerPort: {{ .port }}
-            {{- end }}
             - name: health
               containerPort: 8080
           env:
@@ -53,17 +49,9 @@ spec:
             {{- end }}
           resources:
             {{- toYaml .Values.resources | nindent 12 }}
-          {{- with .Values.volumeMounts }}
-          volumeMounts:
-            {{- toYaml . | nindent 12 }}
-          {{- end }}
         {{- with .Values.sidecars }}
         {{- toYaml . | nindent 8 }}
         {{- end }}
-      {{- with .Values.volumes }}
-      volumes:
-        {{- toYaml . | nindent 8 }}
-      {{- end }}
       {{- if .Values.pullWithCredentials }}
       imagePullSecrets:
         - name: formal-ecr-secret

charts/ai-satellite/values.yaml

@@ -13,9 +13,6 @@ image:
   pullPolicy: Always
   tag: "latest"
 
-# Data discovery does not expose any container ports besides health.
-ports: []
-
 replicaCount: 2
 resources:
   requests:
@@ -30,15 +27,8 @@ podSecurityContext: {}
 env: {}
 podAnnotations:
   cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
-volumes: []
-volumeMounts: []
 tolerations: []
 
-# RBAC resources give pod and lease permissions to the service account for
-# cluster formation (pod discovery + lease-based bootstrap coordination)
-rbac:
-  create: true
-
 # Set to `create` to false and provide your own service account name if you
 # don't want this chart to create one
 serviceAccount: