allow missing transactions templates (#1266)

Author: Azorlogh

docs/api/README.md

@@ -421,7 +421,7 @@ func (ctrl *DefaultController) createTransaction(ctx context.Context, store Stor
 	logger := logging.FromContext(ctx).WithField("req", uuid.NewString()[:8])
 	ctx = logging.ContextWithLogger(ctx, logger)
 
-	if schema != nil {
+	if schema != nil && len(schema.Transactions) > 0 {
 		if parameters.Input.Template == "" {
 			err := newErrSchemaValidationError(parameters.SchemaVersion, fmt.Errorf("transactions on this ledger must use a template"))
 			if ctrl.schemaEnforcementMode == SchemaEnforcementStrict {
@@ -438,6 +438,8 @@ func (ctrl *DefaultController) createTransaction(ctx context.Context, store Stor
 		} else {
 			return nil, newErrSchemaValidationError(parameters.SchemaVersion, fmt.Errorf("failed to find transaction template `%s`", parameters.Input.Template))
 		}
+	} else if parameters.Input.Template != "" {
+		return nil, newErrSchemaValidationError(parameters.SchemaVersion, fmt.Errorf("can only use templates on a schema with transaction definitions"))
 	}
 
 	m, err := ctrl.getParser(parameters.Input.Runtime).Parse(parameters.Input.Plain)

internal/controller/ledger/controller_default.go

@@ -26,9 +26,6 @@ func NewSchema(version string, data SchemaData) (Schema, error) {
 	if data.Chart == nil {
 		return Schema{}, NewErrInvalidSchema(errors.New("missing chart of accounts"))
 	}
-	if data.Transactions == nil {
-		return Schema{}, NewErrInvalidSchema(errors.New("missing transaction templates"))
-	}
 	if err := data.Transactions.Validate(); err != nil {
 		return Schema{}, NewErrInvalidSchema(err)
 	}

internal/schema.go

@@ -3268,7 +3268,6 @@ components:
           $ref: "#/components/schemas/V2QueryTemplates"
       required:
         - chart
-        - transactions
     V2Schema:
       type: object
       description: Complete schema structure with metadata

openapi.yaml

@@ -16,7 +16,7 @@ type V2Schema struct {
 	// Chart of account
 	Chart map[string]V2ChartSegment `json:"chart"`
 	// Transaction templates
-	Transactions map[string]V2TransactionTemplate `json:"transactions"`
+	Transactions map[string]V2TransactionTemplate `json:"transactions,omitempty"`
 	// Query templates
 	Queries map[string]V2QueryTemplate `json:"queries,omitempty"`
 }
@@ -55,7 +55,7 @@ func (o *V2Schema) GetChart() map[string]V2ChartSegment {
 
 func (o *V2Schema) GetTransactions() map[string]V2TransactionTemplate {
 	if o == nil {
-		return map[string]V2TransactionTemplate{}
+		return nil
 	}
 	return o.Transactions
 }