Skip to content

Commit 901195e

Browse files
authored
Merge pull request #118 from numary/feature/fix-aliased-import
Fix wrongly named imports due to the "pkg" package introduction.
2 parents 259784b + 003a0e8 commit 901195e

File tree

5 files changed

+37
-37
lines changed

5 files changed

+37
-37
lines changed

cmd/container.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"github.com/numary/ledger/pkg/api"
66
"github.com/numary/ledger/pkg/api/controllers"
77
"github.com/numary/ledger/pkg/ledger"
8-
storage2 "github.com/numary/ledger/pkg/storage"
8+
"github.com/numary/ledger/pkg/storage"
99
"github.com/pkg/errors"
1010
"go.uber.org/fx"
1111
)
@@ -74,7 +74,7 @@ func NewContainer(options ...option) *fx.App {
7474
providers := make([]interface{}, 0)
7575
providers = append(providers,
7676
fx.Annotate(func() string { return cfg.version }, fx.ResultTags(`name:"version"`)),
77-
fx.Annotate(func(driver storage2.Driver) string { return driver.Name() }, fx.ResultTags(`name:"storageDriver"`)),
77+
fx.Annotate(func(driver storage.Driver) string { return driver.Name() }, fx.ResultTags(`name:"storageDriver"`)),
7878
fx.Annotate(func() controllers.LedgerLister { return cfg.ledgerLister }, fx.ResultTags(`name:"ledgerLister"`)),
7979
fx.Annotate(func() string { return cfg.basicAuth }, fx.ResultTags(`name:"httpBasic"`)),
8080
fx.Annotate(ledger.NewResolver, fx.ParamTags(`group:"resolverOptions"`)),
@@ -84,19 +84,19 @@ func NewContainer(options ...option) *fx.App {
8484
fx.As(new(ledger.ResolverOption)),
8585
),
8686
api.NewAPI,
87-
func(driver storage2.Driver) storage2.Factory {
88-
f := storage2.NewDefaultFactory(driver)
87+
func(driver storage.Driver) storage.Factory {
88+
f := storage.NewDefaultFactory(driver)
8989
if cfg.cache {
90-
f = storage2.NewCachedStorageFactory(f)
90+
f = storage.NewCachedStorageFactory(f)
9191
}
9292
if cfg.rememberConfig {
93-
f = storage2.NewRememberConfigStorageFactory(f)
93+
f = storage.NewRememberConfigStorageFactory(f)
9494
}
9595
return f
9696
},
9797
)
9898
invokes := make([]interface{}, 0)
99-
invokes = append(invokes, func(driver storage2.Driver, lifecycle fx.Lifecycle) error {
99+
invokes = append(invokes, func(driver storage.Driver, lifecycle fx.Lifecycle) error {
100100
err := driver.Initialize(context.Background())
101101
if err != nil {
102102
return errors.Wrap(err, "initializing driver")

cmd/container_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package cmd
33
import (
44
"context"
55
"github.com/numary/ledger/pkg/ledgertesting"
6-
storage2 "github.com/numary/ledger/pkg/storage"
6+
"github.com/numary/ledger/pkg/storage"
77
"github.com/numary/ledger/pkg/storage/sqlstorage"
88
"github.com/stretchr/testify/assert"
99
"go.uber.org/fx"
@@ -21,7 +21,7 @@ func TestContainers(t *testing.T) {
2121
{
2222
name: "default",
2323
options: []option{
24-
WithOption(fx.Provide(func() storage2.Driver {
24+
WithOption(fx.Provide(func() storage.Driver {
2525
return sqlstorage.NewInMemorySQLiteDriver()
2626
})),
2727
},
@@ -31,10 +31,10 @@ func TestContainers(t *testing.T) {
3131
options: []option{
3232
WithRememberConfig(false),
3333
WithOption(fx.Provide(ledgertesting.PostgresServer)),
34-
WithOption(fx.Provide(func(t *testing.T, pgServer *ledgertesting.PGServer) storage2.Driver {
34+
WithOption(fx.Provide(func(t *testing.T, pgServer *ledgertesting.PGServer) storage.Driver {
3535
return sqlstorage.NewCachedDBDriver("postgres", sqlstorage.PostgreSQL, pgServer.ConnString())
3636
})),
37-
WithOption(fx.Invoke(func(t *testing.T, storageFactory storage2.Factory) {
37+
WithOption(fx.Invoke(func(t *testing.T, storageFactory storage.Factory) {
3838
store, err := storageFactory.GetStore("testing")
3939
assert.NoError(t, err)
4040
assert.NoError(t, store.Close(context.Background()))

cmd/root.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"github.com/gin-gonic/gin"
99
"github.com/numary/ledger/pkg/api"
1010
"github.com/numary/ledger/pkg/api/controllers"
11-
storage2 "github.com/numary/ledger/pkg/storage"
11+
"github.com/numary/ledger/pkg/storage"
1212
"github.com/numary/ledger/pkg/storage/sqlstorage"
1313
"github.com/numary/machine/script/compiler"
1414
"github.com/pkg/errors"
@@ -127,7 +127,7 @@ func NewRootCommand() *cobra.Command {
127127
Use: "init",
128128
RunE: func(cmd *cobra.Command, args []string) error {
129129
_, err := createContainer(
130-
WithOption(fx.Invoke(func(storageFactory storage2.Factory) error {
130+
WithOption(fx.Invoke(func(storageFactory storage.Factory) error {
131131
s, err := storageFactory.GetStore("default")
132132
if err != nil {
133133
return err
@@ -269,7 +269,7 @@ func createContainer(opts ...option) (*fx.App, error) {
269269

270270
opts = append(opts,
271271
WithVersion(Version),
272-
WithOption(fx.Provide(func() (storage2.Driver, error) {
272+
WithOption(fx.Provide(func() (storage.Driver, error) {
273273
switch viper.GetString("storage.driver") {
274274
case "sqlite":
275275
return sqlstorage.NewOpenCloseDBDriver("sqlite", sqlstorage.SQLite, func(name string) string {

pkg/api/routes/routes.go

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import (
44
"github.com/gin-contrib/cors"
55
"github.com/gin-contrib/logger"
66
"github.com/gin-gonic/gin"
7-
controllers2 "github.com/numary/ledger/pkg/api/controllers"
8-
middlewares2 "github.com/numary/ledger/pkg/api/middlewares"
7+
"github.com/numary/ledger/pkg/api/controllers"
8+
"github.com/numary/ledger/pkg/api/middlewares"
99
"github.com/numary/ledger/pkg/ledger"
1010
"go.uber.org/fx"
1111
)
@@ -16,26 +16,26 @@ var Module = fx.Options(
1616

1717
// Routes -
1818
type Routes struct {
19-
resolver *ledger.Resolver
20-
authMiddleware middlewares2.AuthMiddleware
21-
ledgerMiddleware middlewares2.LedgerMiddleware
22-
configController controllers2.ConfigController
23-
ledgerController controllers2.LedgerController
24-
scriptController controllers2.ScriptController
25-
accountController controllers2.AccountController
26-
transactionController controllers2.TransactionController
19+
resolver *ledger.Resolver
20+
authMiddleware middlewares.AuthMiddleware
21+
ledgerMiddleware middlewares.LedgerMiddleware
22+
configController controllers.ConfigController
23+
ledgerController controllers.LedgerController
24+
scriptController controllers.ScriptController
25+
accountController controllers.AccountController
26+
transactionController controllers.TransactionController
2727
}
2828

2929
// NewRoutes -
3030
func NewRoutes(
3131
resolver *ledger.Resolver,
32-
authMiddleware middlewares2.AuthMiddleware,
33-
ledgerMiddleware middlewares2.LedgerMiddleware,
34-
configController controllers2.ConfigController,
35-
ledgerController controllers2.LedgerController,
36-
scriptController controllers2.ScriptController,
37-
accountController controllers2.AccountController,
38-
transactionController controllers2.TransactionController,
32+
authMiddleware middlewares.AuthMiddleware,
33+
ledgerMiddleware middlewares.LedgerMiddleware,
34+
configController controllers.ConfigController,
35+
ledgerController controllers.LedgerController,
36+
scriptController controllers.ScriptController,
37+
accountController controllers.AccountController,
38+
transactionController controllers.TransactionController,
3939
) *Routes {
4040
return &Routes{
4141
resolver: resolver,

pkg/ledger/ledger_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77
"flag"
88
"fmt"
99
"github.com/numary/ledger/pkg/ledgertesting"
10-
storage2 "github.com/numary/ledger/pkg/storage"
10+
"github.com/numary/ledger/pkg/storage"
1111
"github.com/numary/ledger/pkg/storage/sqlstorage"
1212
"github.com/sirupsen/logrus"
1313
"github.com/stretchr/testify/assert"
@@ -22,20 +22,20 @@ import (
2222
"go.uber.org/fx"
2323
)
2424

25-
var driver storage2.Driver
25+
var driver storage.Driver
2626

2727
func with(f func(l *Ledger)) {
2828
app := fx.New(
2929
fx.NopLogger,
30-
fx.Provide(func() storage2.Driver {
30+
fx.Provide(func() storage.Driver {
3131
return driver
3232
}),
33-
fx.Invoke(func(d storage2.Driver) error {
33+
fx.Invoke(func(d storage.Driver) error {
3434
return d.Initialize(context.Background())
3535
}),
36-
fx.Provide(storage2.NewDefaultFactory),
36+
fx.Provide(storage.NewDefaultFactory),
3737
fx.Provide(
38-
func(storageFactory storage2.Factory) (*Ledger, error) {
38+
func(storageFactory storage.Factory) (*Ledger, error) {
3939
store, err := storageFactory.GetStore("test")
4040
if err != nil {
4141
return nil, err

0 commit comments

Comments
 (0)