rename /schema endpoint to plural (#1263)

Author: Azorlogh

docs/api/README.md

@@ -99,7 +99,7 @@ func TestInsertSchema(t *testing.T) {
 			router := NewRouter(systemController, auth.NewNoAuth(), "develop")
 
 			body, _ := json.Marshal(tc.requestBody)
-			req := httptest.NewRequest(http.MethodPost, "/default/schema/"+tc.version, bytes.NewBuffer(body))
+			req := httptest.NewRequest(http.MethodPost, "/default/schemas/"+tc.version, bytes.NewBuffer(body))
 			req.Header.Set("Content-Type", "application/json")
 			rec := httptest.NewRecorder()
 

internal/api/v2/controllers_schema_insert_test.go

@@ -147,7 +147,7 @@ func TestListSchemas(t *testing.T) {
 
 			router := NewRouter(systemController, auth.NewNoAuth(), "develop")
 
-			req := httptest.NewRequest(http.MethodGet, "/default/schema?"+tc.queryParams.Encode(), nil)
+			req := httptest.NewRequest(http.MethodGet, "/default/schemas?"+tc.queryParams.Encode(), nil)
 			rec := httptest.NewRecorder()
 
 			router.ServeHTTP(rec, req)

internal/api/v2/controllers_schema_list_test.go

@@ -78,7 +78,7 @@ func TestGetSchema(t *testing.T) {
 
 			router := NewRouter(systemController, auth.NewNoAuth(), "develop")
 
-			req := httptest.NewRequest(http.MethodGet, "/default/schema/"+tc.version, nil)
+			req := httptest.NewRequest(http.MethodGet, "/default/schemas/"+tc.version, nil)
 			rec := httptest.NewRecorder()
 
 			router.ServeHTTP(rec, req)

internal/api/v2/controllers_schema_read_test.go

@@ -82,9 +82,9 @@ func NewRouter(
 				))
 				router.Get("/_info", getLedgerInfo)
 				router.Get("/stats", readStats)
-				router.Post("/schema/{version}", insertSchema)
-				router.Get("/schema/{version}", readSchema)
-				router.Get("/schema", listSchemas(routerOptions.paginationConfig))
+				router.Post("/schemas/{version}", insertSchema)
+				router.Get("/schemas/{version}", readSchema)
+				router.Get("/schemas", listSchemas(routerOptions.paginationConfig))
 
 				if routerOptions.exporters {
 					router.Route("/pipelines", func(router chi.Router) {

internal/api/v2/routes.go

@@ -178,7 +178,7 @@ paths:
       security:
         - Authorization:
             - ledger:write
-  /v2/{ledger}/schema/{version}:
+  /v2/{ledger}/schemas/{version}:
     parameters:
       - name: ledger
         in: path
@@ -252,7 +252,7 @@ paths:
       security:
         - Authorization:
             - ledger:read
-  /v2/{ledger}/schema:
+  /v2/{ledger}/schemas:
     parameters:
       - name: ledger
         in: path

openapi.yaml

@@ -673,7 +673,7 @@ func (s *V2) InsertSchema(ctx context.Context, request operations.V2InsertSchema
 	} else {
 		baseURL = *o.ServerURL
 	}
-	opURL, err := utils.GenerateURL(ctx, baseURL, "/v2/{ledger}/schema/{version}", request, nil)
+	opURL, err := utils.GenerateURL(ctx, baseURL, "/v2/{ledger}/schemas/{version}", request, nil)
 	if err != nil {
 		return nil, fmt.Errorf("error generating URL: %w", err)
 	}
@@ -872,7 +872,7 @@ func (s *V2) GetSchema(ctx context.Context, request operations.V2GetSchemaReques
 	} else {
 		baseURL = *o.ServerURL
 	}
-	opURL, err := utils.GenerateURL(ctx, baseURL, "/v2/{ledger}/schema/{version}", request, nil)
+	opURL, err := utils.GenerateURL(ctx, baseURL, "/v2/{ledger}/schemas/{version}", request, nil)
 	if err != nil {
 		return nil, fmt.Errorf("error generating URL: %w", err)
 	}
@@ -1080,7 +1080,7 @@ func (s *V2) ListSchemas(ctx context.Context, request operations.V2ListSchemasRe
 	} else {
 		baseURL = *o.ServerURL
 	}
-	opURL, err := utils.GenerateURL(ctx, baseURL, "/v2/{ledger}/schema", request, nil)
+	opURL, err := utils.GenerateURL(ctx, baseURL, "/v2/{ledger}/schemas", request, nil)
 	if err != nil {
 		return nil, fmt.Errorf("error generating URL: %w", err)
 	}