fix(intl-utils): prevent infinite recursion loop of getCanonicalRules (#591)

pyrocat101 · web-flow · commit 86e087de2dbd · 2020-03-30T13:28:51.000-07:00
diff --git a/packages/intl-utils/src/get-canonical-locales.ts b/packages/intl-utils/src/get-canonical-locales.ts
@@ -8,5 +8,8 @@ export function getCanonicalLocales(locales?: string | string[]): string[] {
   if (typeof getCanonicalLocales === 'function') {
     return getCanonicalLocales(locales) as string[];
   }
-  return Intl.NumberFormat.supportedLocalesOf(locales || '');
+  // NOTE: we must NOT call `supportedLocalesOf` of a formatjs polyfill, or their implementation
+  // will even eventually call this method recursively. Here we use `Intl.DateTimeFormat` since it
+  // is not polyfilled by `@formatjs`.
+  return Intl.DateTimeFormat.supportedLocalesOf(locales || '');
 }

Original file line number	Diff line number	Diff line change
`@@ -8,5 +8,8 @@ export function getCanonicalLocales(locales?: string \| string[]): string[] {`
`8`	`8`	`if (typeof getCanonicalLocales === 'function') {`
`9`	`9`	`return getCanonicalLocales(locales) as string[];`
`10`	`10`	`}`
`11`		`- return Intl.NumberFormat.supportedLocalesOf(locales \|\| '');`
	`11`	+ // NOTE: we must NOT call `supportedLocalesOf` of a formatjs polyfill, or their implementation
	`12`	+ // will even eventually call this method recursively. Here we use `Intl.DateTimeFormat` since it
	`13`	+ // is not polyfilled by `@formatjs`.
	`14`	`+ return Intl.DateTimeFormat.supportedLocalesOf(locales \|\| '');`
`12`	`15`	`}`