Skip to content

Commit 10cd7b2

Browse files
authored
fix: targeted surveys will not be shown to anonymous users (#36)
* fix: targeted surveys will not be shown to anonymous users * testing
1 parent 6377c47 commit 10cd7b2

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

android/src/main/java/com/formbricks/android/manager/SurveyManager.kt

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,13 @@ object SurveyManager {
3939
private val prefManager by lazy { Formbricks.applicationContext.getSharedPreferences(FORMBRICKS_PREFS, Context.MODE_PRIVATE) }
4040
internal var filteredSurveys: MutableList<Survey> = mutableListOf()
4141

42-
// 1) Build your Gson once, registering only the SegmentFilterResource adapter:
4342
val gson = GsonBuilder()
4443
.registerTypeAdapter(
4544
SegmentFilterResource::class.java,
4645
SegmentFilterResourceDeserializer()
4746
)
4847
.create()
4948

50-
51-
5249
private var environmentDataHolderJson: String?
5350
get() {
5451
return prefManager.getString(PREF_FORMBRICKS_DATA_HOLDER, "")
@@ -98,6 +95,13 @@ object SurveyManager {
9895
filteredSurveys = filterSurveysBasedOnDisplayType(surveys, displays, responses).toMutableList()
9996
filteredSurveys = filterSurveysBasedOnRecontactDays(filteredSurveys, environmentDataHolder?.data?.data?.project?.recontactDays?.toInt()).toMutableList()
10097

98+
if (UserManager.userId == null) {
99+
filteredSurveys = filteredSurveys.filter { survey ->
100+
// Only include surveys that have no segment filters or null segment
101+
survey.segment?.filters?.isEmpty() ?: true
102+
}.toMutableList()
103+
}
104+
101105
if (UserManager.userId != null) {
102106
if (segments.isEmpty()) {
103107
filteredSurveys = mutableListOf()

android/src/main/java/com/formbricks/android/manager/UserManager.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,8 @@ object UserManager {
185185
Formbricks.language = "default"
186186
UpdateQueue.reset()
187187

188+
SurveyManager.filterSurveys()
189+
188190
if(isUserIdDefined) {
189191
Logger.d("User logged out successfully!")
190192
}

0 commit comments

Comments
 (0)