fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

Author: pandeymangg

android/src/main/java/com/formbricks/android/model/error/SDKError.kt

@@ -24,4 +24,7 @@ object SDKError {
     val surveyNotFoundError = RuntimeException("No survey found matching the action class.")
     val noUserIdSetError = RuntimeException("No userId is set, please set a userId first using the setUserId function")
 
+    val couldNotCreateDisplayError = RuntimeException("Something went wrong while creating a display. Please try again later")
+    val couldNotCreateResponseError = RuntimeException("Something went wrong while creating a response. Please try again later")
+    val somethingWentWrongError = RuntimeException("Something went wrong. Please try again later")
 }

android/src/main/java/com/formbricks/android/webview/FormbricksFragment.kt

@@ -37,26 +37,35 @@ import com.google.gson.JsonObject
 import java.io.ByteArrayOutputStream
 import java.io.InputStream
 
-
 class FormbricksFragment : BottomSheetDialogFragment() {
-
     private lateinit var binding: FragmentFormbricksBinding
     private lateinit var surveyId: String
     private val viewModel: FormbricksViewModel by viewModels()
+    private var isDismissing = false
 
     private var webAppInterface = WebAppInterface(object : WebAppInterface.WebAppCallback {
         override fun onClose() {
             Handler(Looper.getMainLooper()).post {
-                dismiss()
+                safeDismiss()
             }
         }
 
         override fun onDisplayCreated() {
-            SurveyManager.onNewDisplay(surveyId)
+            try {
+                SurveyManager.onNewDisplay(surveyId)
+            } catch (e: Exception) {
+                val error = SDKError.couldNotCreateDisplayError
+                Logger.e(error)
+            }
         }
 
         override fun onResponseCreated() {
-            SurveyManager.postResponse(surveyId)
+            try {
+                SurveyManager.postResponse(surveyId)
+            } catch (e: Exception) {
+                val error = SDKError.couldNotCreateResponseError
+                Logger.e(error)
+            }
         }
 
         override fun onFilePick(data: FileUploadData) {
@@ -71,7 +80,7 @@ class FormbricksFragment : BottomSheetDialogFragment() {
         override fun onSurveyLibraryLoadError() {
             val error = SDKError.unableToLoadFormbicksJs
             Logger.e(error)
-            dismiss()
+            safeDismiss()
         }
     })
 
@@ -110,6 +119,13 @@ class FormbricksFragment : BottomSheetDialogFragment() {
         }
     }
 
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        arguments?.let {
+            surveyId = it.getString(ARG_SURVEY_ID) ?: throw IllegalArgumentException("Survey ID is required")
+        }
+    }
+
     override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
         binding = FragmentFormbricksBinding.inflate(inflater).apply {
             lifecycleOwner = viewLifecycleOwner
@@ -147,28 +163,24 @@ class FormbricksFragment : BottomSheetDialogFragment() {
         dialog?.window?.setDimAmount(0.0f)
         binding.formbricksWebview.setBackgroundColor(Color.TRANSPARENT)
         binding.formbricksWebview.let {
+            // First configure the WebView
+            it.settings.apply {
+                javaScriptEnabled = true
+                domStorageEnabled = true
+                loadWithOverviewMode = true
+                useWideViewPort = true
+            }
+
             it.webChromeClient = object : WebChromeClient() {
                 override fun onConsoleMessage(consoleMessage: ConsoleMessage?): Boolean {
                     consoleMessage?.let { cm ->
-                        if (cm.messageLevel() == ConsoleMessage.MessageLevel.ERROR) {
-                            val error = SDKError.surveyDisplayFetchError
-                            Logger.e(error)
-                            dismiss()
-                        }
                         val log = "[CONSOLE:${cm.messageLevel()}] \"${cm.message()}\", source: ${cm.sourceId()} (${cm.lineNumber()})"
                         Logger.d(log)
                     }
                     return super.onConsoleMessage(consoleMessage)
                 }
             }
 
-            it.settings.apply {
-                javaScriptEnabled = true
-                domStorageEnabled = true
-                loadWithOverviewMode = true
-                useWideViewPort = true
-            }
-
             it.webViewClient = object : WebViewClient() {
                 override fun onReceivedError(
                     view: WebView?,
@@ -192,11 +204,9 @@ class FormbricksFragment : BottomSheetDialogFragment() {
             }
 
             it.setInitialScale(1)
-
             it.addJavascriptInterface(webAppInterface, WebAppInterface.INTERFACE_NAME)
+            viewModel.loadHtml(surveyId)
         }
-
-        viewModel.loadHtml(surveyId)
     }
 
     private fun getFileName(uri: Uri): String? {
@@ -231,15 +241,40 @@ class FormbricksFragment : BottomSheetDialogFragment() {
         }
     }
 
+    private fun safeDismiss() {
+        if (isDismissing) return
+        isDismissing = true
+        
+        try {
+            if (isAdded && !isStateSaved) {
+                dismiss()
+            } else {
+                // If we can't dismiss safely, just finish the activity
+                activity?.finish()
+            }
+        } catch (e: Exception) {
+            val error = SDKError.somethingWentWrongError
+            Logger.e(error)
+            activity?.finish()
+        }
+    }
+
+    override fun onDestroy() {
+        super.onDestroy()
+        isDismissing = false
+    }
+
     companion object {
         private val TAG: String by lazy { FormbricksFragment::class.java.simpleName }
+        private const val ARG_SURVEY_ID = "survey_id"
 
         fun show(childFragmentManager: FragmentManager, surveyId: String) {
-            val fragment = FormbricksFragment()
-            fragment.surveyId = surveyId
+            val fragment = FormbricksFragment().apply {
+                arguments = Bundle().apply {
+                    putString(ARG_SURVEY_ID, surveyId)
+                }
+            }
             fragment.show(childFragmentManager, TAG)
         }
-
-        private const val CLOSING_TIMEOUT_IN_SECONDS = 5L
     }
 }

android/src/main/java/com/formbricks/android/webview/FormbricksViewModel.kt

@@ -34,11 +34,11 @@ class FormbricksViewModel : ViewModel() {
             </head>
 
             <body style="overflow: hidden; height: 100vh; display: flex; flex-direction: column; justify-content: flex-end;">
-                <div id="formbricks-react-native" style="width: 100%;"></div>
+                <div id="formbricks-android" style="width: 100%;"></div>
             </body>
 
             <script type="text/javascript">
-                var json = `{{WEBVIEW_DATA}}`
+                const json = `{{WEBVIEW_DATA}}`;
 
                 function onClose() {
                     FormbricksJavascript.message(JSON.stringify({ event: "onClose" }));
@@ -62,9 +62,8 @@ class FormbricksViewModel : ViewModel() {
                     };
 
                     window.formbricksSurveys.renderSurvey(surveyProps);
-                }
+                };
 
-              // Function to attach click listener to file inputs
               function attachFilePickerOverride() {
                 const inputs = document.querySelectorAll('input[type="file"]');
                   inputs.forEach(input => {
@@ -81,23 +80,20 @@ class FormbricksViewModel : ViewModel() {
                           fileUploadParams: {
                             allowedFileExtensions: allowedFileExtensions,
                             allowMultipleFiles: allowMultipleFiles === "true",
-                          },
+                          }
                         }));
                       });
                     }
                   });
-              }
+                };
         
-              // Initially attach the override
               attachFilePickerOverride();
         
-              // Set up a MutationObserver to catch dynamically added file inputs
               const observer = new MutationObserver(function (mutations) {
                 attachFilePickerOverride();
               });
         
               observer.observe(document.body, { childList: true, subtree: true });
-
                 const script = document.createElement("script");
                 script.src = "${Formbricks.appUrl}/js/surveys.umd.cjs";
                 script.async = true;
@@ -149,8 +145,6 @@ class FormbricksViewModel : ViewModel() {
             .replace("#", "%23") // Hex color code's # breaks the JSON
             .replace("\\\"","'") // " is replaced to ' in the html codes in the JSON
     }
-
-
 }
 
 @BindingAdapter("htmlText")