chore: add more instrumented tests (#14)

* chore: exclude UI component FormbricksFragment from unit test coverage

* chore: add test for api service

* improve api service and tests

Author: mattinannt

android/src/androidTest/java/com/formbricks/android/network/FormbricksApiServiceInstrumentedTest.kt

@@ -0,0 +1,57 @@
+package com.formbricks.android.network
+
+import android.content.Context
+import androidx.test.core.app.ApplicationProvider
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import androidx.test.platform.app.InstrumentationRegistry
+import com.formbricks.android.model.user.PostUserBody
+import org.junit.Assert.*
+import org.junit.Before
+import org.junit.Test
+import org.junit.runner.RunWith
+
+@RunWith(AndroidJUnit4::class)
+class FormbricksApiServiceInstrumentedTest {
+    private lateinit var context: Context
+    private lateinit var apiService: FormbricksApiService
+
+    @Before
+    fun setUp() {
+        context = ApplicationProvider.getApplicationContext()
+        apiService = FormbricksApiService()
+        // You may want to initialize with a test server or mock URL
+        apiService.initialize("https://example.com", isLoggingEnabled = false)
+    }
+
+    @Test
+    fun testInitialization() {
+        // This test just verifies that initialization does not throw
+        try {
+            apiService.initialize("https://example.com", isLoggingEnabled = false)
+        } catch (e: Exception) {
+            fail("Initialization should not throw: ${e.message}")
+        }
+    }
+
+    @Test
+    fun testGetEnvironmentStateObject_handlesErrorGracefully() {
+        val result = apiService.getEnvironmentStateObject("dummy-environment-id")
+        assertTrue(result.isFailure)
+        result.exceptionOrNull()?.let { e ->
+            println("Exception caught as expected: ${e.message}")
+        }
+    }
+
+    @Test
+    fun testPostUser_handlesErrorGracefully() {
+        // This should fail gracefully since the URL is unreachable
+        val dummyBody = PostUserBody("dummy-user-id", null)
+        val result = apiService.postUser("dummy-environment-id", dummyBody)
+        assertTrue(result.isFailure)
+    }
+
+    // Add more integration-style tests as needed, e.g.:
+    // - testGetEnvironmentStateObject_withMockServer
+    // - testPostUser_withMockServer
+    // These would require a running test server or a mock web server
+} 

android/src/main/java/com/formbricks/android/network/FormbricksApiService.kt

@@ -24,16 +24,20 @@ open class FormbricksApiService {
     }
 
     open fun getEnvironmentStateObject(environmentId: String): Result<EnvironmentDataHolder> {
-        val result = execute {
-            retrofit.create(FormbricksService::class.java)
-                .getEnvironmentState(environmentId)
+        return try {
+            val result = execute {
+                retrofit.create(FormbricksService::class.java)
+                    .getEnvironmentState(environmentId)
+            }
+            val json = Json { ignoreUnknownKeys = true }
+            val resultMap = result.getOrThrow()
+            val resultJson = mapToJsonElement(resultMap).jsonObject
+            val environmentResponse = json.decodeFromJsonElement<EnvironmentResponse>(resultJson)
+            val data = EnvironmentDataHolder(environmentResponse.data, resultMap)
+            Result.success(data)
+        } catch (e: Exception) {
+            Result.failure(e)
         }
-        val json = Json { ignoreUnknownKeys = true }
-        val resultMap = result.getOrThrow()
-        val resultJson = mapToJsonElement(resultMap).jsonObject
-        val environmentResponse = json.decodeFromJsonElement<EnvironmentResponse>(resultJson)
-        val data = EnvironmentDataHolder(environmentResponse.data, resultMap)
-        return Result.success(data)
     }
 
     open fun postUser(environmentId: String, body: PostUserBody): Result<UserResponse> {

sonar-project.properties

@@ -27,7 +27,8 @@ sonar.coverage.exclusions=**/test/**/*,**/androidTest/**/*,**/*.js,**/*.json,\
   **/FormbricksAPIError.kt,\
   **/Logger.kt,\
   **/Guard.kt,\
-  **/DateExtensions.kt
+  **/DateExtensions.kt,\
+  **/webview/FormbricksFragment.kt
 
 # Debug
 sonar.verbose=true