Skip to content

Commit ffde26a

Browse files
authored
fix: sonarqube issue (#9)
* fix: sonarqube issue * fix tests
1 parent dc52b4e commit ffde26a

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

android/src/main/java/com/formbricks/android/manager/UserManager.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ object UserManager {
4848
* @param userId
4949
*/
5050
fun set(userId: String) {
51-
UpdateQueue.current.setUserId(userId)
51+
UpdateQueue.setUserId(userId)
5252
}
5353

5454
/**
@@ -58,7 +58,7 @@ object UserManager {
5858
* @param key
5959
*/
6060
fun addAttribute(attribute: String, key: String) {
61-
UpdateQueue.current.addAttribute(key, attribute)
61+
UpdateQueue.addAttribute(key, attribute)
6262
}
6363

6464
/**
@@ -67,7 +67,7 @@ object UserManager {
6767
* @param attributes
6868
*/
6969
fun setAttributes(attributes: Map<String, String>) {
70-
UpdateQueue.current.setAttributes(attributes)
70+
UpdateQueue.setAttributes(attributes)
7171
}
7272

7373
/**
@@ -76,7 +76,7 @@ object UserManager {
7676
* @param language
7777
*/
7878
fun setLanguage(language: String) {
79-
UpdateQueue.current.setLanguage(language)
79+
UpdateQueue.setLanguage(language)
8080
}
8181

8282
/**
@@ -143,7 +143,7 @@ object UserManager {
143143
Formbricks.language = languageFromUserResponse
144144
}
145145

146-
UpdateQueue.current.reset()
146+
UpdateQueue.reset()
147147
SurveyManager.filterSurveys()
148148
startSyncTimer()
149149
} catch (e: Exception) {
@@ -183,7 +183,7 @@ object UserManager {
183183
backingLastDisplayedAt = null
184184
backingExpiresAt = null
185185
Formbricks.language = "default"
186-
UpdateQueue.current.reset()
186+
UpdateQueue.reset()
187187

188188
if(isUserIdDefined) {
189189
Logger.d("User logged out successfully!")

android/src/main/java/com/formbricks/android/network/queue/UpdateQueue.kt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ import kotlin.concurrent.timer
1111
* The given properties will be sent to the backend and updated in
1212
* the user object when the debounce interval is reached.
1313
*/
14-
class UpdateQueue private constructor() {
14+
object UpdateQueue {
15+
private const val DEBOUNCE_INTERVAL: Long = 500 // 500 ms
1516

1617
private var userId: String? = null
1718
private var attributes: MutableMap<String, String>? = null
@@ -74,9 +75,4 @@ class UpdateQueue private constructor() {
7475
Logger.d("UpdateQueue - commit() called on UpdateQueue with $effectiveUserId and $attributes")
7576
UserManager.syncUser(effectiveUserId, attributes)
7677
}
77-
78-
companion object {
79-
private const val DEBOUNCE_INTERVAL: Long = 500 // 500 ms
80-
val current: UpdateQueue = UpdateQueue()
81-
}
8278
}

0 commit comments

Comments
 (0)