fix: targeted surveys shouldn't be shown to anon users (#14)

* bumps version

* fix: targeted surveys

* fix: targeted surveys

* fix: adds test

* fix: adds test

Author: pandeymangg

packages/react-native/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@formbricks/react-native",
-  "version": "2.1.2",
+  "version": "2.2.0",
   "license": "MIT",
   "description": "Formbricks React Native SDK allows you to connect your app to Formbricks, display surveys and trigger events.",
   "homepage": "https://formbricks.com",

packages/react-native/src/lib/common/tests/utils.test.ts

@@ -158,6 +158,40 @@ describe("utils.ts", () => {
       expect(result[0].id).toBe(mockSurveyId1);
     });
 
+    test("filters out surveys that have a segment with filters if userId is not set", () => {
+      environment.data.surveys = [
+        {
+          ...baseSurvey,
+          id: mockSurveyId1,
+          segment: {
+            id: mockSegmentId1,
+            filters: [{ type: "string", key: "name", value: "John" }],
+          },
+        } as TSurvey,
+      ];
+
+      const result = filterSurveys(environment, user);
+      expect(result).toHaveLength(0);
+    });
+
+    test("includes surveys without segment filters for anonymous users", () => {
+      environment.data.surveys = [
+        {
+          ...baseSurvey,
+          id: mockSurveyId1,
+          segment: undefined, // No segment at all
+        } as TSurvey,
+        {
+          ...baseSurvey,
+          id: mockSurveyId2,
+          segment: { id: mockSegmentId1 }, // Segment but no filters
+        } as TSurvey,
+      ];
+
+      const result = filterSurveys(environment, user);
+      expect(result).toHaveLength(2);
+    });
+
     test("skips surveys that already displayed if displayOnce is used", () => {
       environment.data.surveys = [
         {

packages/react-native/src/lib/common/utils.ts

@@ -111,7 +111,11 @@ export const filterSurveys = (
   });
 
   if (!userId) {
-    return filteredSurveys;
+    // exclude surveys that have a segment with filters
+    return filteredSurveys.filter((survey) => {
+      const segmentFiltersLength = survey.segment?.filters?.length ?? 0;
+      return segmentFiltersLength === 0;
+    });
   }
 
   if (!segments.length) {