feedback

Author: Dhruwang

packages/react-native/src/lib/common/utils.ts

@@ -183,8 +183,8 @@ export const getLanguageCode = (
 export const shouldDisplayBasedOnPercentage = (
   displayPercentage: number
 ): boolean => {
-  const randomNum = Math.floor(Math.random() * 10000) / 100; // NOSONAR
-  return randomNum <= displayPercentage;
+  // NOSONAR: Math.random() is sufficient for non-security survey display logic
+  return Math.random() * 100 < displayPercentage;
 };
 
 export const isNowExpired = (expirationDate: Date): boolean => {

packages/react-native/src/lib/survey/store.ts

@@ -20,7 +20,7 @@ export class SurveyStore {
     const prevSurvey = this.survey;
     if (prevSurvey?.id !== survey.id) {
       this.survey = survey;
-      for (const listener of this.listeners) {
+      for (const listener of [...this.listeners]) {
         listener(this.survey, prevSurvey);
       }
     }
@@ -30,7 +30,7 @@ export class SurveyStore {
     const prevSurvey = this.survey;
     if (prevSurvey !== null) {
       this.survey = null;
-      for (const listener of this.listeners) {
+      for (const listener of [...this.listeners]) {
         listener(this.survey, prevSurvey);
       }
     }