fix: shell pane detection and welcome screen logic

- Fix shell pane detection where untracked panes were not being added
  to the tracking list (untrackedPanes.push was not being called)
- Check for actual tmux panes at startup before showing welcome screen
- Destroy welcome pane when other panes exist (terminal or worktree)

Author: justin-schroeder

src/index.ts

@@ -20,6 +20,7 @@ import { createWelcomePane, destroyWelcomePane } from './utils/welcomePane.js';
 import { TMUX_COLORS } from './theme/colors.js';
 import { SIDEBAR_WIDTH } from './utils/layoutManager.js';
 import { validateSystemRequirements, printValidationResults } from './utils/systemCheck.js';
+import { getUntrackedPanes } from './utils/shellPaneDetection.js';
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const require = createRequire(import.meta.url);
@@ -247,7 +248,19 @@ class Dmux {
         }
       }
 
-      if (controlPaneId && config.panes && config.panes.length === 0) {
+      // Check for untracked panes (terminal panes created outside dmux tracking)
+      const trackedPaneIds = config.panes?.map((p: any) => p.paneId) ?? [];
+      const untrackedPanes = await getUntrackedPanes(
+        this.sessionName,
+        trackedPaneIds,
+        controlPaneId,
+        config.welcomePaneId
+      );
+
+      // Only show welcome pane if there are no tracked AND no untracked panes
+      const hasAnyPanes = (config.panes?.length ?? 0) > 0 || untrackedPanes.length > 0;
+
+      if (controlPaneId && !hasAnyPanes) {
         if (!hasValidWelcomePane) {
           // Create new welcome pane
           const welcomePaneId = await createWelcomePane(controlPaneId);
@@ -269,6 +282,13 @@ class Dmux {
           execSync(`tmux select-layout main-vertical`, { stdio: 'pipe' });
           await tmuxService.refreshClient();
         }
+      } else if (hasValidWelcomePane && hasAnyPanes) {
+        // If welcome pane exists but there are other panes, destroy it
+        LogService.getInstance().info('Destroying welcome pane because other panes exist', 'Setup');
+        await destroyWelcomePane(config.welcomePaneId);
+        config.welcomePaneId = undefined;
+        config.lastUpdated = new Date().toISOString();
+        await fs.writeFile(this.panesFile, JSON.stringify(config, null, 2));
       }
     } catch (error) {
       // Ignore errors in sidebar setup - will work without it

src/utils/shellPaneDetection.ts

@@ -119,47 +119,36 @@ export async function getUntrackedPanes(
 
       // CRITICAL: Skip internal dmux panes by title
       if (title === 'dmux-spacer') {
-  //   //         LogService.getInstance().debug(`Excluding spacer pane: ${paneId}`, 'shellDetection');
-  //         continue;
-  //       }
-  //       if (title && title.startsWith('dmux v')) {
-  //   //         LogService.getInstance().debug(`Excluding control pane by title: ${paneId} (${title})`, 'shellDetection');
+        continue;
+      }
+      if (title && title.startsWith('dmux v')) {
         continue;
       }
       if (title === 'Welcome') {
-  //   //         LogService.getInstance().debug(`Excluding welcome pane: ${paneId}`, 'shellDetection');
-  //         continue;
-  //       }
-  // 
-  //       // CRITICAL: Skip control and welcome panes by ID (most reliable method)
-  //       if (controlPaneId && paneId === controlPaneId) {
-  //   //         LogService.getInstance().debug(`Excluding control pane by ID: ${paneId}`, 'shellDetection');
+        continue;
+      }
+
+      // CRITICAL: Skip control and welcome panes by ID (most reliable method)
+      if (controlPaneId && paneId === controlPaneId) {
         continue;
       }
       if (welcomePaneId && paneId === welcomePaneId) {
-  //   //         LogService.getInstance().debug(`Excluding welcome pane by ID: ${paneId}`, 'shellDetection');
-  //         continue;
-  //       }
-  // 
-  //       // CRITICAL: Skip panes running dmux itself (node process running dmux)
-  //       if (command && (command === 'node' || command.includes('dmux'))) {
-  //   //         LogService.getInstance().debug(`Excluding dmux process pane: ${paneId} (command: ${command})`, 'shellDetection');
+        continue;
+      }
+
+      // CRITICAL: Skip panes running dmux itself (node process running dmux)
+      if (command && (command === 'node' || command.includes('dmux'))) {
         continue;
       }
 
       // Skip already tracked panes
       if (trackedPaneIds.includes(paneId)) continue;
 
-  //   //       LogService.getInstance().debug(`Found untracked pane: ${paneId} (title: ${title}, command: ${command})`, 'shellDetection');
-  //       untrackedPanes.push({ paneId, title: title || '', command: command || '' });
+      untrackedPanes.push({ paneId, title: title || '', command: command || '' });
     }
 
     return untrackedPanes;
   } catch (error) {
-  //     LogService.getInstance().debug(
-  //       'Failed to get untracked panes',
-  //       'shellDetection'
-  //     );
     return [];
   }
 }