Fixing bug introduced in #422

Kent C. Dodds · Kent C. Dodds · commit 2c144098a9eb · 2015-08-17T14:03:27.000-06:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+# 6.23.3
+
+## Bug Fixes
+
+- Logic bug introduced in the last version.
+
 # 6.23.2
 
 ## Bug Fixes
diff --git a/src/run/formlyNgModelAttrsManipulator.js b/src/run/formlyNgModelAttrsManipulator.js
@@ -145,8 +145,7 @@ function addFormlyNgModelAttrsManipulator(formlyConfig, $interpolate, formlyWarn
     for (let i = 0; i < allNgModelNodes.length; i++) {
       const ngModelNode = allNgModelNodes[i];
       if (!ngModelNode.hasAttribute('formly-skip-ng-model-attrs-manipulator') &&
-        (angular.isString(skip) || !nodeMatches(ngModelNode, skip))) {
-
+        !(angular.isString(skip) && nodeMatches(ngModelNode, skip))) {
         matchingNgModelNodes.push(ngModelNode);
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -145,8 +145,7 @@ function addFormlyNgModelAttrsManipulator(formlyConfig, $interpolate, formlyWarn`
`145`	`145`	`for (let i = 0; i < allNgModelNodes.length; i++) {`
`146`	`146`	`const ngModelNode = allNgModelNodes[i];`
`147`	`147`	`if (!ngModelNode.hasAttribute('formly-skip-ng-model-attrs-manipulator') &&`
`148`		`- (angular.isString(skip) \|\| !nodeMatches(ngModelNode, skip))) {`
`149`		`-`
	`148`	`+ !(angular.isString(skip) && nodeMatches(ngModelNode, skip))) {`
`150`	`149`	`matchingNgModelNodes.push(ngModelNode);`
`151`	`150`	`}`
`152`	`151`	`}`