v7.2.2

Author: formly-bot

dist/formly.js

@@ -1,5 +1,5 @@
 /*!
-* angular-formly JavaScript Library v7.2.1
+* angular-formly JavaScript Library v7.2.2
 *
 * @license MIT (http://license.angular-formly.com)
 *
@@ -153,7 +153,7 @@ return /******/ (function(modules) { // webpackBootstrap
 
 	ngModule.constant('formlyApiCheck', _providersFormlyApiCheck2['default']);
 	ngModule.constant('formlyErrorAndWarningsUrlPrefix', _otherDocsBaseUrl2['default']);
-	ngModule.constant('formlyVersion', ("7.2.1")); // <-- webpack variable
+	ngModule.constant('formlyVersion', ("7.2.2")); // <-- webpack variable
 
 	ngModule.provider('formlyUsability', _providersFormlyUsability2['default']);
 	ngModule.provider('formlyConfig', _providersFormlyConfig2['default']);
@@ -422,7 +422,7 @@ return /******/ (function(modules) { // webpackBootstrap
 	Object.defineProperty(exports, "__esModule", {
 	  value: true
 	});
-	exports["default"] = "https://github.com/formly-js/angular-formly/blob/" + ("7.2.1") + "/other/ERRORS_AND_WARNINGS.md#";
+	exports["default"] = "https://github.com/formly-js/angular-formly/blob/" + ("7.2.2") + "/other/ERRORS_AND_WARNINGS.md#";
 	module.exports = exports["default"];
 
 /***/ },
@@ -546,6 +546,7 @@ return /******/ (function(modules) { // webpackBootstrap
 	    disableWarnings: false,
 	    extras: {
 	      disableNgModelAttrsManipulator: false,
+	      fieldTransform: [],
 	      ngModelAttrsManipulatorPreferUnbound: false,
 	      removeChromeAutoComplete: false,
 	      defaultHideDirective: 'ng-if',

dist/formly.min.js

@@ -1,6 +1,6 @@
 {
   "name": "angular-formly",
-  "version": "7.2.1",
+  "version": "7.2.2",
   "author": "Astrism <[email protected]>",
   "contributors": [
     "Astrism <[email protected]>",
@@ -59,7 +59,7 @@
     "babel-loader": "5.3.2",
     "chai": "3.3.0",
     "codecov.io": "0.1.6",
-    "commitizen": "1.0.5",
+    "commitizen": "2.0.2",
     "cracks": "3.1.1",
     "cross-env": "1.0.1",
     "cz-conventional-changelog": "1.1.4",

dist/formly.min.js.map

@@ -1320,33 +1320,81 @@ describe('formly-field', function() {
     });
   });
 
-  describe(`with custom errorExistsAndShouldBeVisible expression`, () => {
-    beforeEach(() => {
-      scope.fields = [getNewField({validators: {foo: 'false'}})];
-    });
+  describe(`options.validation.errorExistsAndShouldBeVisible`, () => {
+    describe.skip(`multiple ng-model elements`, () => {
+      beforeEach(() => {
+        scope.fields = [
+          {
+            template: `
+              <input ng-model="model[options.data.firstKey]" />
+              <input ng-model="model[options.data.secondKey]" />
+            `,
+            // we'll just give it a validator that depends on a value we
+            // can change in our tests
+            validators: {foo: '!options.data.invalid'}
+          }
+        ];
+      });
 
-    it(`should set errorExistsAndShouldBeVisible to true when the expression function says so`, () => {
-      formlyConfig.extras.errorExistsAndShouldBeVisibleExpression = '!!options.data.customExpression';
-      compileAndDigest();
-      expect(field.validation.errorExistsAndShouldBeVisible).to.be.false;
-      field.data.customExpression = true;
-      scope.$digest();
-      expect(field.validation.errorExistsAndShouldBeVisible).to.be.true;
-    });
-
-    it(`should be able to work with form.$submitted`, () => {
-      formlyConfig.extras.errorExistsAndShouldBeVisibleExpression = 'form.$submitted';
-      compileAndDigest(`
-        <form name="theForm">
-          <formly-form form="theForm" model="model" fields="fields" options="options"></formly-form>
-        </form>
-      `);
-      expect(field.validation.errorExistsAndShouldBeVisible).to.be.false;
-      scope.theForm.$setSubmitted(true);
-      scope.$digest();
-      expect(field.validation.errorExistsAndShouldBeVisible).to.be.true;
+      it(`should set showError to true when one of them is invalid`, () => {
+        compileAndDigest();
+        expect(field.validation.errorExistsAndShouldBeVisible, 'initially false').to.be.false;
+        invalidateAndTouchFields();
+
+        expect(field.formControl[0].$error.foo, '$error on the first formControl').be.true;
+        expect(field.validation.errorExistsAndShouldBeVisible, 'now true').to.be.true;
+      });
+
+      it(`should work with a custom errorExistsAndShouldBeVisibleExpression`, () => {
+        const spy = sinon.spy();
+        formlyConfig.extras.errorExistsAndShouldBeVisibleExpression = spy;
+        compileAndDigest();
+
+        invalidateAndTouchFields();
+        expect(spy).to.have.been.calledWith(sinon.match.array, sinon.match.array);
+      });
+
+      function invalidateAndTouchFields() {
+        field.data.invalid = true;
+        // force $touched and revalidation of both form controls
+        field.formControl.forEach(fc => {
+          fc.$setTouched();
+          fc.$validate();
+        });
+
+        // redigest to set the showError prop
+        scope.$digest();
+      }
     });
 
+    describe(`with custom errorExistsAndShouldBeVisible expression`, () => {
+      beforeEach(() => {
+        scope.fields = [getNewField({validators: {foo: 'false'}})];
+      });
+
+      it(`should set errorExistsAndShouldBeVisible to true when the expression function says so`, () => {
+        formlyConfig.extras.errorExistsAndShouldBeVisibleExpression = '!!options.data.customExpression';
+        compileAndDigest();
+        expect(field.validation.errorExistsAndShouldBeVisible).to.be.false;
+        field.data.customExpression = true;
+        scope.$digest();
+        expect(field.validation.errorExistsAndShouldBeVisible).to.be.true;
+      });
+
+      it(`should be able to work with form.$submitted`, () => {
+        formlyConfig.extras.errorExistsAndShouldBeVisibleExpression = 'form.$submitted';
+        compileAndDigest(`
+          <form name="theForm">
+            <formly-form form="theForm" model="model" fields="fields" options="options"></formly-form>
+          </form>
+        `);
+        expect(field.validation.errorExistsAndShouldBeVisible).to.be.false;
+        scope.theForm.$setSubmitted(true);
+        scope.$digest();
+        expect(field.validation.errorExistsAndShouldBeVisible).to.be.true;
+      });
+
+    });
   });
 
   describe(`with specified "model" property`, () => {

package.json

@@ -9,6 +9,7 @@ import './directives/formly-custom-validation.test';
 import './directives/formly-field.test';
 import './directives/formly-focus.test';
 import './directives/formly-form.test';
+import './run/formlyCustomTags.test';
 import './run/formlyNgModelAttrsManipulator.test';
 import './other/utils.test';
 

src/directives/formly-field.test.js

@@ -24,6 +24,7 @@ function formlyConfig(formlyUsabilityProvider, formlyErrorAndWarningsUrlPrefix,
     disableWarnings: false,
     extras: {
       disableNgModelAttrsManipulator: false,
+      fieldTransform: [],
       ngModelAttrsManipulatorPreferUnbound: false,
       removeChromeAutoComplete: false,
       defaultHideDirective: 'ng-if',

src/index.test.js

@@ -0,0 +1,35 @@
+import angular from 'angular';
+
+describe(`formlyCustomTags`, () => {
+
+  beforeEach(window.module(`formly`, $provide => {
+    const docStub = {
+      get: sinon.stub().withArgs(0).returnsThis(),
+      createElement: sinon.stub().withArgs(`div`).returns({
+        getElementsByTagName: sinon.stub().withArgs(`i`).returns([1])
+      })
+    };
+
+    $provide.value(`$document`, docStub);
+  }));
+
+  let $document;
+
+  beforeEach(inject((_$document_) => {
+    $document = _$document_;
+  }));
+
+  describe(`addCustomTags`, () => {
+    it(`should create custom formly tags`, () => {
+      const customElements = [
+        `div`, `formly-field`, `formly-form`, `formly-custom-validation`, `formly-focus`, `formly-transpose`
+      ];
+
+      expect($document.get).to.have.been.calledOnce;
+
+      angular.forEach(customElements, el => {
+        expect($document.createElement).to.have.been.calledWith(el);
+      });
+    });
+  });
+});