chore(linting): Change to kentcdodds config conventions

Because I'm tired of copying over my conventions everywhere.

Author: Kent C. Dodds

.eslintrc

@@ -1,10 +1,7 @@
 {
-  "extends": "./node_modules/kcd-common-tools/shared/test.eslintrc",
-  "rules": {
-    "max-params": [2, 11] // gotta love me some angular...
-  },
-  "globals": {
-    "inject": false,
-    "VERSION": false
-  }
+  // this exists solely for editors. The test and app eslints are slightly different
+  // and the app validates the app code via the other/app.eslintrc and validates the
+  // test code via the other/test.eslintrc
+  // we simply use the test.eslintrc so our editors don't get mad at us.
+  "extends": "./other/test.eslintrc"
 }

other/common.eslintrc

@@ -0,0 +1,17 @@
+{
+  "rules": {
+    "func-names": 0, // I wish, but doing this right now would be a royal pain
+    "new-cap": [
+      2,
+      {
+        "newIsCap": true,
+        "capIsNew": true
+      }
+    ],
+    "max-params": [2, 10],
+    "max-statements": [2, 30], // TODO bring this down
+  },
+  "globals": {
+    "VERSION": false
+  }
+}

other/src.eslintrc

@@ -0,0 +1,3 @@
+{
+  "extends": ["kentcdodds", "./common.eslintrc"]
+}

other/test.eslintrc

@@ -0,0 +1,3 @@
+{
+  "extends": ["kentcdodds/test-angular", "./common.eslintrc"],
+}

package.json

@@ -85,18 +85,17 @@
     "angular": "1.4.3",
     "angular-mocks": "1.4.3",
     "api-check": "^7.3.0",
-    "babel": "5.8.9",
-    "babel-core": "5.8.9",
-    "babel-eslint": "4.0.5",
+    "babel": "5.8.23",
     "babel-loader": "5.3.2",
     "better-npm-run": "benoror/better-npm-run#0.0.1",
     "chai": "3.2.0",
     "codecov.io": "0.1.5",
     "commitizen": "1.0.4",
     "cz-conventional-changelog": "1.1.0",
-    "eslint": "0.24.1",
-    "eslint-loader": "0.14.2",
-    "eslint-plugin-mocha": "0.4.0",
+    "eslint": "1.3.1",
+    "eslint-config-kentcdodds": "3.0.0",
+    "eslint-loader": "1.0.0",
+    "eslint-plugin-mocha": "0.5.1",
     "ghooks": "0.3.2",
     "http-server": "0.8.0",
     "isparta": "3.0.3",

src/directives/formly-field.js

@@ -9,7 +9,7 @@ export default formlyField;
  * @restrict AE
  */
 // @ngInject
-function formlyField($http, $q, $compile, $templateCache, $interpolate, formlyConfig, formlyValidationMessages,
+function formlyField($http, $q, $compile, $templateCache, $interpolate, formlyConfig,
                      formlyApiCheck, formlyUtil, formlyUsability, formlyWarn) {
   const {arrayify} = formlyUtil;
 
@@ -34,7 +34,7 @@ function formlyField($http, $q, $compile, $templateCache, $interpolate, formlyCo
 
 
   // @ngInject
-  function FormlyFieldController($scope, $timeout, $parse, $controller) {
+  function FormlyFieldController($scope, $timeout, $parse, $controller, formlyValidationMessages) {
     /* eslint max-statements:[2, 31] */
     if ($scope.options.fieldGroup) {
       setupFieldGroup();
@@ -694,9 +694,9 @@ function formlyField($http, $q, $compile, $templateCache, $interpolate, formlyCo
       // TODO this is the deprecated API. Remove this in a breaking change.
       const checker = instance.shape(apiCheck);
       const checkOptions = apiCheckOptions || {
-          prefix: `formly-field type ${options.type}`,
-          url: formlyApiCheck.config.output.docsBaseUrl + 'formly-field-type-apicheck-failed'
-        };
+        prefix: `formly-field type ${options.type}`,
+        url: formlyApiCheck.config.output.docsBaseUrl + 'formly-field-type-apicheck-failed'
+      };
       instance[fn](checker, options, checkOptions);
     }
   }