Skip to content
This repository was archived by the owner on Apr 30, 2018. It is now read-only.

Commit a61de61

Browse files
author
Kent C. Dodds
committed
6.23.2
1 parent abce072 commit a61de61

File tree

5 files changed

+48
-9
lines changed

5 files changed

+48
-9
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
# 6.23.2
2+
3+
## Bug Fixes
4+
5+
- IE8 doesn't support the `:not` selector. Our resident IE8 support expert [@koenweyn](https://github.com/koenweyn) caught it and PRed a fix. Thanks! [#422](/../../pull/422)
6+
7+
18
# 6.23.1
29

310
## Bug Fixes

dist/formly.js

Lines changed: 36 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//! angular-formly version 6.23.1 built with ♥ by Astrism <[email protected]>, Kent C. Dodds <[email protected]> (ó ì_í)=óò=(ì_í ò)
1+
//! angular-formly version 6.23.2 built with ♥ by Astrism <[email protected]>, Kent C. Dodds <[email protected]> (ó ì_í)=óò=(ì_í ò)
22

33
(function webpackUniversalModuleDefinition(root, factory) {
44
if(typeof exports === 'object' && typeof module === 'object')
@@ -147,7 +147,7 @@ return /******/ (function(modules) { // webpackBootstrap
147147

148148
ngModule.constant('formlyApiCheck', _providersFormlyApiCheck2['default']);
149149
ngModule.constant('formlyErrorAndWarningsUrlPrefix', _otherDocsBaseUrl2['default']);
150-
ngModule.constant('formlyVersion', ("6.23.1")); // <-- webpack variable
150+
ngModule.constant('formlyVersion', ("6.23.2")); // <-- webpack variable
151151

152152
ngModule.provider('formlyUsability', _providersFormlyUsability2['default']);
153153
ngModule.provider('formlyConfig', _providersFormlyConfig2['default']);
@@ -449,7 +449,7 @@ return /******/ (function(modules) { // webpackBootstrap
449449
Object.defineProperty(exports, "__esModule", {
450450
value: true
451451
});
452-
exports["default"] = "https://github.com/formly-js/angular-formly/blob/" + ("6.23.1") + "/other/ERRORS_AND_WARNINGS.md#";
452+
exports["default"] = "https://github.com/formly-js/angular-formly/blob/" + ("6.23.2") + "/other/ERRORS_AND_WARNINGS.md#";
453453
module.exports = exports["default"];
454454

455455
/***/ },
@@ -2470,7 +2470,39 @@ return /******/ (function(modules) { // webpackBootstrap
24702470
var selectorNot = _angularFix2['default'].isString(skip) ? ':not(' + skip + ')' : '';
24712471
var skipNot = ':not([formly-skip-ng-model-attrs-manipulator])';
24722472
var query = '[ng-model]' + selectorNot + skipNot + ', [data-ng-model]' + selectorNot + skipNot;
2473-
return node.querySelectorAll(query);
2473+
try {
2474+
return node.querySelectorAll(query);
2475+
} catch (e) {
2476+
//this code is needed for IE8, as it does not support the CSS3 ':not' selector
2477+
//it should be removed when IE8 support is dropped
2478+
return getNgModelNodesFallback(node, skip);
2479+
}
2480+
}
2481+
2482+
function getNgModelNodesFallback(node, skip) {
2483+
var allNgModelNodes = node.querySelectorAll('[ng-model], [data-ng-model]');
2484+
var matchingNgModelNodes = [];
2485+
2486+
//make sure this array is compatible with NodeList type by adding an 'item' function
2487+
matchingNgModelNodes.item = function (i) {
2488+
return this[i];
2489+
};
2490+
2491+
for (var i = 0; i < allNgModelNodes.length; i++) {
2492+
var ngModelNode = allNgModelNodes[i];
2493+
if (!ngModelNode.hasAttribute('formly-skip-ng-model-attrs-manipulator') && (_angularFix2['default'].isString(skip) || !nodeMatches(ngModelNode, skip))) {
2494+
2495+
matchingNgModelNodes.push(ngModelNode);
2496+
}
2497+
}
2498+
2499+
return matchingNgModelNodes;
2500+
}
2501+
2502+
function nodeMatches(node, selector) {
2503+
var div = document.createElement('div');
2504+
div.innerHTML = node.outerHTML;
2505+
return div.querySelector(selector);
24742506
}
24752507

24762508
function getSkip(options) {

dist/formly.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/formly.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-formly",
3-
"version": "6.23.1",
3+
"version": "6.23.2",
44
"author": "Astrism <[email protected]>",
55
"contributors": [
66
"Astrism <[email protected]>",

0 commit comments

Comments
 (0)