fix(formly-field): Breaking change in @7.3.2? Key value? #566

Fixed this to handle GUIDS

Author: MCKRUZ

src/directives/formly-field.js

@@ -83,7 +83,7 @@ function formlyField($http, $q, $compile, $templateCache, $interpolate, formlyCo
     }
 
     function shouldNotUseParseKey(key) {
-      return angular.isNumber(key) || (/^\d/.test(key) && key.indexOf('[') === -1)
+      return angular.isNumber(key) || !formlyUtil.containsSelector(key)
     }
 
     function parseSet(key, model, newVal) {

src/directives/formly-field.test.js

@@ -572,6 +572,30 @@ describe('formly-field', function() {
       expect(scope.model[key]).to.eq(defaultValue)
     })
 
+    it('should work with dashes in the key', () => {
+      const key = 'address-1st-line'
+      const defaultValue = 'baz'
+      scope.fields = [
+        {template: input, key, defaultValue},
+      ]
+      scope.model = {}
+
+      compileAndDigest()
+      expect(scope.model[key]).to.eq(defaultValue)
+    })
+
+    it('should work with dashes and numerics in the key', () => {
+      const key = 'b141c66a-2857-4196-847b-b2096fa6170d'
+      const defaultValue = 'baz'
+      scope.fields = [
+        {template: input, key, defaultValue},
+      ]
+      scope.model = {}
+
+      compileAndDigest()
+      expect(scope.model[key]).to.eq(defaultValue)
+    })
+
     it('should work with nested keys with numbers in the key', () => {
       const key = 'foo3bar.baz4foobar'
       const defaultValue = 'baz'
@@ -581,7 +605,7 @@ describe('formly-field', function() {
       scope.model = {}
 
       compileAndDigest()
-      expect(scope.model.foo3bar.baz4foobar).to.equal(defaultValue)
+      expect(scope.model.foo3bar.baz4foobar).to.eq(defaultValue)
     })
   })
 

src/other/utils.js

@@ -1,9 +1,22 @@
 import angular from 'angular-fix'
 
 export default {
-  formlyEval, getFieldId, reverseDeepMerge, findByNodeName, arrayify, extendFunction, extendArray, startsWith, contains,
+  containsSelector, containsSpecialChar, formlyEval, getFieldId, reverseDeepMerge, findByNodeName,
+  arrayify, extendFunction, extendArray, startsWith, contains,
 }
 
+function containsSelector(string) {
+  return containsSpecialChar(string, '.') || (containsSpecialChar(string, '[') && containsSpecialChar(string, ']'))
+}
+
+function containsSpecialChar(a, b) {
+  if (!a || !a.indexOf) {
+    return false
+  }
+  return a.indexOf(b) !== -1
+}
+
+
 function formlyEval(scope, expression, $modelValue, $viewValue, extraLocals) {
   if (angular.isFunction(expression)) {
     return expression($viewValue, $modelValue, scope, extraLocals)