Fixing #421

Author: Kent C. Dodds

CHANGELOG.md

@@ -1,3 +1,9 @@
+# 6.23.1
+
+## Bug Fixes
+
+- api-check wasn't allowing `skipNgModelAttrsManipulator` under the `extras` property. [#421](/../../issues/421)
+
 # 6.23.0
 
 ## New Features

src/providers/formlyApiCheck.js

@@ -103,7 +103,10 @@ const fieldOptionsApiShape = {
   name: apiCheck.string.optional,
   expressionProperties: expressionProperties.optional,
   extras: apiCheck.shape({
-    validateOnModelChange: apiCheck.bool.optional
+    validateOnModelChange: apiCheck.bool.optional,
+    skipNgModelAttrsManipulator: apiCheck.oneOfType([
+      apiCheck.string, apiCheck.bool
+    ]).optional
   }).strict.optional,
   data: apiCheck.object.optional,
   templateOptions: apiCheck.object.optional,

src/providers/formlyApiCheck.test.js

@@ -42,9 +42,46 @@ describe('formlyApiCheck', () => {
     });
   });
 
+  describe(`extras`, () => {
+    describe(`skipNgModelAttrsManipulator`, () => {
+      it(`should pass with a boolean`, () => {
+        expectPass({
+          template: 'foo',
+          extras: {skipNgModelAttrsManipulator: true}
+        }, 'formlyFieldOptions');
+      });
+
+      it(`should pass with a string`, () => {
+        expectPass({
+          template: 'foo',
+          extras: {skipNgModelAttrsManipulator: '.selector'}
+        }, 'formlyFieldOptions');
+      });
+
+      it(`should pass with nothing`, () => {
+        expectPass({
+          template: 'foo',
+          extras: {skipNgModelAttrsManipulator: '.selector'}
+        }, 'formlyFieldOptions');
+      });
+
+      it(`should fail with anything else`, () => {
+        expectFail({
+          template: 'foo',
+          extras: {skipNgModelAttrsManipulator: 32}
+        }, 'formlyFieldOptions');
+      });
+    });
+  });
+
   function expectPass(options, checker) {
     const result = formlyApiCheck[checker](options);
     expect(result).to.be.undefined;
   }
 
+  function expectFail(options, checker) {
+    const result = formlyApiCheck[checker](options);
+    expect(result).to.be.an.instanceOf(Error);
+  }
+
 });