Merge pull request #541 from BarryThePenguin/master

refactor(formly-run): use documentMode for IE detection

Author: Kent C. Dodds

src/run/formlyCustomTags.js

@@ -3,22 +3,16 @@ export default addCustomTags
 
 // @ngInject
 function addCustomTags($document) {
-  if ($document && $document.get) {
-    // IE8 check ->
-    // http://stackoverflow.com/questions/10964966/detect-ie-version-prior-to-v9-in-javascript/10965203#10965203
+  // IE8 check ->
+  // https://msdn.microsoft.com/en-us/library/cc196988(v=vs.85).aspx
+  if ($document && $document.documentMode < 9) {
     const document = $document.get(0)
-    const div = document.createElement('div')
-    div.innerHTML = '<!--[if lt IE 9]><i></i><![endif]-->'
-    const isIeLessThan9 = (div.getElementsByTagName('i').length === 1)
-
-    if (isIeLessThan9) {
-      // add the custom elements that we need for formly
-      const customElements = [
-        'formly-field', 'formly-form', 'formly-custom-validation', 'formly-focus', 'formly-transpose',
-      ]
-      angular.forEach(customElements, el => {
-        document.createElement(el)
-      })
-    }
+    // add the custom elements that we need for formly
+    const customElements = [
+      'formly-field', 'formly-form',
+    ]
+    angular.forEach(customElements, el => {
+      document.createElement(el)
+    })
   }
 }

src/run/formlyCustomTags.test.js

@@ -3,14 +3,11 @@ import angular from 'angular'
 describe(`formlyCustomTags`, () => {
 
   beforeEach(window.module(`formly`, $provide => {
-    const docStub = {
+    $provide.value(`$document`, {
+      documentMode: 8,
       get: sinon.stub().withArgs(0).returnsThis(),
-      createElement: sinon.stub().withArgs(`div`).returns({
-        getElementsByTagName: sinon.stub().withArgs(`i`).returns([1]),
-      }),
-    }
-
-    $provide.value(`$document`, docStub)
+      createElement: sinon.spy(),
+    })
   }))
 
   let $document
@@ -22,7 +19,7 @@ describe(`formlyCustomTags`, () => {
   describe(`addCustomTags`, () => {
     it(`should create custom formly tags`, () => {
       const customElements = [
-        `div`, `formly-field`, `formly-form`, `formly-custom-validation`, `formly-focus`, `formly-transpose`,
+        `formly-field`, `formly-form`,
       ]
 
       expect($document.get).to.have.been.calledOnce