v7.3.6

Author: formly-bot

dist/formly.js

@@ -1,5 +1,5 @@
 /*!
-* angular-formly JavaScript Library v7.3.5
+* angular-formly JavaScript Library v7.3.6
 *
 * @license MIT (http://license.angular-formly.com)
 *
@@ -153,7 +153,7 @@ return /******/ (function(modules) { // webpackBootstrap
 
 	ngModule.constant('formlyApiCheck', _providersFormlyApiCheck2['default']);
 	ngModule.constant('formlyErrorAndWarningsUrlPrefix', _otherDocsBaseUrl2['default']);
-	ngModule.constant('formlyVersion', ("7.3.5")); // <-- webpack variable
+	ngModule.constant('formlyVersion', ("7.3.6")); // <-- webpack variable
 
 	ngModule.provider('formlyUsability', _providersFormlyUsability2['default']);
 	ngModule.provider('formlyConfig', _providersFormlyConfig2['default']);
@@ -424,7 +424,7 @@ return /******/ (function(modules) { // webpackBootstrap
 	Object.defineProperty(exports, "__esModule", {
 	  value: true
 	});
-	exports["default"] = "https://github.com/formly-js/angular-formly/blob/" + ("7.3.5") + "/other/ERRORS_AND_WARNINGS.md#";
+	exports["default"] = "https://github.com/formly-js/angular-formly/blob/" + ("7.3.6") + "/other/ERRORS_AND_WARNINGS.md#";
 	module.exports = exports["default"];
 
 /***/ },
@@ -1220,7 +1220,7 @@ return /******/ (function(modules) { // webpackBootstrap
 
 	  // @ngInject
 	  function FormlyFieldController($scope, $timeout, $parse, $controller, formlyValidationMessages) {
-	    /* eslint max-statements:[2, 31] */
+	    /* eslint max-statements:[2, 32] */
 	    if ($scope.options.fieldGroup) {
 	      setupFieldGroup();
 	      return;
@@ -1267,13 +1267,17 @@ return /******/ (function(modules) { // webpackBootstrap
 	      return parseGet($scope.options.key, $scope.model);
 	    }
 
+	    function shouldNotUseParseKey(key) {
+	      return _angularFix2['default'].isNumber(key) || /^\d/.test(key) && key.indexOf('[') === -1;
+	    }
+
 	    function parseSet(key, model, newVal) {
 	      // If either of these are null/undefined then just return undefined
 	      if (!key || !model) {
 	        return;
 	      }
 	      // If we are working with a number then $parse wont work, default back to the old way for now
-	      if (_angularFix2['default'].isNumber(key)) {
+	      if (shouldNotUseParseKey(key)) {
 	        // TODO: Fix this so we can get several levels instead of just one with properties that are numeric
 	        model[key] = newVal;
 	      } else {
@@ -1291,7 +1295,7 @@ return /******/ (function(modules) { // webpackBootstrap
 	      }
 
 	      // If we are working with a number then $parse wont work, default back to the old way for now
-	      if (_angularFix2['default'].isNumber(key)) {
+	      if (shouldNotUseParseKey(key)) {
 	        // TODO: Fix this so we can get several levels instead of just one with properties that are numeric
 	        return model[key];
 	      } else {

dist/formly.min.js

@@ -1,6 +1,6 @@
 {
   "name": "angular-formly",
-  "version": "7.3.5",
+  "version": "7.3.6",
   "author": "Astrism <[email protected]>",
   "contributors": [
     "Astrism <[email protected]>",

dist/formly.min.js.map

@@ -35,7 +35,7 @@ function formlyField($http, $q, $compile, $templateCache, $interpolate, formlyCo
 
   // @ngInject
   function FormlyFieldController($scope, $timeout, $parse, $controller, formlyValidationMessages) {
-    /* eslint max-statements:[2, 31] */
+    /* eslint max-statements:[2, 32] */
     if ($scope.options.fieldGroup) {
       setupFieldGroup()
       return
@@ -82,13 +82,17 @@ function formlyField($http, $q, $compile, $templateCache, $interpolate, formlyCo
       return parseGet($scope.options.key, $scope.model)
     }
 
+    function shouldNotUseParseKey(key) {
+      return angular.isNumber(key) || (/^\d/.test(key) && key.indexOf('[') === -1)
+    }
+
     function parseSet(key, model, newVal) {
       // If either of these are null/undefined then just return undefined
       if (!key || !model) {
         return
       }
       // If we are working with a number then $parse wont work, default back to the old way for now
-      if (angular.isNumber(key)) {
+      if (shouldNotUseParseKey(key)) {
         // TODO: Fix this so we can get several levels instead of just one with properties that are numeric
         model[key] = newVal
       } else {
@@ -106,7 +110,7 @@ function formlyField($http, $q, $compile, $templateCache, $interpolate, formlyCo
       }
 
       // If we are working with a number then $parse wont work, default back to the old way for now
-      if (angular.isNumber(key)) {
+      if (shouldNotUseParseKey(key)) {
         // TODO: Fix this so we can get several levels instead of just one with properties that are numeric
         return model[key]
       } else {

package.json

@@ -519,6 +519,72 @@ describe('formly-field', function() {
     })
   })
 
+  describe('getterSetters', () => {
+    it('should get and set values when key is all alpha', () => {
+      const key = 'foo'
+      const defaultValue = 'bar'
+
+      scope.fields = [
+        {template: input, key, defaultValue},
+      ]
+      scope.model = {}
+
+      compileAndDigest()
+      expect(scope.model[key]).to.eq(defaultValue)
+    })
+
+    it('should get and set values when key is all numeric', () => {
+      const key = '1333'
+      const defaultValue = 'bar'
+
+      scope.fields = [
+        {template: input, key, defaultValue},
+      ]
+      scope.model = {}
+
+      compileAndDigest()
+      expect(scope.model[key]).to.eq(defaultValue)
+    })
+
+    it('should get and set values when key is alpha numeric with alpha first', () => {
+      const key = 'A1'
+      const defaultValue = 'bar'
+
+      scope.fields = [
+        {template: input, key, defaultValue},
+      ]
+      scope.model = {}
+
+      compileAndDigest()
+      expect(scope.model[key]).to.eq(defaultValue)
+    })
+
+    it('should get and set values when key is alpha numeric with numeric first', () => {
+      const key = '1A'
+      const defaultValue = 'bar'
+
+      scope.fields = [
+        {template: input, key, defaultValue},
+      ]
+      scope.model = {}
+
+      compileAndDigest()
+      expect(scope.model[key]).to.eq(defaultValue)
+    })
+
+    it('should work with nested keys with numbers in the key', () => {
+      const key = 'foo3bar.baz4foobar'
+      const defaultValue = 'baz'
+      scope.fields = [
+        {template: input, key, defaultValue},
+      ]
+      scope.model = {}
+
+      compileAndDigest()
+      expect(scope.model.foo3bar.baz4foobar).to.equal(defaultValue)
+    })
+  })
+
   describe(`id property`, () => {
     it(`should default to a semi-random id that you cannot rely on and don't have to think about`, () => {
       scope.fields = [getNewField()]