Skip to content
This repository was archived by the owner on Apr 30, 2018. It is now read-only.

Commit fb235c7

Browse files
committed
v7.3.4
2 parents 21258da + c50f013 commit fb235c7

File tree

6 files changed

+29
-22
lines changed

6 files changed

+29
-22
lines changed

CONTRIBUTING.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,14 @@ with a link to a jsbin that demonstrates the issue with [issue.angular-formly.co
2929

3030
## Pull Requests
3131

32-
[Watch video](https://www.youtube.com/watch?v=QOchwBm9W-g&list=PLV5CVI1eNcJi7lVVIuNyRhEuck1Z007BH&index=1)
32+
‼️‼️‼️ 👉**Please follow our commit message conventions** even if you're making a small change! This repository follows the
33+
[How to Write an Open Source JavaScript Library](https://egghead.io/series/how-to-write-an-open-source-javascript-library)
34+
series on egghead.io (by yours truly). See
35+
[this lesson](https://egghead.io/lessons/javascript-how-to-write-a-javascript-library-writing-conventional-commits-with-commitizen?series=how-to-write-an-open-source-javascript-library)
36+
and [this repo](https://github.com/ajoslin/conventional-changelog/blob/master/conventions/angular.md)
37+
to learn more about the commit message conventions.
38+
39+
[Watch video](https://www.youtube.com/watch?v=QOchwBm9W-g&list=PLV5CVI1eNcJi7lVVIuNyRhEuck1Z007BH&index=1) (slightly out of date)
3340

3441
If you would like to add functionality, please submit [an issue](https://github.com/formly-js/angular-formly/issues)
3542
first to make sure it's a direction we want to take.

dist/formly.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* angular-formly JavaScript Library v7.3.3
2+
* angular-formly JavaScript Library v7.3.4
33
*
44
* @license MIT (http://license.angular-formly.com)
55
*
@@ -153,7 +153,7 @@ return /******/ (function(modules) { // webpackBootstrap
153153

154154
ngModule.constant('formlyApiCheck', _providersFormlyApiCheck2['default']);
155155
ngModule.constant('formlyErrorAndWarningsUrlPrefix', _otherDocsBaseUrl2['default']);
156-
ngModule.constant('formlyVersion', ("7.3.3")); // <-- webpack variable
156+
ngModule.constant('formlyVersion', ("7.3.4")); // <-- webpack variable
157157

158158
ngModule.provider('formlyUsability', _providersFormlyUsability2['default']);
159159
ngModule.provider('formlyConfig', _providersFormlyConfig2['default']);
@@ -424,7 +424,7 @@ return /******/ (function(modules) { // webpackBootstrap
424424
Object.defineProperty(exports, "__esModule", {
425425
value: true
426426
});
427-
exports["default"] = "https://github.com/formly-js/angular-formly/blob/" + ("7.3.3") + "/other/ERRORS_AND_WARNINGS.md#";
427+
exports["default"] = "https://github.com/formly-js/angular-formly/blob/" + ("7.3.4") + "/other/ERRORS_AND_WARNINGS.md#";
428428
module.exports = exports["default"];
429429

430430
/***/ },
@@ -973,12 +973,12 @@ return /******/ (function(modules) { // webpackBootstrap
973973
/* 10 */
974974
/***/ function(module, exports) {
975975

976-
"use strict";
976+
'use strict';
977977

978-
Object.defineProperty(exports, "__esModule", {
978+
Object.defineProperty(exports, '__esModule', {
979979
value: true
980980
});
981-
exports["default"] = formlyValidationMessages;
981+
exports['default'] = formlyValidationMessages;
982982

983983
// @ngInject
984984
function formlyValidationMessages() {
@@ -1003,15 +1003,15 @@ return /******/ (function(modules) { // webpackBootstrap
10031003

10041004
function templateOptionValue(prop, prefix, suffix, alternate) {
10051005
return function getValidationMessage(viewValue, modelValue, scope) {
1006-
if (scope.options.templateOptions[prop]) {
1007-
return prefix + " " + scope.options.templateOptions[prop] + " " + suffix;
1006+
if (typeof scope.options.templateOptions[prop] !== 'undefined') {
1007+
return prefix + ' ' + scope.options.templateOptions[prop] + ' ' + suffix;
10081008
} else {
10091009
return alternate;
10101010
}
10111011
};
10121012
}
10131013
}
1014-
module.exports = exports["default"];
1014+
module.exports = exports['default'];
10151015

10161016
/***/ },
10171017
/* 11 */

dist/formly.min.js

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/formly.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-formly",
3-
"version": "7.3.3",
3+
"version": "7.3.4",
44
"author": "Astrism <[email protected]>",
55
"contributors": [
66
"Astrism <[email protected]>",

src/providers/formlyValidationMessages.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function formlyValidationMessages() {
2323

2424
function templateOptionValue(prop, prefix, suffix, alternate) {
2525
return function getValidationMessage(viewValue, modelValue, scope) {
26-
if (scope.options.templateOptions[prop]) {
26+
if (typeof scope.options.templateOptions[prop] !== 'undefined') {
2727
return `${prefix} ${scope.options.templateOptions[prop]} ${suffix}`
2828
} else {
2929
return alternate

0 commit comments

Comments
 (0)