DB: always connect with PGSQL_CONNECT_FORCE_NEW flag [ToDo Docs why]

Author: forrest79

docs/db.md

@@ -18,12 +18,11 @@ Pass `TRUE` as the second parameter to force new connection (otherwise, existing
 
 > Personal note: I'm thinking about removing this in the next big release.
 
-You can create a blank `Connection` object and set connection parameters on this object with functions `setConnectionConfig()` and `setConnectForceNew()`. You must set it before `connect()` is executed.
+You can create a blank `Connection` object and set connection parameters on this object with function `setConnectionConfig()` later. You must set it before `connect()` is executed.
 
 ```php
 $connection = new Forrest79\PhPgSql\Db\Connection();
 $connection->setConnectionConfig('host=localhost port=5432 dbname=test user=user1 password=xyz111 connect_timeout=5');
-$connection->setConnectForceNew(TRUE);
 ```
 
 Once you have a connection, you can manually connect it:

src/Db/Connection.php

@@ -8,8 +8,6 @@ class Connection
 {
 	private string $connectionConfig;
 
-	private bool $connectForceNew;
-
 	private int $errorVerbosity;
 
 	private AsyncHelper $asyncHelper;
@@ -28,10 +26,9 @@ class Connection
 	/**
 	 * @throws Exceptions\ConnectionException
 	 */
-	public function __construct(string $connectionConfig = '', bool $connectForceNew = FALSE)
+	public function __construct(string $connectionConfig = '')
 	{
 		$this->connectionConfig = $connectionConfig;
-		$this->connectForceNew = $connectForceNew;
 
 		$this->errorVerbosity = \PGSQL_ERRORS_DEFAULT;
 
@@ -50,12 +47,7 @@ public function connect(): static
 			throw Exceptions\ConnectionException::noConfig();
 		}
 
-		$connectType = 0;
-		if ($this->connectForceNew === TRUE) {
-			$connectType |= \PGSQL_CONNECT_FORCE_NEW;
-		}
-
-		$resource = @\pg_connect($this->connectionConfig, $connectType); // intentionally @
+		$resource = @\pg_connect($this->connectionConfig, \PGSQL_CONNECT_FORCE_NEW); // intentionally @
 		if ($resource === FALSE) {
 			throw Exceptions\ConnectionException::connectionFailed();
 		} elseif (\pg_connection_status($resource) === \PGSQL_CONNECTION_BAD) {
@@ -97,7 +89,7 @@ public function ping(): bool
 	public function setConnectionConfig(string $config): static
 	{
 		if ($this->isConnected()) {
-			throw Exceptions\ConnectionException::cantChangeWhenConnected('config');
+			throw Exceptions\ConnectionException::cantChangeConnectionConfigWhenConnected();
 		}
 
 		$this->connectionConfig = $config;
@@ -112,18 +104,6 @@ public function getConnectionConfig(): string
 	}
 
 
-	public function setConnectForceNew(bool $forceNew = TRUE): static
-	{
-		if ($this->isConnected()) {
-			throw Exceptions\ConnectionException::cantChangeWhenConnected('forceNew');
-		}
-
-		$this->connectForceNew = $forceNew;
-
-		return $this;
-	}
-
-
 	public function setErrorVerbosity(int $errorVerbosity): static
 	{
 		if ($this->errorVerbosity !== $errorVerbosity) {

src/Db/Exceptions/ConnectionException.php

@@ -5,7 +5,7 @@
 class ConnectionException extends Exception
 {
 	public const NO_CONFIG = 1;
-	public const CANT_CHANGE_WHEN_CONNECTED = 2;
+	public const CANT_CHANGE_CONNECTION_CONFIG_WHEN_CONNECTED = 2;
 	public const CONNECTION_FAILED = 3;
 	public const BAD_CONNECTION = 4;
 	public const CANT_GET_NOTICES = 5;
@@ -22,9 +22,9 @@ public static function noConfig(): self
 	}
 
 
-	public static function cantChangeWhenConnected(string $type): self
+	public static function cantChangeConnectionConfigWhenConnected(): self
 	{
-		return new self(\sprintf('You can\'t change \'%s\' when connected.', $type), self::CANT_CHANGE_WHEN_CONNECTED);
+		return new self('You can\'t change \'connectionConfig\' when connected.', self::CANT_CHANGE_CONNECTION_CONFIG_WHEN_CONNECTED);
 	}
 
 

tests/Integration/AsyncTest.php

@@ -207,7 +207,7 @@ public function testError(): void
 
 	protected function createConnection(): Db\Connection
 	{
-		return new Db\Connection($this->getTestConnectionConfig(), FALSE);
+		return new Db\Connection($this->getTestConnectionConfig());
 	}
 
 }

tests/Integration/BasicTest.php

@@ -88,13 +88,6 @@ public function testConnectionNoConfig(): void
 	}
 
 
-	public function testConnectionForceNew(): void
-	{
-		$this->connection->setConnectForceNew(TRUE);
-		Tester\Assert::true($this->connection->ping());
-	}
-
-
 	public function testFailedConnection(): void
 	{
 		$this->connection->setConnectionConfig(\str_replace('user=', 'user=non-existing-user-', $this->getConfig()));
@@ -111,16 +104,11 @@ public function testChangeConnectionSettingsAfterConnected(): void
 
 		Tester\Assert::exception(function (): void {
 			$this->connection->setConnectionConfig('');
-		}, Db\Exceptions\ConnectionException::class, NULL, Db\Exceptions\ConnectionException::CANT_CHANGE_WHEN_CONNECTED);
-
-		Tester\Assert::exception(function (): void {
-			$this->connection->setConnectForceNew();
-		}, Db\Exceptions\ConnectionException::class, NULL, Db\Exceptions\ConnectionException::CANT_CHANGE_WHEN_CONNECTED);
+		}, Db\Exceptions\ConnectionException::class, NULL, Db\Exceptions\ConnectionException::CANT_CHANGE_CONNECTION_CONFIG_WHEN_CONNECTED);
 
 		$this->connection->close();
 
 		$this->connection->setConnectionConfig('');
-		$this->connection->setConnectForceNew();
 	}
 
 

tests/Integration/TestCase.php

@@ -35,6 +35,7 @@ protected function tearDown(): void
 	{
 		$this->connection->close();
 		$this->adminConnection->query('DROP DATABASE ?', Db\Sql\Literal::create($this->dbname));
+		$this->adminConnection->close();
 	}