Addresses mutable default argument warnings

Author: gnikit

CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELONG
 
+## 2.0.1
+
+### Fixed
+
+- Fixed some mutable default argument warnings in methods and classes
+
 ## 2.0.0
 
 ### Added

fortls/langserver.py

@@ -382,8 +382,10 @@ def get_candidates(
         ):
             #
             def child_candidates(
-                scope, only_list=[], filter_public=True, req_abstract=False
+                scope, only_list: list = None, filter_public=True, req_abstract=False
             ):
+                if only_list is None:
+                    only_list = []
                 tmp_list = []
                 # Filter children
                 nonly = len(only_list)

fortls/objects.py

@@ -79,9 +79,9 @@ def get_use_tree(
     scope: fortran_scope,
     use_dict: dict,
     obj_tree: dict,
-    only_list: list = [],
-    rename_map: dict = {},
-    curr_path: list = [],
+    only_list: list = None,
+    rename_map: dict = None,
+    curr_path: list = None,
 ):
     def intersect_only(use_stmnt):
         tmp_list = []
@@ -97,6 +97,13 @@ def intersect_only(use_stmnt):
                 tmp_map.pop(val1, None)
         return tmp_list, tmp_map
 
+    if only_list is None:
+        only_list = []
+    if rename_map is None:
+        rename_map = {}
+    if curr_path is None:
+        curr_path = []
+
     # Detect and break circular references
     if scope.FQSN in curr_path:
         return use_dict
@@ -297,15 +304,17 @@ def __init__(
         self,
         mod_name: str,
         line_number: int,
-        only_list: list = [],
-        rename_map: dict = {},
+        only_list: list = None,
+        rename_map: dict = None,
     ):
         self.mod_name: str = mod_name.lower()
         self.line_number: int = line_number
-        self.only_list: list = [only.lower() for only in only_list]
-        self.rename_map: dict = {
-            key.lower(): value.lower() for key, value in rename_map.items()
-        }
+        if only_list is not None:
+            self.only_list: list = [only.lower() for only in only_list]
+        if rename_map is not None:
+            self.rename_map: dict = {
+                key.lower(): value.lower() for key, value in rename_map.items()
+            }
 
 
 class fortran_diagnostic:
@@ -466,15 +475,19 @@ def req_named_end(self):
     def check_valid_parent(self):
         return True
 
-    def check_definition(self, obj_tree, known_types={}, interface=False):
+    def check_definition(self, obj_tree, known_types: dict = None, interface=False):
+        if known_types is None:
+            known_types = {}
         return None, known_types
 
 
 class fortran_scope(fortran_obj):
     def __init__(self, file_ast, line_number: int, name: str):
         self.base_setup(file_ast, line_number, name)
 
-    def base_setup(self, file_ast, sline: int, name: str, keywords: list = []):
+    def base_setup(self, file_ast, sline: int, name: str, keywords: list = None):
+        if keywords is None:
+            keywords = []
         self.file_ast: fortran_ast = file_ast
         self.sline: int = sline
         self.eline: int = sline
@@ -514,7 +527,13 @@ def copy_from(self, copy_source):
         self.implicit_vars = copy_source.implicit_vars
         self.implicit_line = copy_source.implicit_line
 
-    def add_use(self, use_mod, line_number, only_list=[], rename_map={}):
+    def add_use(
+        self, use_mod, line_number, only_list: list = None, rename_map: dict = None
+    ):
+        if only_list is None:
+            only_list = []
+        if rename_map is None:
+            rename_map = {}
         self.use.append(USE_line(use_mod, line_number, only_list, rename_map))
 
     def set_inherit(self, inherit_type):
@@ -841,8 +860,10 @@ def __init__(
         name: str,
         args: str = "",
         mod_flag: bool = False,
-        keywords: list = [],
+        keywords: list = None,
     ):
+        if keywords is None:
+            keywords = []
         self.base_setup(file_ast, line_number, name, keywords=keywords)
         self.args: str = args.replace(" ", "")
         self.args_snip: str = self.args
@@ -1055,10 +1076,12 @@ def __init__(
         name: str,
         args: str = "",
         mod_flag: bool = False,
-        keywords: list = [],
+        keywords: list = None,
         return_type=None,
         result_var=None,
     ):
+        if keywords is None:
+            keywords = []
         self.base_setup(file_ast, line_number, name, keywords=keywords)
         self.args: str = args.replace(" ", "").lower()
         self.args_snip: str = self.args
@@ -1495,7 +1518,7 @@ class fortran_int(fortran_scope):
     def __init__(
         self,
         file_ast: fortran_ast,
-        line_number: list,
+        line_number: int,
         name: str,
         abstract: bool = False,
     ):
@@ -1540,9 +1563,11 @@ def __init__(
         name: str,
         var_desc: str,
         keywords: list,
-        keyword_info: dict = {},
+        keyword_info: dict = None,
         link_obj=None,
     ):
+        if keyword_info is None:
+            keyword_info = {}
         self.base_setup(
             file_ast, line_number, name, var_desc, keywords, keyword_info, link_obj
         )
@@ -1920,7 +1945,7 @@ def get_enc_scope_name(self):
     def add_scope(
         self,
         new_scope: fortran_scope,
-        END_SCOPE_REGEX,
+        END_SCOPE_REGEX: Pattern[str],
         exportable: bool = True,
         req_container: bool = False,
     ):

fortls/parse_fortran.py

@@ -1101,8 +1101,13 @@ def find_word_in_code_line(
         return line_number, i0, i1
 
     def preprocess(
-        self, pp_defs: dict = {}, include_dirs: list = [], debug: bool = False
+        self, pp_defs: dict = None, include_dirs: list = None, debug: bool = False
     ) -> tuple[list, list]:
+        if pp_defs is None:
+            pp_defs = {}
+        if include_dirs is None:
+            include_dirs = []
+
         self.contents_pp, pp_skips, pp_defines, self.pp_defs = preprocess_file(
             self.contents_split,
             self.path,
@@ -1167,15 +1172,15 @@ def check_file(self, obj_tree, max_line_length=-1, max_comment_line_length=-1):
 def preprocess_file(
     contents_split: list,
     file_path: str = None,
-    pp_defs: dict = {},
-    include_dirs: list = [],
+    pp_defs: dict = None,
+    include_dirs: list = None,
     debug: bool = False,
 ):
     # Look for and mark excluded preprocessor paths in file
     # Initial implementation only looks for "if" and "ifndef" statements.
     # For "if" statements all blocks are excluded except the "else" block if present
     # For "ifndef" statements all blocks excluding the first block are excluded
-    def eval_pp_if(text, defs: dict = {}):
+    def eval_pp_if(text, defs: dict = None):
         def replace_ops(expr: str):
             expr = expr.replace("&&", " and ")
             expr = expr.replace("||", " or ")
@@ -1212,6 +1217,8 @@ def replace_vars(line: str):
             out_line = out_line.replace("$%", "False")
             return out_line
 
+        if defs is None:
+            defs = {}
         out_line = replace_defined(text)
         out_line = replace_vars(out_line)
         try:
@@ -1221,7 +1228,10 @@ def replace_vars(line: str):
         else:
             return line_res
 
-    #
+    if pp_defs is None:
+        pp_defs = {}
+    if include_dirs is None:
+        include_dirs = []
     if file_path is not None:
         include_dirs = [os.path.dirname(file_path)] + include_dirs
     pp_skips = []
@@ -1386,14 +1396,18 @@ def replace_vars(line: str):
 def process_file(
     file_obj: fortran_file,
     debug: bool = False,
-    pp_defs: dict = {},
-    include_dirs: list = [],
+    pp_defs: dict = None,
+    include_dirs: list = None,
 ):
     """Build file AST by parsing file"""
 
     def parser_debug_msg(msg: str, line: str, ln: int):
         log.debug(f"{line.strip()} !!! {msg} statement({ln})")
 
+    if pp_defs is None:
+        pp_defs = {}
+    if include_dirs is None:
+        include_dirs = []
     # Configure the parser logger
     if debug:
         logging.basicConfig(