Fixed Literal hover signature shows incorrect length of string #55

Added unittests for both #54 and #55

Author: gnikit

CHANGELOG.md

@@ -6,6 +6,8 @@
 
 - Fixed hovering value of literal and constant strings not displaying
   ([#54](https://github.com/gnikit/fortls/issues/54))
+- Fixed hovering string length size is now matching the string
+  ([#55](https://github.com/gnikit/fortls/issues/55))
 
 ## 2.2.3
 

fortls/langserver.py

@@ -1055,7 +1055,7 @@ def create_signature_hover():
             elif var_obj.desc.endswith("LOGICAL"):
                 hover_array.append(create_hover("LOGICAL", True))
             elif var_obj.desc.endswith("STRING"):
-                hover_str = f"CHARACTER(LEN={len(var_obj.name)})"
+                hover_str = f"CHARACTER(LEN={len(var_obj.name)-2})"
                 hover_array.append(create_hover(hover_str, True))
 
             # Include the signature if one is present e.g. if in an argument list

test/test_server.py

@@ -575,6 +575,12 @@ def check_return(result_array, checks):
     string += hover_req(file_path, 6, 28)
     string += hover_req(file_path, 7, 38)
     string += hover_req(file_path, 7, 55)
+    string += hover_req(file_path, 8, 37)
+    string += hover_req(file_path, 8, 50)
+    string += hover_req(file_path, 9, 37)
+    string += hover_req(file_path, 9, 48)
+    string += hover_req(file_path, 10, 37)
+    string += hover_req(file_path, 10, 48)
     file_path = test_dir / "hover" / "pointers.f90"
     string += hover_req(file_path, 1, 26)
     file_path = test_dir / "hover" / "functions.f90"

test/test_source/hover/parameters.f90

@@ -6,4 +6,7 @@ program params
                           var*var2, &
                           var4 = 123
     double precision, parameter :: somevar = 23.12, some = 1e-19
+    logical(kind=8), parameter :: long_bool = .true.
+    character(len=5), parameter :: sq_str = '12345'
+    character(len=5), parameter :: dq_str = "12345"
 end program params