Add tests for checking and reading package data

Author: minhqdao

src/fpm/dependency.f90

@@ -73,7 +73,8 @@ module fpm_dependency
   implicit none
   private
 
-  public :: dependency_tree_t, new_dependency_tree, dependency_node_t, new_dependency_node, resize
+  public :: dependency_tree_t, new_dependency_tree, dependency_node_t, new_dependency_node, resize, &
+            & check_and_read_pkg_data
 
   !> Overloaded reallocation interface
   interface resize
@@ -551,7 +552,7 @@ subroutine get_from_registry(self, target_dir, global_settings, error, downloade
     close (unit, status='delete')
     if (allocated(error)) return
 
-    ! Verify package data read relevant information.
+    ! Verify package data and read relevant information.
     call check_and_read_pkg_data(json, self, target_url, version, error)
     if (allocated(error)) return
 
@@ -624,7 +625,7 @@ subroutine check_and_read_pkg_data(json, node, download_url, version, error)
 
     call get_value(json, 'data', p, stat=stat)
     if (stat /= 0) then
-      call fatal_error(error, "Failed to retrieve package data for '"//join_path(node%namespace, node%name)//"'."); return
+      call fatal_error(error, "Failed to read package data for '"//join_path(node%namespace, node%name)//"'."); return
     end if
 
     if (allocated(node%requested_version)) then
@@ -648,7 +649,7 @@ subroutine check_and_read_pkg_data(json, node, download_url, version, error)
 
     call get_value(q, 'download_url', download_url, stat=stat)
     if (stat /= 0) then
-      call fatal_error(error, "Failed to retrieve download url for '"//join_path(node%namespace, node%name)//"'."); return
+      call fatal_error(error, "Failed to read download url for '"//join_path(node%namespace, node%name)//"'."); return
     end if
 
     download_url = official_registry_base_url//download_url
@@ -659,12 +660,13 @@ subroutine check_and_read_pkg_data(json, node, download_url, version, error)
 
     call get_value(q, 'version', version_str, stat=stat)
     if (stat /= 0) then
-      call fatal_error(error, "Failed to retrieve version data for '"//join_path(node%namespace, node%name)//"'."); return
+      call fatal_error(error, "Failed to read version data for '"//join_path(node%namespace, node%name)//"'."); return
     end if
 
     call new_version(version, version_str, error)
     if (allocated(error)) then
-      call fatal_error(error, "Invalid version: '"//version_str//"'."); return
+      call fatal_error(error, "'"//version_str//"' is not a valid version for '"// &
+      & join_path(node%namespace, node%name)//"'."); return
     end if
   end subroutine
 

test/fpm_test/test_package_dependencies.f90

@@ -57,7 +57,22 @@ subroutine collect_package_dependencies(tests)
         & new_unittest("version-found-in-cache", version_found_in_cache), &
         & new_unittest("no-version-in-default-cache", no_version_in_default_cache), &
         & new_unittest("no-version-in-cache-or-registry", no_version_in_cache_or_registry, should_fail=.true.), &
-        & new_unittest("other-versions-in-default-cache", other_versions_in_default_cache) &
+        & new_unittest("other-versions-in-default-cache", other_versions_in_default_cache), &
+        & new_unittest("pkg-data-no-code", pkg_data_no_code, should_fail=.true.), &
+        & new_unittest("pkg-data-corrupt-code", pkg_data_corrupt_code, should_fail=.true.), &
+        & new_unittest("pkg-data-missing-error-message", pkg_data_missing_error_msg, should_fail=.true.), &
+        & new_unittest("pkg-data-error-reading-message", pkg_data_error_reading_msg, should_fail=.true.), &
+        & new_unittest("pkg-data-error-has-message", pkg_data_error_has_msg, should_fail=.true.), &
+        & new_unittest("pkg-data-error-no-data", pkg_data_no_data, should_fail=.true.), &
+        & new_unittest("pkg-data-error-reading-data", pkg_data_error_reading_data, should_fail=.true.), &
+        & new_unittest("pkg-data-requested-version-wrong-key", pkg_data_requested_version_wrong_key, should_fail=.true.), &
+        & new_unittest("pkg-data-no-version-requested-wrong-key", pkg_data_no_version_requested_wrong_key, should_fail=.true.), &
+        & new_unittest("pkg-data-error-reading-latest-version", pkg_data_error_reading_latest_version, should_fail=.true.), &
+        & new_unittest("pkg-data-no-download-url", pkg_data_no_download_url, should_fail=.true.), &
+        & new_unittest("pkg-data-error-reading-donwload-url", pkg_data_error_reading_download_url, should_fail=.true.), &
+        & new_unittest("pkg-data-no-version", pkg_data_no_version, should_fail=.true.), &
+        & new_unittest("pkg-data-error-reading-version", pkg_data_error_reading_version, should_fail=.true.), &
+        & new_unittest("pkg-data-invalid-version", pkg_data_invalid_version, should_fail=.true.) &
         & ]
 
   end subroutine collect_package_dependencies
@@ -920,6 +935,249 @@ subroutine other_versions_in_default_cache(error)
 
   end subroutine other_versions_in_default_cache
 
+  !> Package data returned from the registry does not contain a code field.
+  subroutine pkg_data_no_code(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_no_code
+
+  !> Error reading status code from package data.
+  subroutine pkg_data_corrupt_code(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": "integer expected"}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_corrupt_code
+
+  subroutine pkg_data_missing_error_msg(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 123}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_missing_error_msg
+
+  subroutine pkg_data_error_reading_msg(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 123, "message": 123}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_error_reading_msg
+
+  subroutine pkg_data_error_has_msg(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 123, "message": "Really bad error message"}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_error_has_msg
+
+  subroutine pkg_data_no_data(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 200}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_no_data
+
+  subroutine pkg_data_error_reading_data(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 200, "data": 123}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_error_reading_data
+
+  subroutine pkg_data_requested_version_wrong_key(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    allocate (node%requested_version)
+    call json_loads(j_value, '{"code": 200, "data": {"latest_version_data": 123}}') ! Expected key: "version_data"
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_requested_version_wrong_key
+
+  subroutine pkg_data_no_version_requested_wrong_key(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 200, "data": {"version_data": 123}}') ! Expected key: "latest_version_data"
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_no_version_requested_wrong_key
+
+  subroutine pkg_data_error_reading_latest_version(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 200, "data": {"latest_version_data": 123}}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_error_reading_latest_version
+
+  subroutine pkg_data_no_download_url(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 200, "data": {"latest_version_data": {}}}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_no_download_url
+
+  subroutine pkg_data_error_reading_download_url(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 200, "data": {"latest_version_data": {"download_url": 123}}}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_error_reading_download_url
+
+  subroutine pkg_data_no_version(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 200, "data": {"latest_version_data": {"download_url": "abc"}}}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_no_version
+
+  subroutine pkg_data_error_reading_version(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 200, "data": {"latest_version_data": {"download_url": "abc", "version": 123}}}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_error_reading_version
+
+  subroutine pkg_data_invalid_version(error)
+    type(error_t), allocatable, intent(out) :: error
+
+    type(dependency_node_t) :: node
+    character(:), allocatable :: url
+    type(version_t) :: version
+    type(json_object) :: json
+    class(json_value), allocatable :: j_value
+
+    call json_loads(j_value, '{"code": 200, "data": {"latest_version_data": {"download_url": "abc", "version": "abc"}}}')
+    json = cast_to_object(j_value)
+
+    call check_and_read_pkg_data(json, node, url, version, error)
+
+  end subroutine pkg_data_invalid_version
+
   !> Resolve a single dependency node
   subroutine resolve_dependency_once(self, dependency, root, error)
     !> Mock instance of the dependency tree