Skip to content

Commit b5c1b56

Browse files
committed
Not use semver but instead split before and after . and compare integers
1 parent 4bb65d2 commit b5c1b56

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

.github/compat/wide_compat_reports.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
from pathlib import Path
77
import pandas as pd
8-
import semver
98
import sys
109

1110
ip = Path(sys.argv[1]) # input file path
@@ -27,15 +26,12 @@
2726
aggfunc="first",
2827
).sort_values(by=["runner"])
2928

29+
3030
# group by compiler and sort by versions
3131
grouped_versions = {}
3232
for compiler in df.columns.get_level_values("compiler").unique():
3333
versions = df.loc[:, (compiler,)].columns.get_level_values("version").unique()
34-
# Parse and sort versions using semver
35-
versions = sorted(
36-
versions,
37-
key=lambda x: semver.VersionInfo.parse(x, optional_minor_and_patch=True),
38-
)
34+
versions = sorted(versions, key=lambda version: tuple(map(int, version.split("."))))
3935
grouped_versions[compiler] = versions
4036

4137
sorted_columns = []

requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
pandas
2-
semver
32
tabulate

0 commit comments

Comments
 (0)