Skip to content

Commit b45467c

Browse files
committed
reviews from Ivan
1 parent e21f94b commit b45467c

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

joss/paper_sparse.bib

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,3 +108,16 @@ @article{psblas
108108
numpages = {20},
109109
keywords = {sparse matrices, object-oriented design, Mathematics of computing}
110110
}
111+
112+
@article{scellc,
113+
author = {Kreutzer, Moritz and Hager, Georg and Wellein, Gerhard and Fehske, Holger and Bishop, Alan R.},
114+
title = {A Unified Sparse Matrix Data Format for Efficient General Sparse Matrix-Vector Multiplication on Modern Processors with Wide SIMD Units},
115+
journal = {SIAM Journal on Scientific Computing},
116+
volume = {36},
117+
number = {5},
118+
pages = {C401-C423},
119+
year = {2014},
120+
doi = {10.1137/130930352},
121+
url = { https://doi.org/10.1137/130930352 },
122+
eprint = { https://doi.org/10.1137/130930352 },
123+
}

joss/paper_sparse.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ authors:
2121
affiliations:
2222
- name: Transvalor S.A., France
2323
index: 1
24-
- name: Leibniz Centre of Supercomputing, Germany
24+
- name: Leibniz Supercomputing Centre, Garching, Germany
2525
index: 2
2626
- name: Wageningen University and Research, The Netherlands
2727
index: 3
@@ -70,7 +70,7 @@ All sparse formats extend an abstract base derived type sparse_type, which holds
7070
* CSR: compressed sparse row (Yale) format.
7171
* CSC: compressed sparse column format.
7272
* ELLPACK: fixed number of nonzeros per row, suited for vectorization.
73-
* SELL-C: sliced ELLPACK, balancing CSR and ELLPACK trade-offs [@anzt2014implementing].
73+
* SELL-C: sliced ELLPACK, balancing CSR and ELLPACK trade-offs [@scellc,@anzt2014implementing].
7474

7575
## Core functionality
7676

@@ -83,7 +83,7 @@ $$ y = \alpha op(A) * x + \beta * y$$
8383

8484
## Implementation details
8585

86-
Before introducing stdlib_sparse, the core structure and API was crafted under a stand-alone project, FSPARSE [@fsparse2024]. This enabled testing and refinement of the library before integration into stdlib.
86+
Before introducing stdlib_sparse, the core structure and API was crafted under a standalone project, FSPARSE [@fsparse2024]. This enabled testing and refinement of the library before integration into stdlib.
8787

8888
The module is designed with the following key features:
8989

@@ -132,7 +132,7 @@ end program main
132132

133133
# Performance and limitations
134134

135-
Sparse matrix–vector multiplication has been implemented for all formats. Preliminary tests confirm correctness and scalability to moderately large problems. However:
135+
Sparse matrix–vector multiplication has been implemented for all formats. Tests confirm correctness and scalability to moderately large problems. However:
136136

137137
* No sparse matrix–matrix multiplication or factorizations are yet implemented.
138138
* For data-parallelism (multi-processing with MPI or coarrays) the `spmv` kernel can be used as basis within each process. Multi-threading or GPU acceleration is not currently supported.

0 commit comments

Comments
 (0)