Fix issue where icon theme is not being propogated (#643)

* Fix implemented

* Update changelog

* Prepare Forui for review

* Fixed issue with progress

* Prepare Forui for review

* Update macos-latest goldens

* Update windows-latest goldens

* Update forui/CHANGELOG.md

---------

Co-authored-by: Matthias Ngeo <[email protected]>

Author: kawaijoe

forui/CHANGELOG.md

@@ -41,6 +41,8 @@ We've done a pass over the controllers in Forui to make them more consistent and
 * **Breaking** Change `FTappableStyle.mouseCursor` to `MouseCursor.defer`. See https://ux.stackexchange.com/questions/105024/why-dont-button-html-elements-have-a-css-cursor-pointer-by-default
   for our rationale behind this change.
 
+* Fix `FProgress.circularIcon()` using incorrect color.
+* Fix `FScaffold` not propagating `IconTheme` from `FStyle.iconStyle`.
 * Fix `FTabs` throwing an assertion error if `FTabController` is provided with a `initialIndex` > 0.
 
 

forui/bin/commands/style/style.dart

@@ -39,7 +39,7 @@ class _ApplicationState extends State<Application> with SingleTickerProviderStat
     locale: const Locale('en', 'US'),
     localizationsDelegates: FLocalizations.localizationsDelegates,
     supportedLocales: FLocalizations.supportedLocales,
-    theme: FThemes.zinc.light.toApproximateMaterialTheme(),
+    // theme: FThemes.zinc.light.toApproximateMaterialTheme(),
     builder: (context, child) => FTheme(data: FThemes.zinc.light, child: child!),
     home: Builder(
       builder: (context) {

forui/example/lib/main.dart

@@ -29,8 +29,6 @@ class _SandboxState extends State<Sandbox> with SingleTickerProviderStateMixin {
 
   @override
   Widget build(BuildContext context) {
-    return Center(
-      child: FAutocomplete(label: Text('Autocomplete'), hint: 'What can it do?', items: features),
-    );
+    return Center(child: const FProgress.circularIcon());
   }
 }

forui/example/lib/sandbox.dart

@@ -258,7 +258,7 @@ class FProgressStyles with Diagnosticable, _$FProgressStylesFunctions {
   /// Creates a [FProgressStyles] that inherits its properties.
   FProgressStyles.inherit({required FColors colors, required FStyle style})
     : linearProgressStyle = FLinearProgressStyle.inherit(colors: colors, style: style),
-      circularIconProgressStyle = IconThemeData(color: colors.mutedForeground, size: 20);
+      circularIconProgressStyle = IconThemeData(color: style.iconStyle.color, size: 20);
 }
 
 /// A linear [FProgress]'s style.

forui/lib/src/widgets/progress.dart

@@ -109,30 +109,34 @@ class FScaffold extends StatelessWidget {
 
     return AnnotatedRegion<SystemUiOverlayStyle>(
       value: style.systemOverlayStyle,
-      child: FSheets(
-        child: FToaster(
-          style: toasterStyle?.call(context.theme.toasterStyle) ?? context.theme.toasterStyle,
-          child: Row(
-            children: [
-              if (sidebar != null) ColoredBox(color: style.sidebarBackgroundColor, child: sidebar),
-              Expanded(
-                child: ColoredBox(
-                  color: style.backgroundColor,
-                  child: _RenderScaffoldWidget(
-                    resizeToAvoidBottomInset: resizeToAvoidBottomInset,
-                    children: [
-                      Column(
-                        children: [
-                          if (header != null) DecoratedBox(decoration: style.headerDecoration, child: header!),
-                          Expanded(child: child),
-                        ],
-                      ),
-                      footer,
-                    ],
+      child: IconTheme(
+        // TODO: Move to ForuiApp.
+        data: context.theme.style.iconStyle,
+        child: FSheets(
+          child: FToaster(
+            style: toasterStyle?.call(context.theme.toasterStyle) ?? context.theme.toasterStyle,
+            child: Row(
+              children: [
+                if (sidebar != null) ColoredBox(color: style.sidebarBackgroundColor, child: sidebar),
+                Expanded(
+                  child: ColoredBox(
+                    color: style.backgroundColor,
+                    child: _RenderScaffoldWidget(
+                      resizeToAvoidBottomInset: resizeToAvoidBottomInset,
+                      children: [
+                        Column(
+                          children: [
+                            if (header != null) DecoratedBox(decoration: style.headerDecoration, child: header!),
+                            Expanded(child: child),
+                          ],
+                        ),
+                        footer,
+                      ],
+                    ),
                   ),
                 ),
-              ),
-            ],
+              ],
+            ),
           ),
         ),
       ),