Fix GestureDetector being absorbed in focused FItems. (#700)

* Fix `GestureDetector` being absorbed in focused `FItem`s.

* Prepare Forui for review

* Fix failing test

---------

Co-authored-by: Pante <[email protected]>

Author: Pante

forui/CHANGELOG.md

@@ -46,6 +46,11 @@ We've improved the styles' generated documentation. They should be much easier t
 * **Breaking** Add `FFormFieldProperties(onReset: ...)`.
 
 
+### `FItem`
+
+* Fix `GestureDetector` being absorbed in focused `FItem`s.
+
+
 ### `FPopover` & `FPopoverMenu`
 * Add `FPopoverMotion`.
 

forui/lib/src/widgets/item/item.dart

@@ -288,22 +288,19 @@ class FItem extends StatelessWidget with FItemMixin {
           onSecondaryLongPress: enabled ? (onSecondaryLongPress ?? () {}) : null,
           shortcuts: shortcuts,
           actions: actions,
-          builder: (context, states, _) => Stack(
-            children: [
-              DecoratedBox(
-                decoration: style.decoration.maybeResolve(states) ?? const BoxDecoration(),
-                child: _builder(context, style, top, bottom, states, data.dividerColor, data.dividerWidth, divider),
+          builder: (context, states, _) => DecoratedBox(
+            position: DecorationPosition.foreground,
+            decoration: switch (style.focusedOutlineStyle) {
+              final outline? when states.contains(WidgetState.focused) => BoxDecoration(
+                border: Border.all(color: outline.color, width: outline.width),
+                borderRadius: outline.borderRadius,
               ),
-              if (style.focusedOutlineStyle case final outline? when states.contains(WidgetState.focused))
-                Positioned.fill(
-                  child: DecoratedBox(
-                    decoration: BoxDecoration(
-                      border: Border.all(color: outline.color, width: outline.width),
-                      borderRadius: outline.borderRadius,
-                    ),
-                  ),
-                ),
-            ],
+              _ => const BoxDecoration(),
+            },
+            child: DecoratedBox(
+              decoration: style.decoration.maybeResolve(states) ?? const BoxDecoration(),
+              child: _builder(context, style, top, bottom, states, data.dividerColor, data.dividerWidth, divider),
+            ),
           ),
         ),
       ),

forui/test/src/widgets/item/item_test.dart

@@ -1,4 +1,5 @@
 import 'package:flutter/material.dart';
+import 'package:flutter/services.dart';
 
 import 'package:flutter_test/flutter_test.dart';
 
@@ -144,4 +145,29 @@ void main() {
 
     expect(count, 1);
   });
+
+  testWidgets('focus does not cause inner gesture detector to be ignored', (tester) async {
+    var outer = 0;
+    var inner = 0;
+    final focusNode = autoDispose(FocusNode());
+    await tester.pumpWidget(
+      TestScaffold(
+        child: FItem(
+          focusNode: focusNode,
+          title: const Text('Bluetooth'),
+          onPress: () => outer++,
+          suffix: FButton.icon(onPress: () => inner++, child: const Icon(FIcons.pencil)),
+        ),
+      ),
+    );
+
+    await tester.sendKeyEvent(LogicalKeyboardKey.tab);
+    await tester.pumpAndSettle(const Duration(seconds: 1));
+
+    await tester.tap(find.byIcon(FIcons.pencil));
+    await tester.pumpAndSettle(const Duration(seconds: 1));
+
+    expect(inner, 1);
+    expect(outer, 0);
+  });
 }