Refactor password field (#688)

* Add password field

* Fix generator output

* Let's go

* Prepare Forui for review

* Update windows-latest goldens

* Fix controller

* Fix PR issues

---------

Co-authored-by: Pante <[email protected]>

Author: Pante

.github/workflows/forui_build_artifact.yaml renamed to .github/workflows/forui_nightly.yaml

@@ -1,11 +1,11 @@
-name: Forui Build Artifact
+name: Forui Nightly
 
 on:
   workflow_dispatch: {}
   push:
     branches: [ main ]
     paths:
-      - .github/workflows/forui_build_artifact.yaml
+      - forui_nightly.yaml
       - forui/**
 
 concurrency:
@@ -15,7 +15,7 @@ concurrency:
 jobs:
   build-artifact:
     if: github.actor != 'auto-maid[bot]'
-    name: Build Forui Artifact
+    name: Build Nightly Artifacts
     runs-on: ubuntu-latest
     defaults:
       run:
@@ -43,11 +43,11 @@ jobs:
 
       - run: |
           git fetch origin main
-          git checkout -B build-artifacts origin/main
-          git push origin build-artifacts --force
+          git checkout -B nightly origin/main
+          git push origin nightly --force
 
       - uses: EndBug/add-and-commit@v9
         with:
-          add: '--force **/*.style.dart'
-          new_branch: 'build-artifacts'
-          push: 'origin build-artifacts --set-upstream --force'
+          add: '--force **/*.design.dart'
+          new_branch: 'nightly'
+          push: 'origin nightly --set-upstream --force'

README.md

@@ -58,6 +58,21 @@ are exposed as hooks in the companion `forui_hooks` package.
 
 Please read the [contributing guide](/CONTRIBUTING.md).
 
+## Nightly Builds
+
+Nightly builds are available on the `nightly` branch. To use the latest nightly build, add the following to your `pubspec.yaml`:
+
+```yaml
+dependencies:
+  forui:
+    git:
+      url: https://github.com/forus-labs/forui.git
+      ref: nightly
+```
+
+Nightly builds are not guaranteed to be stable. Use at your own risk.
+
+
 ## License
 
 Code is licensed under the [MIT License](LICENSE). Fonts are licensed under [Open Font License](LICENSE). Icons are licensed under [ISC License](https://github.com/forus-labs/forui/blob/main/LICENSE).

docs/app/docs/form/text-field/page.mdx

@@ -172,10 +172,7 @@ FTextField(
   </Tabs.Tab>
   <Tabs.Tab>
     ```dart copy
-    FTextField.email(
-      initialValue: '[email protected]',
-      controller: _controller, // TextEditingController
-    );
+    FTextField.email(initialValue: '[email protected]');
     ```
   </Tabs.Tab>
 </Tabs>
@@ -188,10 +185,7 @@ FTextField(
   </Tabs.Tab>
   <Tabs.Tab>
     ```dart copy
-    FTextField.password(
-      controller: _controller, // TextEditingController
-      obscuringCharacter: '*',
-    );
+    FTextField.password();
     ```
   </Tabs.Tab>
 </Tabs>
@@ -205,7 +199,6 @@ FTextField(
   <Tabs.Tab>
     ```dart copy
     FTextField.multiline(
-      controller: _controller, // TextEditingController
       label: const Text('Leave a review'),
       maxLines: 4,
     );

docs/app/docs/form/text-form-field/page.mdx

@@ -154,6 +154,7 @@ FTextFormField.password(
   keyboardType: TextInputType.visiblePassword,
   textCapitalization: TextCapitalization.none,
   maxLines: 1,
+  obscureTextController: ValueNotifier(false),
 );
 ```
 

forui/CHANGELOG.md

@@ -62,7 +62,7 @@ We've added support for animated theme transitions. This should make transitions
 
 
 ### `FTextField` & `FTextFormField`
-We've added password visibility toggle functionality to password fields.
+We've added a password visibility toggle to password fields.
 
 * Add password visibility toggle to `FTextField.password(...)`.
 * Add password visibility toggle to `FTextFormField.password(...)`.

forui/README.md

@@ -55,6 +55,20 @@ are exposed as hooks in the companion `forui_hooks` package.
 
 Please read the [contributing guide](https://github.com/forus-labs/forui/blob/main/CONTRIBUTING.md).
 
+## Nightly Builds
+
+Nightly builds are available on the `nightly` branch. To use the latest nightly build, add the following to your `pubspec.yaml`:
+
+```yaml
+dependencies:
+  forui:
+    git:
+      url: https://github.com/forus-labs/forui.git
+      ref: nightly
+```
+
+Nightly builds are not guaranteed to be stable. Use at your own risk.
+
 ## License
 
 Licensed under the [MIT License](https://github.com/forus-labs/forui/blob/main/forui/LICENSE) and [Open Font License](https://github.com/forus-labs/forui/blob/main/forui/LICENSE).

forui/bin/commands/style/style.dart

@@ -16,7 +16,8 @@ enum Notification { all, direct, nothing, limitedTime, timeSensitive, selectedAp
 
 class _SandboxState extends State<Sandbox> with SingleTickerProviderStateMixin {
   late final FTabController c;
-  final obscureNotifier = ValueNotifier<bool>(false);
+  final controller = ValueNotifier<bool>(false);
+  final textController = TextEditingController();
 
   @override
   void initState() {
@@ -27,7 +28,8 @@ class _SandboxState extends State<Sandbox> with SingleTickerProviderStateMixin {
   @override
   void dispose() {
     c.dispose();
-    obscureNotifier.dispose();
+    controller.dispose();
+    textController.dispose();
     super.dispose();
   }
 
@@ -52,13 +54,13 @@ class _SandboxState extends State<Sandbox> with SingleTickerProviderStateMixin {
         FTextField.password(
           label: Text('FTextField Password (starts visible)'),
           hint: 'Enter password',
-          obscureText: obscureNotifier,
+          obscureTextController: controller,
         ),
         SizedBox(height: 20),
         FTextFormField.password(
           label: Text('FTextFormField Password (starts visible)'),
           hint: 'Enter password',
-          obscureText: obscureNotifier,
+          obscureTextController: controller,
         ),
       ],
     );

forui/example/lib/sandbox.dart

@@ -28,7 +28,7 @@ SPEC CHECKSUMS:
   FlutterMacOS: d0db08ddef1a9af05a5ec4b724367152bb0500b1
   package_info_plus: f0052d280d17aa382b932f399edf32507174e870
   path_provider_foundation: 080d55be775b7414fd5a5ef3ac137b97b097e564
-  wakelock_plus: 21ddc249ac4b8d018838dbdabd65c5976c308497
+  wakelock_plus: 917609be14d812ddd9e9528876538b2263aaa03b
 
 PODFILE CHECKSUM: 9ebaf0ce3d369aaa26a9ea0e159195ed94724cf3
 

forui/example/macos/Podfile.lock

@@ -24,5 +24,7 @@
   "popoverSemanticsLabel": "Opspringer",
   "multiSelectHint": "Kies items",
   "autocompleteNoResults": "Geen resultate gevind nie.",
-  "progressSemanticsLabel": "Besig om te laai"
+  "progressSemanticsLabel": "Besig om te laai",
+  "passwordFieldObscureTextButtonSemanticsLabel": "Versteek wagwoord",
+  "passwordFieldUnobscureTextButtonSemanticsLabel": "Wys wagwoord"
 }