Skip to content

Commit 5ddf3e2

Browse files
committed
Rectified inaccurate Argument in nSIM Wrapper Configuration.
With the integration of the QEMU testsuite, a change in the configuration arguments for the QEMU wrapper was introduced. The `-semihosting` flag, previously directly applied in the wrapper, has been removed and is now provided as an argument `-Wq,-semihosting`. This adjustment was necessary because the QEMU Testsuite does not support enabling the flag in its former fashion. This commit addresses the issue where `-Wq,semihosting` was improperly passed to the nSIM wrapper, causing a crash. Signed-off-by: Luis Silva <[email protected]>
1 parent 139f7b8 commit 5ddf3e2

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

Makefile.in

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,20 +140,25 @@ endif
140140
ifeq ($(SIM),qemu)
141141
# Using qemu simulator.
142142
SIM_STAMP:= stamps/build-qemu
143+
SIM_PATH:=$(srcdir)/scripts/wrapper/$(SIM)
144+
SIM_PREPARE:=PATH="$(SIM_PATH):$(INSTALL_DIR)/bin:$(PATH)" ARC_SYSROOT="$(SYSROOT)" DEJAGNU="$(srcdir)/dejagnu/site.exp" QEMU_CPU="$(QEMU_CPU)"
145+
ifeq (@default_target@,baremetal)
146+
SIM_PREPARE:=$(SIM_PREPARE) DEJAGNU_SIM_OPTIONS="-Wq,-semihosting"
147+
endif
143148
else
144149
ifeq ($(SIM),nsim)
145150
# Using nsim simulator.
146151
ifeq (@default_target@, linux)
147152
$(error nSIM not supported)
148153
endif
149154
SIM_STAMP:= nsim-validation
155+
SIM_PATH:=$(srcdir)/scripts/wrapper/$(SIM)
156+
SIM_PREPARE:=PATH="$(SIM_PATH):$(INSTALL_DIR)/bin:$(PATH)" ARC_SYSROOT="$(SYSROOT)" DEJAGNU="$(srcdir)/dejagnu/site.exp" QEMU_CPU="$(QEMU_CPU)"
150157
else
151158
$(error Only support SIM=nsim, or SIM=qemu (default))
152159
endif
153160
endif
154161

155-
SIM_PATH:=$(srcdir)/scripts/wrapper/$(SIM)
156-
SIM_PREPARE:=PATH="$(SIM_PATH):$(INSTALL_DIR)/bin:$(PATH)" ARC_SYSROOT="$(SYSROOT)" DEJAGNU="$(srcdir)/dejagnu/site.exp" QEMU_CPU="$(QEMU_CPU)"
157162

158163
all: @default_target@ @qemu_build@
159164
echo "$(INSTALL_DIR)" > stamps/install_dir
@@ -589,20 +594,20 @@ stamps/check-gcc-linux: stamps/build-gcc-linux-stage2 $(SIM_STAMP)
589594
date > $@
590595

591596
stamps/check-gcc-baremetal: stamps/build-gcc-newlib-stage2 $(SIM_STAMP)
592-
$(SIM_PREPARE) DEJAGNU_SIM_OPTIONS="-Wq,-semihosting" $(MAKE) -C build-gcc-newlib-stage2 check-gcc "RUNTESTFLAGS=$(RUNTESTFLAGS) --target_board='$(NEWLIB_TARGET_BOARDS)'"
597+
$(SIM_PREPARE) $(MAKE) -C build-gcc-newlib-stage2 check-gcc "RUNTESTFLAGS=$(RUNTESTFLAGS) --target_board='$(NEWLIB_TARGET_BOARDS)'"
593598
mkdir -p $(dir $@)
594599
date > $@
595600

596601
stamps/check-binutils-baremetal: stamps/build-gcc-newlib-stage2 $(SIM_STAMP)
597-
$(SIM_PREPARE) DEJAGNU_SIM_OPTIONS="-Wq,-semihosting" $(MAKE) -C build-binutils-newlib check-binutils check-gas check-ld -k "RUNTESTFLAGS=--target_board='$(NEWLIB_TARGET_BOARDS)'" || true
602+
$(SIM_PREPARE) $(MAKE) -C build-binutils-newlib check-binutils check-gas check-ld -k "RUNTESTFLAGS=--target_board='$(NEWLIB_TARGET_BOARDS)'" || true
598603
date > $@
599604

600605
stamps/check-binutils-linux: stamps/build-gcc-linux-stage2 $(SIM_STAMP)
601606
$(SIM_PREPARE) $(MAKE) -C build-binutils-linux check-binutils check-gas check-ld -k "RUNTESTFLAGS=--target_board='$(GLIBC_TARGET_BOARDS)'" || true
602607
date > $@
603608

604609
stamps/check-newlib-baremetal: stamps/build-newlib $(SIM_STAMP)
605-
$(SIM_PREPARE) DEJAGNU_SIM_OPTIONS="-Wq,-semihosting" $(MAKE) -C build-newlib check -k "RUNTESTFLAGS=--target_board='$(NEWLIB_TARGET_BOARDS)'" || true
610+
$(SIM_PREPARE) $(MAKE) -C build-newlib check -k "RUNTESTFLAGS=--target_board='$(NEWLIB_TARGET_BOARDS)'" || true
606611
date > $@
607612

608613
nsim-validation:

0 commit comments

Comments
 (0)