Skip to content

Commit d62cf1f

Browse files
committed
uclibc: build uclibc unstripped by default
uClibc can be built stripped (implemented as link-time option in uClibc). This could be useful for those who build root fs manually. In Buildroot there is a global strip stage wich strips most of shared libs in "target" folder (wexcept kernel modules known to not work properly being stripped and libpthread required to be non-stripped for correct debugging with gdb of multi-threaded apps). So there're few problems with current implementation: 1. uClibc is being stripped 2 times (first on its build stage, second on global Buildroot strip stage) 2. uClibc libs in "staging" folder are also always stripped except if "no strip" (BR2_STRIP_none) is explicitly is selected in Buildroot config. That makes it possible to remote debug uClibc libs on target only if target rootfs was not stripped (which might not be possible due to huge libs like Qt) This patch disables embedded strip in uClibc (still users may modify uClibc config and explicitly set "DOSTRIP=yes" if really needed). Interesting that DOSTRIP was not only selected in uClibc config but also was force set with Buildroot on uClibc configuration step with UCLIBC_STRIP_CONFIG. Signed-off-by: Alexey Brodkin <[email protected]> Cc: Vicente Olivert Riera <[email protected]> Cc: Peter Korsgaard <[email protected]> Cc: Gustavo Zacarias <[email protected]> Cc: Thomas De Schampheleire <[email protected]> Cc: Thomas Petazzoni <[email protected]> Cc: Waldemar Brodkorb <[email protected]> Reviewed-by: Thomas Petazzoni <[email protected]> Signed-off-by: Peter Korsgaard <[email protected]>
1 parent b89d06a commit d62cf1f

File tree

4 files changed

+3
-14
lines changed

4 files changed

+3
-14
lines changed

package/uclibc/uClibc-0.9.31.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ CROSS_COMPILER_PREFIX=""
228228
UCLIBC_EXTRA_CFLAGS=""
229229
# DODEBUG is not set
230230
# DODEBUG_PT is not set
231-
DOSTRIP=y
231+
# DOSTRIP is not set
232232
# DOASSERTS is not set
233233
# SUPPORT_LD_DEBUG is not set
234234
# SUPPORT_LD_DEBUG_EARLY is not set

package/uclibc/uClibc-0.9.33.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ CROSS_COMPILER_PREFIX=""
266266
UCLIBC_EXTRA_CFLAGS=""
267267
# DODEBUG is not set
268268
# DODEBUG_PT is not set
269-
DOSTRIP=y
269+
# DOSTRIP is not set
270270
# DOASSERTS is not set
271271
# SUPPORT_LD_DEBUG is not set
272272
# SUPPORT_LD_DEBUG_EARLY is not set

package/uclibc/uClibc-snapshot.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ CROSS_COMPILER_PREFIX=""
271271
UCLIBC_EXTRA_CFLAGS=""
272272
# DODEBUG is not set
273273
# DODEBUG_PT is not set
274-
DOSTRIP=y
274+
# DOSTRIP is not set
275275
# DOASSERTS is not set
276276
# SUPPORT_LD_DEBUG is not set
277277
# SUPPORT_LD_DEBUG_EARLY is not set

package/uclibc/uclibc.mk

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -381,16 +381,6 @@ else
381381
UCLIBC_WCHAR_CONFIG = $(call KCONFIG_DISABLE_OPT,UCLIBC_HAS_WCHAR,$(@D)/.config)
382382
endif
383383

384-
#
385-
# strip
386-
#
387-
388-
ifeq ($(BR2_STRIP_none),y)
389-
UCLIBC_STRIP_CONFIG = $(call KCONFIG_DISABLE_OPT,DOSTRIP,$(@D)/.config)
390-
else
391-
UCLIBC_STRIP_CONFIG = $(call KCONFIG_ENABLE_OPT,DOSTRIP,$(@D)/.config)
392-
endif
393-
394384
#
395385
# Commands
396386
#
@@ -430,7 +420,6 @@ define UCLIBC_KCONFIG_FIXUP_CMDS
430420
$(UCLIBC_THREAD_DEBUG_CONFIG)
431421
$(UCLIBC_LOCALE_CONFIG)
432422
$(UCLIBC_WCHAR_CONFIG)
433-
$(UCLIBC_STRIP_CONFIG)
434423
endef
435424

436425
define UCLIBC_CONFIGURE_CMDS

0 commit comments

Comments
 (0)