Skip to content

Commit 31fc730

Browse files
windows: Add Finish page to uninstaller
Back in a time a warning message has been added to uninstaller that was saying that some files are removed by it - files that were created by Eclipse, for example. However it seems that this message wasn't in the version imported to GitHub, and nobody noticed for one and half year. This commits returns this message. See STAR 9000691488. Signed-off-by: Anton Kolesov <[email protected]>
1 parent 3387db2 commit 31fc730

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

windows-installer/installer.nsi

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,19 @@ RequestExecutionLevel admin
7171
!insertmacro MUI_PAGE_COMPONENTS
7272
!insertmacro MUI_PAGE_DIRECTORY
7373
!insertmacro MUI_PAGE_INSTFILES
74+
75+
# Uninstaller pages mostly use same defines as installer ones, so to have
76+
# different texts, defiens should be done twice: for install page and for
77+
# uninstall page.
78+
!define MUI_FINISHPAGE_TEXT "Please note: uninstall process can only remove \
79+
files created by the installer. Programs like Eclipse may create files \
80+
which will be left behind by the installer. Users should manually remove these \
81+
file after uninstall to avoid any problems, especially when uninstalling to \
82+
upgrade to new version being re-installed to same location."
83+
7484
!insertmacro MUI_UNPAGE_CONFIRM
7585
!insertmacro MUI_UNPAGE_INSTFILES
86+
!insertmacro MUI_UNPAGE_FINISH
7687

7788
!insertmacro MUI_LANGUAGE "English"
7889

0 commit comments

Comments
 (0)