Skip to content

Commit baffcf3

Browse files
Suppress error meaningless error messages when building newlib PDF
There is a know issue when building newlib PDFs with certain texinfo versions, hence build-elf32.sh does this build three times. However, until now error message from `make_target_ordered` was still emitted into the stdout, and what could confuse user, since error message is shown, but build process continues. This patch hides those message by simply redirecting stdout to /dev/null. Another option would be to make a special version of `make_target_ordered`, for example `make_target_ordered_quiet` or add an argument to an existing function. However I felt that this might be an overcomplication to solve problem with some particular case. Signed-off-by: Anton Kolesov <[email protected]>
1 parent 32b8774 commit baffcf3

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

build-elf32.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,12 @@ then
243243
# "/usr/bin/texi2dvi: pdfetex exited with bad status, quitting."
244244
# Hence we have to invoke make trice - once for each PDF to be built, and then to install
245245
# them. Detection is based on texinfo version instead of the OS.
246-
make_target_ordered "generating PDF documentation" install-pdf-target-newlib || true
247-
make_target_ordered "generating PDF documentation" install-pdf-target-newlib || true
246+
# `make_target_ordered` will emit it's own error messages on make failures, so they should
247+
# be suppressed, so that users will not be confused.
248+
make_target_ordered "generating PDF documentation" \
249+
install-pdf-target-newlib &>/dev/null || true
250+
make_target_ordered "generating PDF documentation" \
251+
install-pdf-target-newlib &>/dev/null || true
248252
make_target_ordered "generating PDF documentation" install-pdf-target-newlib
249253
else
250254
make_target "generating PDF documentation" install-pdf-target-newlib

0 commit comments

Comments
 (0)