Skip to content

Commit 8b3a356

Browse files
committed
fixed issues
1 parent 9e007fa commit 8b3a356

File tree

2 files changed

+50
-7
lines changed

2 files changed

+50
-7
lines changed

lib/codegen/kotlin/okhttp.dart

Lines changed: 38 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import 'package:apidash/consts.dart';
77

88
class KotlinOkHttpCodeGen {
99
final String kTemplateStart = """import okhttp3.OkHttpClient
10-
import okhttp3.Request{{importForQuery}}{{importForBody}}{{importForFormData}}
10+
import okhttp3.Request{{importForQuery}}{{importForBody}}{{importForFormData}}{{importForFile}}
1111
1212
fun main() {
1313
val client = OkHttpClient()
@@ -27,6 +27,12 @@ import okhttp3.MediaType.Companion.toMediaType""";
2727
2828
import okhttp3.MultipartBody""";
2929

30+
final String kStringImportForFile = """
31+
32+
import java.io.File
33+
import okhttp3.RequestBody.Companion.asRequestBody
34+
import okhttp3.MediaType.Companion.toMediaType""";
35+
3036
final String kTemplateUrl = '''
3137
3238
val url = "{{url}}"
@@ -68,7 +74,7 @@ import okhttp3.MultipartBody""";
6874
// Converting list of form data objects to kolin multi part data
6975
String kFormDataBody = '''
7076
val body = MultipartBody.Builder().setType(MultipartBody.FORM){% for item in formDataList %}{% if item.type == 'file' %}
71-
.addFormDataPart("{{item.name}}",null,File("{{item.value}}").asRequestBody("application/octet-stream".toMediaType()))
77+
.addFormDataPart("{{item.name}}",File("{{item.value}}").name,File("{{item.value}}").asRequestBody("application/octet-stream".toMediaType()))
7278
{% else %}.addFormDataPart("{{item.name}}","{{item.value}}")
7379
{% endif %}{% endfor %}.build()
7480
''';
@@ -81,6 +87,7 @@ import okhttp3.MultipartBody""";
8187
bool hasQuery = false;
8288
bool hasBody = false;
8389
bool hasFormData = false;
90+
bool hasFile = false;
8491

8592
var rec = getValidRequestUri(
8693
requestModel.url,
@@ -111,8 +118,34 @@ import okhttp3.MultipartBody""";
111118
hasFormData = true;
112119
var formDataTemplate = jj.Template(kFormDataBody);
113120

121+
List<Map<String,String>> modifiedFormDataList = [];
122+
for (var item in requestModel.formDataList) {
123+
if (item.type == FormDataType.file ) {
124+
if (item.value[0] == "/") {
125+
modifiedFormDataList.add({
126+
"name": item.name,
127+
"value": item.value.substring(1),
128+
"type": "file"
129+
});
130+
}else{
131+
modifiedFormDataList.add({
132+
"name": item.name,
133+
"value": item.value,
134+
"type": "file"
135+
});
136+
}
137+
hasFile = true;
138+
}else{
139+
modifiedFormDataList.add({
140+
"name": item.name,
141+
"value": item.value,
142+
"type": "text"
143+
});
144+
}
145+
}
146+
114147
result += formDataTemplate.render({
115-
"formDataList": requestModel.formDataMapList,
148+
"formDataList": modifiedFormDataList,
116149
});
117150
} else if (kMethodsWithBody.contains(method) && requestBody != null) {
118151
var contentLength = utf8.encode(requestBody).length;
@@ -129,7 +162,8 @@ import okhttp3.MultipartBody""";
129162
var stringStart = templateStart.render({
130163
"importForQuery": hasQuery ? kStringImportForQuery : "",
131164
"importForBody": hasBody ? kStringImportForBody : "",
132-
"importForFormData": hasFormData ? kStringImportForFormData : ""
165+
"importForFormData": hasFormData ? kStringImportForFormData : "",
166+
"importForFile": hasFile ? kStringImportForFile : "",
133167
});
134168

135169
result = stringStart + result;

test/codegen/kotlin_okhttp_codegen_test.dart

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -581,14 +581,17 @@ fun main() {
581581
const expectedCode = r'''import okhttp3.OkHttpClient
582582
import okhttp3.Request
583583
import okhttp3.MultipartBody
584+
import java.io.File
585+
import okhttp3.RequestBody.Companion.asRequestBody
586+
import okhttp3.MediaType.Companion.toMediaType
584587
585588
fun main() {
586589
val client = OkHttpClient()
587590
588591
val url = "https://api.apidash.dev/io/img"
589592
val body = MultipartBody.Builder().setType(MultipartBody.FORM).addFormDataPart("token","xyz")
590593
591-
.addFormDataPart("imfile",null,File("/Documents/up/1.png").asRequestBody("application/octet-stream".toMediaType()))
594+
.addFormDataPart("imfile",File("Documents/up/1.png").name,File("Documents/up/1.png").asRequestBody("application/octet-stream".toMediaType()))
592595
.build()
593596
val request = Request.Builder()
594597
.url(url)
@@ -610,14 +613,17 @@ fun main() {
610613
const expectedCode = r'''import okhttp3.OkHttpClient
611614
import okhttp3.Request
612615
import okhttp3.MultipartBody
616+
import java.io.File
617+
import okhttp3.RequestBody.Companion.asRequestBody
618+
import okhttp3.MediaType.Companion.toMediaType
613619
614620
fun main() {
615621
val client = OkHttpClient()
616622
617623
val url = "https://api.apidash.dev/io/img"
618624
val body = MultipartBody.Builder().setType(MultipartBody.FORM).addFormDataPart("token","xyz")
619625
620-
.addFormDataPart("imfile",null,File("/Documents/up/1.png").asRequestBody("application/octet-stream".toMediaType()))
626+
.addFormDataPart("imfile",File("Documents/up/1.png").name,File("Documents/up/1.png").asRequestBody("application/octet-stream".toMediaType()))
621627
.build()
622628
val request = Request.Builder()
623629
.url(url)
@@ -673,6 +679,9 @@ fun main() {
673679
import okhttp3.Request
674680
import okhttp3.HttpUrl.Companion.toHttpUrl
675681
import okhttp3.MultipartBody
682+
import java.io.File
683+
import okhttp3.RequestBody.Companion.asRequestBody
684+
import okhttp3.MediaType.Companion.toMediaType
676685
677686
fun main() {
678687
val client = OkHttpClient()
@@ -683,7 +692,7 @@ fun main() {
683692
.build()
684693
val body = MultipartBody.Builder().setType(MultipartBody.FORM).addFormDataPart("token","xyz")
685694
686-
.addFormDataPart("imfile",null,File("/Documents/up/1.png").asRequestBody("application/octet-stream".toMediaType()))
695+
.addFormDataPart("imfile",File("Documents/up/1.png").name,File("Documents/up/1.png").asRequestBody("application/octet-stream".toMediaType()))
687696
.build()
688697
val request = Request.Builder()
689698
.url(url)

0 commit comments

Comments
 (0)