Merge pull request #847 from surelyruchi/resolve-url-parsing-ip-port

Fix: prevent malformed URL error when parsing IP:PORT by adding defau…

Author: ashitaprasad

packages/apidash_core/lib/consts.dart

@@ -30,6 +30,8 @@ final kSupportedUriSchemes =
     SupportedUriSchemes.values.map((i) => i.name).toList();
 const kDefaultUriScheme = SupportedUriSchemes.https;
 final kLocalhostRegex = RegExp(r'^localhost(:\d+)?(/.*)?$');
+final kIPHostRegex =
+    RegExp(r'^((25[0-5]|(2[0-4]|1\d|[1-9]|)\d)\.?\b){4}(:\d+)?(/.*)?$');
 
 const kMethodsWithBody = [
   HTTPVerb.post,

packages/apidash_core/lib/utils/uri_utils.dart

@@ -30,9 +30,10 @@ String stripUrlParams(String url) {
     return (null, "URL is missing!");
   }
 
-  if (kLocalhostRegex.hasMatch(url)) {
+  if (kLocalhostRegex.hasMatch(url) || kIPHostRegex.hasMatch(url)) {
     url = '${SupportedUriSchemes.http.name}://$url';
   }
+
   Uri? uri = Uri.tryParse(url);
   if (uri == null) {
     return (null, "Check URL (malformed)");

packages/apidash_core/test/utils/uri_utils_test.dart

@@ -62,6 +62,37 @@ void main() {
       expect(getValidRequestUri(url1, []), (uri1Expected, null));
     });
 
+    test('Testing getValidRequestUri with IP URL without port or path', () {
+      String url1 = "8.8.8.8";
+      Uri uri1Expected = Uri(scheme: 'http', host: '8.8.8.8');
+      expect(getValidRequestUri(url1, []), (uri1Expected, null));
+    });
+
+    test('Testing getValidRequestUri with IP URL with port', () {
+      String url1 = "8.8.8.8:8080";
+      Uri uri1Expected = Uri(scheme: 'http', host: '8.8.8.8', port: 8080);
+      expect(getValidRequestUri(url1, []), (uri1Expected, null));
+    });
+
+    test('Testing getValidRequestUri with IP URL with port and path', () {
+      String url1 = "8.8.8.8:8080/hello";
+      Uri uri1Expected =
+          Uri(scheme: 'http', host: '8.8.8.8', port: 8080, path: '/hello');
+      expect(getValidRequestUri(url1, []), (uri1Expected, null));
+    });
+
+    test('Testing getValidRequestUri with IP URL with http prefix', () {
+      String url1 = "http://8.8.8.8:3080";
+      Uri uri1Expected = Uri(scheme: 'http', host: '8.8.8.8', port: 3080);
+      expect(getValidRequestUri(url1, []), (uri1Expected, null));
+    });
+
+    test('Testing getValidRequestUri with IP URL with https prefix', () {
+      String url1 = "https://8.8.8.8:8080";
+      Uri uri1Expected = Uri(scheme: 'https', host: '8.8.8.8', port: 8080);
+      expect(getValidRequestUri(url1, []), (uri1Expected, null));
+    });
+
     test('Testing getValidRequestUri for normal values', () {
       String url1 = "https://api.apidash.dev/country/data";
       const kvRow1 = NameValueModel(name: "code", value: "US");