Skip to content

Commit cc6c49c

Browse files
committed
updated php tests
1 parent f2ca3ea commit cc6c49c

File tree

6 files changed

+353
-171
lines changed

6 files changed

+353
-171
lines changed

lib/codegen/php/curl.dart

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,14 @@ $request_body = '{{body}}';
3737
$queryParams = [
3838
{{params}}
3939
];
40-
$uri .= '?' . http_build_query($queryParams, '', '&');
40+
$queryParts = [];
41+
foreach ($queryParams as $key => $values) {
42+
foreach ((array) $values as $value) {
43+
$queryParts[] = urlencode($key) . '=' . urlencode($value);
44+
}
45+
}
46+
$queryString = implode('&', $queryParts);
47+
$uri .= '?' . $queryString;
4148
4249
4350
''';

lib/codegen/php/guzzle.dart

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,14 @@ String kTemplateParams = """
2424
\$queryParams = [
2525
{{params}}
2626
];
27-
\$queryParamsStr = '?' . http_build_query(\$queryParams, '','&');
27+
\$queryParts = [];
28+
foreach (\$queryParams as \$key => \$values) {
29+
foreach ((array)\$values as \$value) {
30+
\$queryParts[] = urlencode(\$key) . '=' . urlencode(\$value);
31+
}
32+
}
33+
\$queryParamsStr = '?' . implode('&', \$queryParts);
34+
2835
""";
2936

3037

lib/codegen/php/http_plug.dart

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ use Http\\Discovery\\Psr18ClientDiscovery;
2222
\$queryParams = [
2323
{{params}}
2424
];
25-
\$uri .= '?' . http_build_query(\$queryParams,'','&');
25+
\$queryString = http_build_query(\$queryParams, '', '&', PHP_QUERY_RFC3986);
26+
\$queryString = preg_replace('/%5B[0-9]+%5D/', '', \$queryString);
27+
28+
\$uri .= '?'.\$queryString;
29+
2630
2731
""";
2832

0 commit comments

Comments
 (0)