Mark most classes as readonly

Using `Rector\Php81\Rector\Property\ReadOnlyPropertyRector` and `Rector\Php82\Rector\Class_\ReadOnlyClassRector`.

All controllers should be readonly. `Tags` and `Opml\Import` are an exception, for now, as they are doing weird stateful things.

Ideally, spouts and helpers would be too but there are some backwards compatibility concerns.

Author: jtojnar

src/controllers/About.php

@@ -11,7 +11,7 @@
 /**
  * Controller for instance information API
  */
-final class About {
+final readonly class About {
     public function __construct(
         private Authentication $authentication,
         private Configuration $configuration,

src/controllers/Authentication.php

@@ -10,7 +10,7 @@
 /**
  * Controller for user related tasks
  */
-final class Authentication {
+final readonly class Authentication {
     public function __construct(
         private AuthenticationService $authenticationService,
         private View $view

src/controllers/Helpers/HashPassword.php

@@ -10,7 +10,7 @@
 /**
  * Controller for user related tasks
  */
-final class HashPassword {
+final readonly class HashPassword {
     public function __construct(
         private Authentication $authentication,
         private View $view

src/controllers/Index.php

@@ -18,7 +18,7 @@
  * @license    GPLv3 (https://www.gnu.org/licenses/gpl-3.0.html)
  * @author     Tobias Zeising <tobias.zeising@aditu.de>
  */
-final class Index {
+final readonly class Index {
     public function __construct(
         private Authentication $authentication,
         private \daos\Items $itemsDao,

src/controllers/Items.php

@@ -19,7 +19,7 @@
  * @license    GPLv3 (https://www.gnu.org/licenses/gpl-3.0.html)
  * @author     Tobias Zeising <tobias.zeising@aditu.de>
  */
-final class Items {
+final readonly class Items {
     public function __construct(
         private Authentication $authentication,
         private \daos\Items $itemsDao,

src/controllers/Items/Stats.php

@@ -10,7 +10,7 @@
 /**
  * Controller for viewing item statistics
  */
-final class Stats {
+final readonly class Stats {
     public function __construct(
         private Authentication $authentication,
         private \daos\Items $itemsDao,

src/controllers/Items/Sync.php

@@ -13,7 +13,7 @@
 /**
  * Controller for synchronizing item statuses
  */
-final class Sync {
+final readonly class Sync {
     public function __construct(
         private Authentication $authentication,
         private Configuration $configuration,

src/controllers/Opml/Export.php

@@ -18,7 +18,7 @@
  * @author     Michael Moore <stuporglue@gmail.com>
  * @author     Sean Rand <asanernd@gmail.com>
  */
-final class Export {
+final readonly class Export {
     public function __construct(
         private Authentication $authentication,
         private Configuration $configuration,

src/controllers/Opml/Import.php

@@ -17,16 +17,17 @@
  * @author     Michael Moore <stuporglue@gmail.com>
  * @author     Sean Rand <asanernd@gmail.com>
  */
+// TODO: Make readonly.
 final class Import {
     /** @var array<string, array{id: int, tags: string[]}> Sources that have been imported from the OPML file */
     private array $imported = [];
 
     public function __construct(
-        private Authentication $authentication,
-        private Logger $logger,
-        private \daos\Sources $sourcesDao,
-        private \daos\Tags $tagsDao,
-        private View $view
+        private readonly Authentication $authentication,
+        private readonly Logger $logger,
+        private readonly \daos\Sources $sourcesDao,
+        private readonly \daos\Tags $tagsDao,
+        private readonly View $view
     ) {
     }
 

src/controllers/Rss.php

@@ -17,7 +17,7 @@
  * @license    GPLv3 (https://www.gnu.org/licenses/gpl-3.0.html)
  * @author     Tobias Zeising <tobias.zeising@aditu.de>
  */
-final class Rss {
+final readonly class Rss {
     public function __construct(
         private Authentication $authentication,
         private Configuration $configuration,