feat: add validations to discount code

Author: abhinavk96

app/components/forms/events/view/create-discount-code.js

@@ -3,7 +3,7 @@ import { computed } from '@ember/object';
 import FormMixin from 'open-event-frontend/mixins/form';
 import { later } from '@ember/runloop';
 import { currencySymbol } from 'open-event-frontend/helpers/currency-symbol';
-
+import moment from 'moment';
 export default Component.extend(FormMixin, {
   getValidationRules() {
     window.$.fn.form.settings.rules.checkMaxMin = () => {
@@ -21,6 +21,12 @@ export default Component.extend(FormMixin, {
       }
       return false;
     };
+
+    window.$.fn.form.settings.rules.checkDates = () => {
+      let startDatetime = moment(this.get('data.validFrom'));
+      let endDatetime = moment(this.get('data.validTill'));
+      return (endDatetime.diff(startDatetime, 'minutes') > 0);
+    };
     return {
       inline : true,
       delay  : false,
@@ -107,6 +113,46 @@ export default Component.extend(FormMixin, {
               prompt : this.l10n.t('Please select atleast 1 ticket.')
             }
           ]
+        },
+        startDate: {
+          optional   : true,
+          identifier : 'start_date',
+          rules      : [
+            {
+              type   : 'checkDates',
+              prompt : this.l10n.t('Valid Till date & time should be after valid from date and time')
+            }
+          ]
+        },
+        startTime: {
+          optional   : true,
+          identifier : 'start_time',
+          rules      : [
+            {
+              type   : 'checkDates',
+              prompt : this.l10n.t('Valid Till date & time should be after valid from date and time')
+            }
+          ]
+        },
+        endDate: {
+          optional   : true,
+          identifier : 'end_date',
+          rules      : [
+            {
+              type   : 'checkDates',
+              prompt : this.l10n.t('Valid Till date & time should be after valid from date and time')
+            }
+          ]
+        },
+        endTime: {
+          optional   : true,
+          identifier : 'end_time',
+          rules      : [
+            {
+              type   : 'checkDates',
+              prompt : this.l10n.t('Valid Till date & time should be after valid from date and time')
+            }
+          ]
         }
       }
     };

app/components/widgets/forms/time-picker.js

@@ -5,7 +5,7 @@ import { FORM_TIME_FORMAT } from 'open-event-frontend/utils/dictionary/date-time
 
 export default Component.extend({
 
-  classNames        : ['ui', 'calendar', 'time', 'picker', 'input', 'fluid'],
+  classNames        : ['ui', 'calendar', 'time', 'picker', 'input', 'fluid', 'field'],
   classNameBindings : ['icon:left', 'icon'],
 
   icon: true,
@@ -28,14 +28,14 @@ export default Component.extend({
       }
     };
 
-    switch (this.rangePosition) {
-      case 'start':
-        defaultOptions.endCalendar = this.$().closest('.fields').find('.ui.calendar.time.picker');
-        break;
-      case 'end':
-        defaultOptions.startCalendar = this.$().closest('.fields').find('.ui.calendar.time.picker');
-        break;
-    }
+    // switch (this.rangePosition) {
+    //   case 'start':
+    //     defaultOptions.endCalendar = this.$().closest('.fields').find('.ui.calendar.time.picker');
+    //     break;
+    //   case 'end':
+    //     defaultOptions.startCalendar = this.$().closest('.fields').find('.ui.calendar.time.picker');
+    //     break;
+    // }
 
     this.$().calendar(merge(defaultOptions, this.options));
   },

app/models/discount-code.js

@@ -22,9 +22,9 @@ export default ModelBase.extend({
   ticketsNumber : attr('number'), // For form (1) this holds the max. times this can be used for events
   minQuantity   : attr('number', { defaultValue: 0 }), // Not of any significance for form (1)
   maxQuantity   : attr('number'), // For form (1) this holds the number of months this code is valid for events
-  validFrom     : attr('moment'),
+  validFrom     : attr('moment', { defaultValue: () => moment().startOf('day') }),
   discountUrl   : attr('string'),
-  validTill     : attr('moment', { defaultValue: () => moment.tz(detectedTimezone).add(1, 'months').startOf('day') }),
+  validTill     : attr('moment', { defaultValue: () => moment().add(1, 'months').startOf('day') }),
   usedFor       : attr('string'),
   isActive      : attr('boolean', { defaultValue: true }),
   createdAt     : attr('moment'),

app/templates/components/forms/events/view/create-discount-code.hbs

@@ -69,15 +69,15 @@
       <div class="fields">
         <div class="wide field {{if device.isMobile 'sixteen' 'five'}}">
           <label>{{t 'Valid from'}}</label>
-          {{widgets/forms/date-picker id='start_date' value=data.validFromDate rangePosition='start'}}
+          {{widgets/forms/date-picker name='start_date' value=data.validFromDate rangePosition='start'}}
           <div class="ui hidden divider"></div>
-          {{widgets/forms/time-picker inputId='start_time' value=data.validFromTime rangePosition='start'}}
+          {{widgets/forms/time-picker name='start_time' value=data.validFromTime}}
         </div>
         <div class="wide field {{if device.isMobile 'sixteen' 'five'}}">
           <label>{{t 'Expires on'}}</label>
-          {{widgets/forms/date-picker type="text" inputId='end_date' value=data.validTillDate rangePosition='end'}}
+          {{widgets/forms/date-picker type="text" name='end_date' value=data.validTillDate rangePosition='end'}}
           <div class="ui hidden divider"></div>
-          {{widgets/forms/time-picker type="text" inputId='end_time' value=data.validTillTime rangePosition='end'}}
+          {{widgets/forms/time-picker type="text" name='end_time' value=data.validTillTime}}
         </div>
       </div>
     {{/if}}

app/templates/components/widgets/forms/date-picker.hbs

@@ -1,3 +1,4 @@
+
 {{#if icon}}
   <i class="calendar icon"></i>
 {{/if}}