Skip to content

Commit 7cbf3fe

Browse files
uds5501pradeepgangwar
authored andcommitted
fix: add placed orders in tickets overview (#3151)
* ticket overview table includes placed tickets * fix overview integration tests
1 parent 402b556 commit 7cbf3fe

File tree

3 files changed

+21
-7
lines changed

3 files changed

+21
-7
lines changed
Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
import Component from '@ember/component';
2+
import { computed } from '@ember/object';
23

34
export default Component.extend({
4-
classNames: ['ui', 'fluid', 'card']
5+
classNames: ['ui', 'fluid', 'card'],
6+
7+
tickets: computed('data.orderStat.tickets', function() {
8+
return this.data.orderStat.tickets.completed + this.data.orderStat.tickets.placed;
9+
}),
10+
orders: computed('data.orderStat.orders', function() {
11+
return this.data.orderStat.orders.completed + this.data.orderStat.orders.placed;
12+
}),
13+
sales: computed('data.orderStat.sales', function() {
14+
return this.data.orderStat.sales.completed + this.data.orderStat.sales.placed;
15+
})
516
});

app/templates/components/events/view/overview/event-tickets.hbs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@
77
<tbody>
88
<tr>
99
<td>{{t 'Total tickets sold'}}</td>
10-
<td>{{data.orderStat.tickets.completed}}</td>
10+
<td>{{tickets}}</td>
1111
</tr>
1212
<tr>
1313
<td>{{t 'No. of orders'}}</td>
14-
<td>{{data.orderStat.orders.completed}}</td>
14+
<td>{{orders}}</td>
1515
</tr>
1616
<tr>
1717
<td>{{t 'Sales (amount)'}}</td>
18-
<td>{{currency-symbol data.event.paymentCurrency}} {{format-number data.orderStat.sales.completed}}</td>
18+
<td>{{currency-symbol data.event.paymentCurrency}} {{format-number sales}}</td>
1919
</tr>
2020
</tbody>
2121
</table>
@@ -33,9 +33,9 @@
3333
{{#each data.tickets as |ticket|}}
3434
<tr>
3535
<td>{{ticket.name}}</td>
36-
<td>{{ticket.orderStatistics.tickets.completed}}</td>
36+
<td>{{add ticket.orderStatistics.tickets.completed ticket.orderStatistics.tickets.placed}}</td>
3737
<td>{{ticket.quantity}}</td>
38-
<td>{{sub ticket.quantity ticket.orderStatistics.tickets.completed}}</td>
38+
<td>{{sub ticket.quantity (add ticket.orderStatistics.tickets.completed ticket.orderStatistics.tickets.placed)}}</td>
3939
</tr>
4040
{{else}}
4141
<div class="ui basic segment">

tests/integration/components/events/view/overview/event-tickets-test.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@ module('Integration | Component | events/view/overview/event tickets', function(
1212
paymentCurrency: 'USD'
1313
}
1414
});
15-
await render(hbs`{{events/view/overview/event-tickets data=model}}`);
15+
this.set('tickets', 10);
16+
this.set('orders', 10);
17+
this.set('sales', 100);
18+
await render(hbs`{{events/view/overview/event-tickets data=model tickets=tickets orders=orders sales=sales}}`);
1619
assert.ok(this.element.innerHTML.trim().includes('Tickets'));
1720
});
1821
});

0 commit comments

Comments
 (0)