fix: Refactor buyer name fields in order-form (#3028)

* refactor buyer name fields in order form

* use oneWay and readOnly properties

Author: uds5501

app/components/forms/orders/order-form.js

@@ -1,5 +1,6 @@
 import Component from '@ember/component';
 import { computed } from '@ember/object';
+import { readOnly, oneWay } from '@ember/object/computed';
 import { run } from '@ember/runloop';
 import { inject as service } from '@ember/service';
 import FormMixin from 'open-event-frontend/mixins/form';
@@ -14,18 +15,12 @@ import {
 export default Component.extend(FormMixin, {
   router: service(),
 
-  buyer: computed('data.user', function() {
-    return this.get('data.user');
-  }),
-
-  buyerHasFirstName: computed(function() {
-    return this.get('data.user.firstName');
-  }),
-
-  buyerHasLastName: computed(function() {
-    return this.get('data.user.lastName');
-  }),
-  holders: computed('data.attendees', function() {
+  buyerFirstName    : oneWay('buyerHasFirstName'),
+  buyerLastName     : oneWay('buyerHasLastName'),
+  buyer             : readOnly('data.user'),
+  buyerHasFirstName : readOnly('data.user.firstName'),
+  buyerHasLastName  : readOnly('data.user.lastName'),
+  holders           : computed('data.attendees', function() {
     this.get('data.attendees').forEach(attendee => {
       attendee.set('firstname', '');
       attendee.set('lastname', '');
@@ -474,13 +469,16 @@ export default Component.extend(FormMixin, {
   actions: {
     submit(data) {
       this.onValid(() => {
+        let currentUser = this.get('data.user');
+        currentUser.set('firstName', this.buyerFirstName);
+        currentUser.set('lastName', this.buyerLastName);
         this.sendAction('save', data);
       });
     },
     modifyHolder(holder) {
       if (this.sameAsBuyer) {
-        holder.set('firstname', this.buyer.content.firstName);
-        holder.set('lastname', this.buyer.content.lastName);
+        holder.set('firstname', this.buyerFirstName);
+        holder.set('lastname', this.buyerLastName);
         holder.set('email', this.buyer.content.email);
       } else {
         holder.set('firstname', '');

app/templates/components/forms/orders/order-form.hbs

@@ -22,11 +22,11 @@
       </h4>
       <div class="field {{if buyerHasFirstName 'disabled'}}">
         <label class="required" for="firstname">{{t 'First Name'}}</label>
-        {{input type='text' name='first_name' value=buyer.firstName}}
+        {{input type='text' name='first_name' value=buyerFirstName}}
       </div>
       <div class="field {{if buyerHasLastName 'disabled'}}">
         <label class="required" for="lastname">{{t 'Last Name'}}</label>
-        {{input type='text' name='last_name' value=buyer.lastName}}
+        {{input type='text' name='last_name' value=buyerLastName}}
       </div>
       <div class="field disabled">
         <label class="required" for="email">{{t 'Email'}}</label>