chore(deps-dev): bump eslint-plugin-ember-suave from 1.0.0 to 2.0.1 (#3905)

dependabot-preview[bot] · iamareebjamal · web-flow · commit b1cc41b91ab2 · 2020-01-30T23:11:02.000+05:30
* chore(deps-dev): bump eslint-plugin-ember-suave from 1.0.0 to 2.0.1

Bumps eslint-plugin-ember-suave from 1.0.0 to 2.0.1.

Signed-off-by: dependabot-preview[bot] &lt;support@dependabot.com&gt;

Co-authored-by: Areeb Jamal &lt;jamal.areeb@gmail.com&gt;
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -6,7 +6,8 @@ module.exports = {
     sourceType: 'module'
   },
   plugins: [
-    'ember'
+    'ember',
+    'ember-suave'
   ],
   extends: [
     'eslint:recommended',
@@ -66,9 +67,16 @@ module.exports = {
     'new-cap': 'off',
     'eqeqeq': ['error', 'smart'],
     'one-var': 'off',
+    'padding-line-between-statements': 'off',
+    'lines-between-class-members': ['error', "always", { exceptAfterSingleLine: true }],
     'ember-suave/no-const-outside-module-scope': 'off',
     'ember-suave/require-access-in-comments': 'off',
+    'ember-suave/lines-between-object-properties': 'off',
     'ember/no-get': 'error',
+    // TODO: Re-enable later
+    'no-duplicate-imports': 'warn',
+    'no-await-in-loop': 'warn',
+    'import/no-relative-parent-imports': 'warn',
   },
   globals: {
     module     : true,
diff --git a/app/components/forms/admin/settings/system/captcha-form.js b/app/components/forms/admin/settings/system/captcha-form.js
@@ -2,4 +2,4 @@ import Component from '@ember/component';
 
 export default class extends Component {
 
-}
+}
diff --git a/app/components/forms/admin/settings/system/order-expiry-form.js b/app/components/forms/admin/settings/system/order-expiry-form.js
@@ -2,4 +2,4 @@ import Component from '@ember/component';
 
 export default class extends Component {
 
-}
+}
diff --git a/app/components/modals/cropper-modal.js b/app/components/modals/cropper-modal.js
@@ -27,11 +27,13 @@ export default class extends ModalBase {
     }
 
   }
+
   @action
   resetImage() {
     this.onHide();
     this.onVisible();
   }
+
   @action
   cropImage() {
     $('img', this.element).croppie('result', { type: 'base64', size: 'original', quality: 1, format: 'jpeg' }).then(result => {
diff --git a/app/components/paypal-button.js b/app/components/paypal-button.js
@@ -136,4 +136,4 @@ export default Component.extend({
 
     }
   }
-});
+});
diff --git a/app/components/public/ticket-list.js b/app/components/public/ticket-list.js
@@ -2,9 +2,8 @@ import Component from '@ember/component';
 import { computed } from '@ember/object';
 import FormMixin from 'open-event-frontend/mixins/form';
 import { inject as service } from '@ember/service';
-import { sumBy } from 'lodash-es';
+import { sumBy, merge } from 'lodash-es';
 import { A } from '@ember/array';
-import { merge } from 'lodash-es';
 
 export default Component.extend(FormMixin, {
   store: service(),
diff --git a/app/components/tables/utilities/pagination.js b/app/components/tables/utilities/pagination.js
@@ -35,6 +35,7 @@ export default class extends Component {
     return this.currentPage <= 1;
 
   }
+
   @computed('currentPage', 'pageCount')
   get moveToNextPageDisabled() {
     return this.currentPage >= this.pageCount;
diff --git a/app/components/ui-table-server.js b/app/components/ui-table-server.js
@@ -83,8 +83,7 @@ export default ModelsTable.extend({
     if (!get(this.data, 'query')) {
       console.warn('You must use https://emberjs.com/api/data/classes/DS.Store.html#method_query for loading data');
       query = merge({}, this.query);
-      store = this.store;
-      modelName = this.modelName;
+      ({ store, modelName } = this);
     } else {
       query = merge({}, get(this.data, 'query'));
       store = get(this.data, 'store');
diff --git a/app/components/widgets/forms/billing-info.js b/app/components/widgets/forms/billing-info.js
@@ -7,4 +7,4 @@ export default Component.extend({
   countries: computed(function() {
     return orderBy(countries, 'name');
   })
-});
+});
diff --git a/app/controllers/account/billing/invoices/list.js b/app/controllers/account/billing/invoices/list.js
@@ -139,4 +139,4 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
     }
     return columns;
   }
-}
+}
diff --git a/app/controllers/admin/content/events.js b/app/controllers/admin/content/events.js
@@ -23,6 +23,7 @@ export default class extends Controller {
       this.set('isLoading', false);
     }
   }
+
   @action
   openModalFor(modelInstanceOrName) {
     const modelName = typeof modelInstanceOrName === 'string' ? modelInstanceOrName : modelInstanceOrName.constructor.modelName;
@@ -31,6 +32,7 @@ export default class extends Controller {
     this.set(camelCasedValue, modelInstance);
     modelInstance.openModal = true;
   }
+
   @action
   deleteEventProperty(eventProp) {
     this.set('isLoading', true);
@@ -53,6 +55,7 @@ export default class extends Controller {
         this.set('isLoading', false);
       });
   }
+
   @action
   addEventProperty(modelInstance) {
     const camelCasedValue = camelCase(modelInstance.constructor.modelName);
diff --git a/app/controllers/admin/content/pages.js b/app/controllers/admin/content/pages.js
@@ -19,6 +19,7 @@ export default class extends Controller {
     }
     this.set('isFormOpen', true);
   }
+
   @action
   savePage(page) {
     page.save()
diff --git a/app/controllers/admin/content/system-images/list.js b/app/controllers/admin/content/system-images/list.js
@@ -1,6 +1,5 @@
 import Controller from '@ember/controller';
-import { computed } from '@ember/object';
-import { action } from '@ember/object';
+import { computed, action } from '@ember/object';
 
 export default class extends Controller {
 
diff --git a/app/controllers/admin/events/list.js b/app/controllers/admin/events/list.js
@@ -147,6 +147,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
       isEventDeleteModalOpen : false
     });
   }
+
   @action
   async restoreEvent(event_id) {
     this.set('isLoading', true);
diff --git a/app/controllers/admin/permissions/event-roles.js b/app/controllers/admin/permissions/event-roles.js
@@ -6,6 +6,7 @@ export default class extends Controller {
   get services() {
     return this.model.services.sortBy('name');
   }
+
   @computed('model.permissions')
   get permissions() {
     return this.model.permissions.sortBy('serviceName');
diff --git a/app/controllers/admin/permissions/system-roles.js b/app/controllers/admin/permissions/system-roles.js
@@ -26,6 +26,7 @@ export default class extends Controller {
     }
     this.set('isAddSystemRoleModalOpen', true);
   }
+
   @action
   deleteSystemRole(role) {
     this.set('isLoading', true);
@@ -46,6 +47,7 @@ export default class extends Controller {
         this.set('isLoading', false);
       });
   }
+
   @action
   addSystemRole() {
     this.set('isLoading', true);
@@ -83,6 +85,7 @@ export default class extends Controller {
         });
     }
   }
+
   @action
   updatePermissions() {
     this.set('isLoading', true);
diff --git a/app/controllers/admin/sessions/list.js b/app/controllers/admin/sessions/list.js
@@ -71,6 +71,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
       }
     ];
   }
+
   @action
   async deleteSession(session_id) {
     this.set('isLoading', true);
diff --git a/app/controllers/admin/settings/billing.js b/app/controllers/admin/settings/billing.js
@@ -12,6 +12,7 @@ export default class extends Controller {
   get countries() {
     return orderBy(filter(countries, country => paymentCountries.includes(country.code)), 'name');
   }
+
   payment
   @action
   async updateInvoiceModel() {
diff --git a/app/controllers/create.js b/app/controllers/create.js
@@ -10,6 +10,7 @@ export default class extends Controller.extend(EventWizardMixin) {
       ['tickets', 'socialLinks', 'copyright', 'tax', 'stripeAuthorization']
     );
   }
+
   @action
   move() {
     this.saveEventDataAndRedirectTo(
diff --git a/app/controllers/event-invoice/paid.js b/app/controllers/event-invoice/paid.js
@@ -27,4 +27,4 @@ export default class extends Controller {
     }
     this.set('isLoading', false);
   }
-}
+}
diff --git a/app/controllers/events/import.js b/app/controllers/events/import.js
@@ -31,6 +31,7 @@ export default class extends Controller {
         });
     }, 3000);
   }
+
   @action
   uploadFile(files) {
     let [file] = files;
diff --git a/app/controllers/events/view.js b/app/controllers/events/view.js
@@ -7,6 +7,7 @@ export default class extends Controller {
   openDeleteEventModal() {
     this.set('isEventDeleteModalOpen', true);
   }
+
   @action
   togglePublishState() {
     if (isEmpty(this.model.locationName)) {
@@ -44,6 +45,7 @@ export default class extends Controller {
         this.set('isLoading', false);
       });
   }
+
   @action
   deleteEvent() {
     this.set('isLoading', true);
@@ -66,6 +68,7 @@ export default class extends Controller {
       });
     this.set('isEventDeleteModalOpen', false);
   }
+
   @action
   copyEvent() {
     this.set('isCopying', true);
diff --git a/app/controllers/events/view/edit/attendee.js b/app/controllers/events/view/edit/attendee.js
@@ -38,4 +38,4 @@ export default Controller.extend(EventWizardMixin, {
       }
     }
   }
-});
+});
diff --git a/app/controllers/events/view/edit/basic-details.js b/app/controllers/events/view/edit/basic-details.js
@@ -16,4 +16,4 @@ export default Controller.extend(EventWizardMixin, {
       );
     }
   }
-});
+});
diff --git a/app/controllers/events/view/edit/sessions-speakers.js b/app/controllers/events/view/edit/sessions-speakers.js
@@ -28,4 +28,4 @@ export default Controller.extend(EventWizardMixin, {
       );
     }
   }
-});
+});
diff --git a/app/controllers/events/view/edit/sponsors.js b/app/controllers/events/view/edit/sponsors.js
@@ -18,4 +18,4 @@ export default Controller.extend(EventWizardMixin, {
     }
   }
 
-});
+});
diff --git a/app/controllers/events/view/export.js b/app/controllers/events/view/export.js
@@ -53,6 +53,7 @@ export default class extends Controller {
         });
     }, 3000);
   }
+
   @action
   startGeneration() {
     this.set('isLoading', true);
diff --git a/app/controllers/events/view/scheduler.js b/app/controllers/events/view/scheduler.js
@@ -11,18 +11,21 @@ export default class extends Controller {
     }
     return false;
   }
+
   isLoading = false;
   header    = {
     left   : 'today prev,next',
     center : 'title',
     right  : 'timelineDay,timelineThreeDays,agendaWeek,month'
   }
+
   view = {
     timelineThreeDays: {
       type     : 'timeline',
       duration : { days: 3 }
     }
   }
+
   updateSession(start, end, microlocationId, sessionId) {
     let payload = {
       data: {
@@ -58,11 +61,13 @@ export default class extends Controller {
         this.notify.error(`Error: ${reason}`);
       });
   }
+
   unscheduleSession(session) {
     window.$('.full-calendar').fullCalendar('removeEvents', session._id);
     this.updateSession(null, null, session.resourceId, session.serverId);
     this.target.send('refresh');
   }
+
   @action
   drop(date, jsEvent, ui, resourceId) {
     let start = date;
@@ -71,14 +76,17 @@ export default class extends Controller {
     this.updateSession(start, end, resourceId, window.$(ui.helper).data('serverId'));
     window.$(ui.helper).remove();
   }
+
   @action
   eventDrop(session) {
     this.updateSession(session.start, session.end, session.resourceId, session.serverId);
   }
+
   @action
   eventResize(session) {
     this.updateSession(session.start, session.end, session.resourceId, session.serverId);
   }
+
   @action
   eventRender(session, element) {
     element.append('<span class="scheduled-close-btn"><i class="x icon"></i></span>');
@@ -87,6 +95,7 @@ export default class extends Controller {
       controller.unscheduleSession(session);
     });
   }
+
   @action
   togglePublishState() {
     this.set('isLoading', true);
diff --git a/app/controllers/events/view/tickets/access-codes/list.js b/app/controllers/events/view/tickets/access-codes/list.js
@@ -59,6 +59,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
         this.set('isLoading', false);
       });
   }
+
     @action
   toggleStatus(access_id) {
     this.set('isLoading', true);
@@ -76,6 +77,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
         this.set('isLoading', false);
       });
   }
+
     @action
     editAccessCode(id) {
       this.transitionToRoute('events.view.tickets.access-codes.edit', id);
diff --git a/app/controllers/events/view/tickets/orders/list.js b/app/controllers/events/view/tickets/orders/list.js
@@ -75,6 +75,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
         this.set('isLoading', false);
       });
   }
+
   @action
   deleteOrder(order_id) {
     this.set('isLoading', true);
diff --git a/app/controllers/my-sessions/view.js b/app/controllers/my-sessions/view.js
@@ -41,4 +41,4 @@ export default class extends Controller {
         this.set('isProposalDeleteModalOpen', false);
       });
   }
-}
+}
diff --git a/app/controllers/public/index.js b/app/controllers/public/index.js
@@ -149,4 +149,4 @@ export default Controller.extend({
     }
   }
 
-});
+});
diff --git a/app/helpers/header-date.js b/app/helpers/header-date.js
@@ -6,4 +6,4 @@ export function headerDate(params) {
   return `${moment(params[0]).tz(timezone).format('dddd, MMMM Do YYYY, h:mm A')} (${moment.tz(params[0], timezone).zoneAbbr()})`;
 }
 
-export default Helper.helper(headerDate);
+export default Helper.helper(headerDate);
diff --git a/app/models/notification.js b/app/models/notification.js
@@ -1,7 +1,6 @@
 import attr from 'ember-data/attr';
-import { hasMany } from 'ember-data/relationships';
+import { belongsTo, hasMany } from 'ember-data/relationships';
 import ModelBase from 'open-event-frontend/models/base';
-import { belongsTo } from 'ember-data/relationships';
 
 export default ModelBase.extend({
   title      : attr('string'),
diff --git a/app/routes/account/billing/invoices/list.js b/app/routes/account/billing/invoices/list.js
diff --git a/app/routes/account/billing/payment-info.js b/app/routes/account/billing/payment-info.js
diff --git a/app/routes/admin/sessions/list.js b/app/routes/admin/sessions/list.js
diff --git a/app/routes/admin/settings/billing.js b/app/routes/admin/settings/billing.js
diff --git a/app/routes/admin/users/list.js b/app/routes/admin/users/list.js
diff --git a/app/routes/events/view/speakers/list.js b/app/routes/events/view/speakers/list.js
diff --git a/app/routes/events/view/tickets/attendees/list.js b/app/routes/events/view/tickets/attendees/list.js
diff --git a/app/routes/events/view/tickets/discount-codes/list.js b/app/routes/events/view/tickets/discount-codes/list.js
diff --git a/app/utils/dictionary/amazon-s3-regions.js b/app/utils/dictionary/amazon-s3-regions.js
diff --git a/app/utils/dictionary/genders.js b/app/utils/dictionary/genders.js
diff --git a/package.json b/package.json
diff --git a/tests/acceptance/invoices-test.js b/tests/acceptance/invoices-test.js
diff --git a/tests/acceptance/payment-info-test.js b/tests/acceptance/payment-info-test.js
diff --git a/tests/integration/components/forms/admin/settings/system/order-expiry-form-test.js b/tests/integration/components/forms/admin/settings/system/order-expiry-form-test.js
diff --git a/tests/integration/components/ui-table/cell/events/view/tickets/cell-add-order-price-test.js b/tests/integration/components/ui-table/cell/events/view/tickets/cell-add-order-price-test.js
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -2,4 +2,4 @@ import Component from '@ember/component';`
`2`	`2`
`3`	`3`	`export default class extends Component {`
`4`	`4`
`5`		`-}`
	`5`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,13 @@ export default class extends ModalBase {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`}`
	`30`	`+`
`30`	`31`	`@action`
`31`	`32`	`resetImage() {`
`32`	`33`	`this.onHide();`
`33`	`34`	`this.onVisible();`
`34`	`35`	`}`
	`36`	`+`
`35`	`37`	`@action`
`36`	`38`	`cropImage() {`
`37`	`39`	`$('img', this.element).croppie('result', { type: 'base64', size: 'original', quality: 1, format: 'jpeg' }).then(result => {`
Original file line number	Diff line number	Diff line change
`@@ -136,4 +136,4 @@ export default Component.extend({`
`136`	`136`
`137`	`137`	`}`
`138`	`138`	`}`
`139`		`-});`
	`139`	`+});`
Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ export default class extends Component {`
`35`	`35`	`return this.currentPage <= 1;`
`36`	`36`
`37`	`37`	`}`
	`38`	`+`
`38`	`39`	`@computed('currentPage', 'pageCount')`
`39`	`40`	`get moveToNextPageDisabled() {`
`40`	`41`	`return this.currentPage >= this.pageCount;`
Original file line number	Diff line number	Diff line change
`@@ -139,4 +139,4 @@ export default class extends Controller.extend(EmberTableControllerMixin) {`
`139`	`139`	`}`
`140`	`140`	`return columns;`
`141`	`141`	`}`
`142`		`-}`
	`142`	`+}`