feat: fix date-time bugs in wizard step 2:

Author: abhinavk96

app/components/forms/wizard/sessions-speakers-step.js

@@ -3,10 +3,16 @@ import { computed } from '@ember/object';
 import FormMixin from 'open-event-frontend/mixins/form';
 import EventWizardMixin from 'open-event-frontend/mixins/event-wizard';
 import { groupBy } from 'lodash-es';
+import moment from 'moment';
 
 export default Component.extend(EventWizardMixin, FormMixin, {
 
   getValidationRules() {
+    window.$.fn.form.settings.rules.checkDates = () => {
+      let startDatetime = moment(this.get('data.speakersCall.startsAt'));
+      let endDatetime = moment(this.get('data.speakersCall.endsAt'));
+      return (endDatetime.diff(startDatetime, 'minutes') > 0);
+    };
     return {
       inline : true,
       delay  : false,
@@ -47,6 +53,60 @@ export default Component.extend(EventWizardMixin, FormMixin, {
               prompt : this.l10n.t('Please select the Privacy')
             }
           ]
+        },
+        startDate: {
+          identifier : 'start_date',
+          rules      : [
+            {
+              type   : 'empty',
+              prompt : this.l10n.t('Please tell us when your event starts')
+            },
+            {
+              type   : 'checkDates',
+              prompt : this.l10n.t('Start date & time ')
+            }
+          ]
+        },
+        endDate: {
+          identifier : 'end_date',
+          rules      : [
+            {
+              type   : 'empty',
+              prompt : this.l10n.t('Please tell us when your event ends')
+            },
+            {
+              type   : 'checkDates',
+              prompt : this.l10n.t('Start date & time should be after End date and time')
+            }
+          ]
+        },
+        startTime: {
+          identifier : 'start_time',
+          depends    : 'start_date',
+          rules      : [
+            {
+              type   : 'empty',
+              prompt : this.l10n.t('Please give a start time')
+            },
+            {
+              type   : 'checkDates',
+              prompt : '.'
+            }
+          ]
+        },
+        endTime: {
+          identifier : 'end_time',
+          depends    : 'end_date',
+          rules      : [
+            {
+              type   : 'empty',
+              prompt : this.l10n.t('Please give an end time')
+            },
+            {
+              type   : 'checkDates',
+              prompt : '.'
+            }
+          ]
         }
       }
     };
@@ -113,6 +173,9 @@ export default Component.extend(EventWizardMixin, FormMixin, {
           this.get('data.microlocations').addObject(this.store.createRecord('microlocation'));
           break;
       }
+    },
+    onChange() {
+      this.onValid(() => {});
     }
   }
 });

app/models/discount-code.js

@@ -5,7 +5,6 @@ import moment from 'moment';
 import { hasMany, belongsTo } from 'ember-data/relationships';
 import { computedDateTimeSplit } from 'open-event-frontend/utils/computed-helpers';
 
-const detectedTimezone = moment.tz.guess();
 
 /**
  * Two different forms of discount code can exist. (Both use the same model)

app/routes/events/view/tickets/discount-codes/create.js

@@ -1,5 +1,4 @@
 import Route from '@ember/routing/route';
-import moment from 'moment';
 
 export default Route.extend({
   titleToken() {
@@ -33,7 +32,6 @@ export default Route.extend({
     });
     let currentDiscountCode = model.discountCode;
     let event = this.modelFor('events.view');
-    currentDiscountCode.set('validFrom', moment().toISOString());
     currentDiscountCode.set('validTill', event.endsAt);
     currentDiscountCode.set('minQuantity', 1);
     currentDiscountCode.set('maxQuantity', 1);

app/templates/components/forms/wizard/sessions-speakers-step.hbs

@@ -118,33 +118,35 @@
       <div class="five wide field">
         <label class="required" for="start_date">{{t 'Starts'}}</label>
         {{widgets/forms/date-picker type='text'
-                                    inputId='start_date'
+                                    name='start_date'
                                     placeholder='MM/DD/YYYY'
                                     rangePosition='start'
+                                    onChange=(action 'onChange')
                                     value=data.speakersCall.startsAtDate}}
       </div>
       <div class="two wide field">
         <label for="start_time">&nbsp;</label>
         {{widgets/forms/time-picker type='text'
-                                    inputId='start_time'
+                                    name='start_time'
                                     placeholder='HH:MM'
-                                    rangePosition='start'
+                                    onChange=(action 'onChange')
                                     value=data.speakersCall.startsAtTime}}
       </div>
       <div class="five wide field">
         <label class="required" for="end_date">{{t 'Ends'}}</label>
         {{widgets/forms/date-picker type='text'
-                                    inputId='end_date'
+                                    name='end_date'
                                     placeholder='MM/DD/YYYY'
                                     rangePosition='end'
+                                    onChange=(action 'onChange')
                                     value=data.speakersCall.endsAtDate}}
       </div>
       <div class="two wide field">
         <label for="end_time">&nbsp;</label>
         {{widgets/forms/time-picker type='text'
-                                    inputId='end_time'
+                                    name='end_time'
                                     placeholder='HH:MM'
-                                    rangePosition='end'
+                                    onChange=(action 'onChange')
                                     value=data.speakersCall.endsAtTime}}
       </div>
       <div class="five wide field">

app/utils/computed-helpers.js

@@ -45,13 +45,11 @@ export const computedSegmentedLink = function(property) {
  * @returns {*}
  */
 export const computedDateTimeSplit = function(property, segmentFormat, endProperty) {
-  console.log(property);
   return computed(property, {
     get() {
       return moment(this.get(property)).format(getFormat(segmentFormat));
     },
     set(key, value) {
-      console.log(key, value, this);
       const newDate = moment(value, getFormat(segmentFormat));
       let oldDate = newDate;
       if (this.get(property)) {