Skip to content

Commit c7ddd9c

Browse files
maze-runnarkushthedude
authored andcommitted
fix: side menu icon should not be visible in mobile when there… (#3665)
* side menu icon should not be visible * adding displaySideMenu computed property * using displaySideMenu computed property in public.hbs * removing es5 getter Co-authored-by: Kush Trivedi <[email protected]>
1 parent a256185 commit c7ddd9c

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

app/controllers/public.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ export default Controller.extend({
1111
displayEndDate: computed('model.startsAtDate', 'model.endsAtDate', function() {
1212
return !moment(this.model.startsAtDate).isSame(this.model.endsAtDate, 'minute');
1313
}),
14+
displaySideMenu: computed('session.currentRouteName', function() {
15+
if (this.session.currentRouteName) {
16+
return this.session.currentRouteName !== 'public.cfs.new-session' && this.session.currentRouteName !== 'public.cfs.new-speaker' && this.session.currentRouteName !== 'public.cfs.edit-speaker' && this.session.currentRouteName !== 'public.cfs.edit-session';
17+
}
18+
}),
1419
actions: {
1520
toggleMenu() {
1621
this.toggleProperty('isMenuOpen');

app/templates/public.hbs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,13 @@
2626
<div class="ui stackable grid">
2727
<div class="three wide column" id="public-event-content">
2828
{{#if device.isMobile}}
29-
<button {{action 'toggleMenu'}} class="ui basic icon button mobile only">
30-
<i class="content icon"></i>
31-
</button>
32-
{{#if isMenuOpen}}
33-
{{public/side-menu class='toggle menu' event=model}}
29+
{{#if displaySideMenu}}
30+
<button {{action 'toggleMenu'}} class="ui basic icon button mobile only">
31+
<i class="content icon"></i>
32+
</button>
33+
{{#if isMenuOpen}}
34+
{{public/side-menu class='toggle menu' event=model}}
35+
{{/if}}
3436
{{/if}}
3537
{{else}}
3638
{{#ui-sticky context='#public-event-content' observeChanges=true}}

0 commit comments

Comments
 (0)