fix #8886: attach sameAsBuyer option to every ticket holder

Author: Rebekka Rossberg

app/components/forms/orders/order-form.js

@@ -29,8 +29,8 @@ export default Component.extend(FormMixin, {
   buyerHasFirstName : readOnly('data.user.firstName'),
   buyerHasLastName  : readOnly('data.user.lastName'),
   holders           : computed('data.attendees', 'buyer', function() {
-    this.data.attendees.forEach((attendee, index) => {
-      if (index === 0 && this.buyerFirstName && this.buyerLastName) {
+    this.data.attendees.forEach(attendee => {
+      if (this.buyerFirstName && this.buyerLastName) {
         attendee.set('firstname', this.buyerFirstName);
         attendee.set('lastname', this.buyerLastName);
         attendee.set('email', this.buyer.get('email'));
@@ -49,9 +49,6 @@ export default Component.extend(FormMixin, {
     }
     return true;
   }),
-  sameAsBuyer: computed('data', function() {
-    return (this.buyerHasFirstName && this.buyerHasLastName);
-  }),
 
   isBillingInfoNeeded: computed('event', 'data.isBillingEnabled', function() {
     return this.event.isBillingInfoMandatory || this.data.isBillingEnabled;
@@ -687,8 +684,9 @@ export default Component.extend(FormMixin, {
         this.sendAction('save', data);
       });
     },
-    modifyHolder(holder) {
-      if (this.sameAsBuyer) {
+    triggerSameAsBuyerOption(holder) {
+      holder.set('sameAsBuyer', !holder.sameAsBuyer);
+      if (holder.sameAsBuyer) {
         holder.set('firstname', this.buyerFirstName);
         holder.set('lastname', this.buyerLastName);
         holder.set('email', this.buyer.content.email);

app/models/attendee.js

@@ -7,6 +7,7 @@ export default ModelBase.extend({
   /**
    * Attributes
    */
+  sameAsBuyer                 : attr('boolean', { defaultValue: true }),
   city                        : attr('string'),
   firstname                   : attr('string'),
   lastname                    : attr('string'),

app/templates/components/forms/orders/order-form.hbs

@@ -56,14 +56,6 @@
         {{/if}}
       </h4>
       {{#each this.holders as |holder index|}}
-        {{#if (eq index 0)}}
-          <div class="field">
-            <UiCheckbox
-              @label={{t "Ticket holder is the same person as ticket buyer"}}
-              @checked={{this.sameAsBuyer}}
-              @onChange={{pipe-action (action (mut this.sameAsBuyer)) (action "modifyHolder" holder)}} />
-          </div>
-        {{/if}}
         <div class="inline field">
           <i class="user icon"></i>
           <label>
@@ -75,6 +67,12 @@
             {{inc index}}{{t ' -for- '}}{{holder.ticket.name}}
           </label>
         </div>
+        <div class="field">
+          <UiCheckbox
+            @label={{t "Ticket holder is the same person as ticket buyer"}}
+            @checked={{holder.sameAsBuyer}}
+            @onChange={{action "triggerSameAsBuyerOption" holder}} />
+        </div>
         {{#each this.allFields.attendee as |field index|}}
           {{#if field.isIncluded }}
             {{#if (or field.isFixed (and this.event.isTicketFormEnabled (or (eq holder.ticket.formID null) (eq holder.ticket.formID field.formID))))}}
@@ -101,7 +99,7 @@
                       @value={{mut (get holder field.identifierPath)}}
                       @name={{if field.isRequired (concat field.fieldIdentifier "_required_" index) (concat field.fieldIdentifier "_" index)}} />
                   {{else}}
-                    {{#if (and this.sameAsBuyer (eq index 0) (or (eq field.fieldIdentifier 'firstname') (eq field.fieldIdentifier 'lastname') (eq field.fieldIdentifier 'email')))}}
+                    {{#if (and holder.sameAsBuyer (or (eq field.fieldIdentifier 'firstname') (eq field.fieldIdentifier 'lastname') (eq field.fieldIdentifier 'email')))}}
                       <Input
                         @type={{field.type}}
                         @value={{mut (get holder field.identifierPath)}}
@@ -114,7 +112,6 @@
                         @name={{if field.isRequired (concat field.fieldIdentifier "_required_" index) (concat field.fieldIdentifier "_" index)}} 
                         @min={{if field.min field.min null}} @max={{if field.max field.max null}}/>
                     {{else}}
-                    
                       <Input
                         @type={{field.type}}
                         @value={{mut (get holder field.identifierPath)}}