Skip to content

Commit f1fcb70

Browse files
shreyanshdwivediabhinavk96
authored andcommitted
fix: bugs in events/session table (#3443)
1 parent cca08f3 commit f1fcb70

File tree

4 files changed

+22
-26
lines changed

4 files changed

+22
-26
lines changed

app/controllers/events/view/sessions/list.js

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
1111
return [
1212
{
1313
name : 'State',
14-
valuePath : 'status',
14+
valuePath : 'state',
1515
isSortable : true,
1616
headerComponent : 'tables/headers/sort',
1717
cellComponent : 'ui-table/cell/events/view/sessions/cell-session-state'
@@ -38,7 +38,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
3838
{
3939
name : 'Rating',
4040
valuePath : 'id',
41-
extraValuePaths : ['rating', 'feedbacks'],
41+
extraValuePaths : ['feedbacks'],
4242
cellComponent : 'ui-table/cell/events/view/sessions/cell-rating',
4343
options : {
4444
ratedSessions: this.ratedSessions
@@ -49,16 +49,12 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
4949
}
5050
},
5151
{
52-
name : 'Avg Rating',
53-
valuePath : 'averageRating',
54-
isSortable : true,
55-
headerComponent : 'tables/headers/sort'
52+
name : 'Avg Rating',
53+
valuePath : 'averageRating'
5654
},
5755
{
58-
name : 'No. of ratings',
59-
valuePath : 'feedbacks.length',
60-
isSortable : true,
61-
headerComponent : 'tables/headers/sort'
56+
name : 'No. of ratings',
57+
valuePath : 'feedbacks.length'
6258
},
6359
{
6460
name : 'Track',

app/routes/events/view/sessions/list.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default class extends Route.extend(EmberTableRouteMixin) {
1919

2020
async model(params) {
2121
this.set('params', params);
22-
const searchField = 'name';
22+
const searchField = 'title';
2323
let filterOptions = [];
2424
if (params.session_status === 'pending') {
2525
filterOptions = [
@@ -58,16 +58,6 @@ export default class extends Route.extend(EmberTableRouteMixin) {
5858
}
5959

6060
let store = this.modelFor('events.view');
61-
filterOptions = this.applySearchFilters(filterOptions, params, searchField);
62-
let queryString = {
63-
include : 'speakers,feedbacks',
64-
filter : filterOptions,
65-
'page[size]' : params.per_page || 10,
66-
'page[number]' : params.page || 1
67-
};
68-
queryString = this.applySortFilters(queryString, params);
69-
let data = (await store.query('sessions', queryString)).toArray();
70-
7161
let queryObject = {
7262
include : 'session',
7363
filter : [
@@ -87,8 +77,18 @@ export default class extends Route.extend(EmberTableRouteMixin) {
8777
]
8878
};
8979
let feedbacks = await this.authManager.currentUser.query('feedbacks', queryObject);
80+
81+
filterOptions = this.applySearchFilters(filterOptions, params, searchField);
82+
let queryString = {
83+
include : 'speakers,feedbacks',
84+
filter : filterOptions,
85+
'page[size]' : params.per_page || 10,
86+
'page[number]' : params.page || 1
87+
};
88+
queryString = this.applySortFilters(queryString, params);
89+
9090
return {
91-
data,
91+
sessions: await this.asArray(store.query('sessions', queryString)),
9292
feedbacks
9393
};
9494
}

app/templates/components/ui-table/cell/events/view/sessions/cell-rating.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
{{else}}
1313
{{ui-rating
1414
initialRating=0
15-
rating=extraRecords.rating
15+
rating=rating
1616
maxRating=5
17-
onRate=(pipe-action (action (mut extraRecords.rating)) (action props.actions.addRating extraRecords.rating record))
17+
onRate=(pipe-action (action (mut rating)) (action props.actions.addRating rating record))
1818
clearable=true}}
1919
{{/if}}

app/templates/events/view/sessions/list.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
<div class="sixteen wide column">
22
{{tables/default columns=columns
3-
rows=model.data
3+
rows=model.sessions.data
44
feedbacks=model.feedbacks
55
currentPage=page
66
pageSize=per_page
77
searchQuery=search
88
sortBy=sort_by
99
sortDir=sort_dir
10-
metaData=model.meta
10+
metaData=model.sessions.meta
1111
filterOptions=filterOptions
1212
widthConstraint="eq-container"
1313
resizeMode="fluid"

0 commit comments

Comments
 (0)